Skip to contentSkip to conversation

powerpc: Sky CPU: redundant or incorrect tests on unsigned

PATCH In review [email protected] 1 participant 1 message Nov 17, 2009 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 powerpc: Sky CPU: redundant or incorrect tests on unsigned

From: Roel Kluin <[email protected]>

count is unsigned and cannot be less than 0.

---

 drivers/misc/hdpuftrs/hdpu_cpustate.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/misc/hdpuftrs/hdpu_cpustate.c renamed from drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned +0 -5
diff -puN drivers/misc/hdpuftrs/hdpu_cpustate.c~powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned drivers/misc/hdpuftrs/hdpu_cpustate.c
@@ -121,8 +121,6 @@ static ssize_t cpustate_read(struct file
 {
 	unsigned char data;
 
-	if (count < 0)
-		return -EFAULT;
 	if (count == 0)
 		return 0;
 
@@ -137,9 +135,6 @@ static ssize_t cpustate_write(struct fil
 {
 	unsigned char data;
 
-	if (count < 0)
-		return -EFAULT;
-
 	if (count == 0)
 		return 0;
 

_