hso: fix soft-lockup
Subsystems (4)
PATCH 2/2 hso: fix soft-lockup
From: Antti Kaijanmäki <[email protected]>
Fix soft-lockup in hso.c which is triggered on SMP machine when modem is removed while file descriptor(s) under /dev are still open:
old version called kref_put() too early which resulted in destroying hso_serial and hso_device objects which were still used later on.
Signed-off-by Antti Kaijanmäki <[email protected]>
Cc Greg KH <[email protected]>
Cc "David S. Miller" <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/usb/hso.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/usb/hso.c renamed from drivers/net/usb/hso.c~hso-fix-soft-lockup +3 -1
@@ -1363,7 +1363,7 @@ static void hso_serial_close(struct tty_/* reset the rts and dtr */ /* do the actual close */ serial->open_count--; -kref_put (&serial->parent->ref, hso_serial_ref_free); +if (serial->open_count <=0 ) { serial->open_count =0 ;spin_lock_irq (&serial->serial_lock);
@@ -1383,6 +1383,8 @@ static void hso_serial_close(struct tty_usb_autopm_put_interface (serial->parent->interface);mutex_unlock (&serial->parent->mutex); + +kref_put (&serial->parent->ref, hso_serial_ref_free); }/* close the requested serial port */
_
From: [email protected]
Date: Tue, 17 Nov 2009 14:50:32 -0800
Quoted 8 lines
From: Antti Kaijanmäki <[email protected]>
Fix soft-lockup in
hso.cwhich is triggered on SMP machine when modem is removed while file descriptor(s) under /dev are still open:old version called
kref_put()too early which resulted in destroyinghso_serialandhso_deviceobjects which were still used later on.
Quoted 6 lines
Signed-off-by Antti Kaijanmäki <[email protected]>Cc Greg KH <[email protected]>Cc "David S. Miller" <[email protected]>Cc Randy Dunlap <[email protected]>Cc <[email protected]>Signed-off-by Andrew Morton <[email protected]>
Applied to net-2.6