Skip to contentSkip to conversation

MX27: Add USB platform devices and resources

PATCH New Alan Carvalho de Assis 2 participants 8 messages Nov 23, 2009 3 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Now sending to right linux-arm address...

Quoted 11 lines · Alan Carvalho de Assis

Hi Sascha,

Quoted 5 lines · Sascha Hauer
Quoted 1 line · javier Martin

This adds clocks and resources for usb in i.mx27 SoC.

Ok, applied to mxc-master.

What do we need now to get USB working on i.MX27?

(replying myself)
I think this Daniel Mack's patch will be necessary:

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-June/002972.html

Sascha, what is missing to this patch be applied?

Best Regards,

Alan

#4 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Quoted 12 lines · Alan Carvalho de Assis

Now sending to right linux-arm address...

Quoted 9 lines · Alan Carvalho de Assis

Hi Sascha,

Quoted 5 lines · Sascha Hauer
Quoted 1 line · javier Martin

This adds clocks and resources for usb in i.mx27 SoC.

Ok, applied to mxc-master.

Quoted 7 lines
Quoted 2 lines

What do we need now to get USB working on i.MX27?

(replying myself)
I think this Daniel Mack's patch will be necessary:

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-June/002972.html

The patch you refer to only contains the relevant bits for MX31, you would need to tweak it a little to make MX27 work as well. I think this has been done already by someone, but I can't remember exactly.

Quoted 1 line

Sascha, what is missing to this patch be applied?

The patch above and some others are already queued for 2.6.33. The ARM specific things are in Sascha's mxc-master, the rest in the USB tree.

Daniel

#5 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Hi Daniel,

Quoted 4 lines · Daniel Mack
Quoted 3 lines · Alan Carvalho de Assis
Quoted 2 lines

What do we need now to get USB working on i.MX27?

Quoted 9 lines
Quoted 4 lines

(replying myself)
I think this Daniel Mack's patch will be necessary:

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-June/002972.html

The patch you refer to only contains the relevant bits for MX31, you would need to tweak it a little to make MX27 work as well. I think this has been done already by someone, but I can't remember exactly.

Thank you Daniel.

I will try to modify it myself. Case you remember someone who already do that, please let me know.

Quoted 5 lines
Quoted 1 line

Sascha, what is missing to this patch be applied?

The patch above and some others are already queued for 2.6.33. The ARM specific things are in Sascha's mxc-master, the rest in the USB tree.

Great! I think i.MX support on mainline kernel is getting better!

Best Regards,

Alan

#6 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Quoted 15 lines · Alan Carvalho de Assis
Quoted 4 lines · Daniel Mack
Quoted 3 lines · Alan Carvalho de Assis
Quoted 2 lines

What do we need now to get USB working on i.MX27?

Quoted 9 lines
Quoted 4 lines

(replying myself)
I think this Daniel Mack's patch will be necessary:

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-June/002972.html

The patch you refer to only contains the relevant bits for MX31, you would need to tweak it a little to make MX27 work as well. I think this has been done already by someone, but I can't remember exactly.

Quoted 4 lines

Thank you Daniel.

I will try to modify it myself. Case you remember someone who already do that, please let me know.

Should be easy to add. All you need to do is modify the parts which are SoC specific, ie, not part of the EHCI spec. See mxc_set_usbcontrol() and check if PORTSC needs some modifications (which I don't believe).

Please also note that there is an amendment patch queued that adds support for MX35; if you file a patch for your platform, it should cleanly apply on top of that one.

For the board specific code, have a look at arch/arm/mach-mx3/mx31lilly.c in Sascha's mxc-master tree and take that as an example.

Quoted 5 lines
Quoted 3 lines

The patch above and some others are already queued for 2.6.33. The ARM specific things are in Sascha's mxc-master, the rest in the USB tree.

Great! I think i.MX support on mainline kernel is getting better!

Help improve it :)

Daniel

#7 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Hi Daniel,

Quoted 8 lines · Daniel Mack
Quoted 3 lines

I will try to modify it myself. Case you remember someone who already do that, please let me know.

Should be easy to add. All you need to do is modify the parts which are SoC specific, ie, not part of the EHCI spec. See mxc_set_usbcontrol() and check if PORTSC needs some modifications (which I don't believe).

In fact PORTSC1 is at same offset (0x184), then it should work to i.MX27 as well.

Quoted 4 lines

Please also note that there is an amendment patch queued that adds support for MX35; if you file a patch for your platform, it should cleanly apply on top of that one.

Sure, I will apply my chance at top of this.

Quoted 4 lines

For the board specific code, have a look at arch/arm/mach-mx3/mx31lilly.c in Sascha's mxc-master tree and take that as an example.

Right, thank you for your help.

Quoted 4 lines
Quoted 1 line

Great! I think i.MX support on mainline kernel is getting better!

Help improve it :)

Yes, this is the plan ;-)

Alan

#8 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Quoted 5 lines · Alan Carvalho de Assis
Quoted 4 lines · Daniel Mack
Quoted 3 lines

I will try to modify it myself. Case you remember someone who already do that, please let me know.

Quoted 7 lines
Quoted 4 lines

Should be easy to add. All you need to do is modify the parts which are SoC specific, ie, not part of the EHCI spec. See mxc_set_usbcontrol() and check if PORTSC needs some modifications (which I don't believe).

In fact PORTSC1 is at same offset (0x184), then it should work to i.MX27 as well.

Check this register thoroughly - I'd bet there is some difference. Just add an cpu_is_mx27() block there and fill in the specific definitions.

Daniel

#9 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

In reply to Daniel Mack

Hi Daniel,

Quoted 5 lines · Daniel Mack

The patch you refer to only contains the relevant bits for MX31, you would need to tweak it a little to make MX27 work as well. I think this has been done already by someone, but I can't remember exactly.

I am getting this error when compiling your driver:

  LD      drivers/usb/core/usbcore.o
  LD      drivers/usb/core/built-in.o
  CC      drivers/usb/host/ehci-hcd.o

In file included from drivers/usb/host/ehci-hcd.c:1107:
drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
drivers/usb/host/ehci-mxc.c:209: error: 'struct otg_transceiver' has no member named 'io_priv' drivers/usb/host/ehci-mxc.c:210: error: implicit declaration of function 'otg_init'
drivers/usb/host/ehci-mxc.c:212: error: implicit declaration of function 'otg_set_vbus'
drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_remove':
drivers/usb/host/ehci-mxc.c:258: error: implicit declaration of function 'otg_shutdown'
make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1 make[2]: *** [drivers/usb/host] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2

What other patches need I to apply before applying your patch?

Best Regards,

Alan

#10 lore raw

PATCH 1/1 MX27: Add USB platform devices and resources

Sorry I found it!

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-07-usb/usb-otg-add-support-for-ulpi-connected-external-transceivers.patch

/me doing like a KLB

Quoted 36 lines · Alan Carvalho de Assis

Hi Daniel,

Quoted 5 lines · Daniel Mack

The patch you refer to only contains the relevant bits for MX31, you would need to tweak it a little to make MX27 work as well. I think this has been done already by someone, but I can't remember exactly.

I am getting this error when compiling your driver:

  LD      drivers/usb/core/usbcore.o
  LD      drivers/usb/core/built-in.o
  CC      drivers/usb/host/ehci-hcd.o

In file included from drivers/usb/host/ehci-hcd.c:1107:
drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_probe':
drivers/usb/host/ehci-mxc.c:209: error: 'struct otg_transceiver' has no member named 'io_priv' drivers/usb/host/ehci-mxc.c:210: error: implicit declaration of function 'otg_init'
drivers/usb/host/ehci-mxc.c:212: error: implicit declaration of function 'otg_set_vbus'
drivers/usb/host/ehci-mxc.c: In function 'ehci_mxc_drv_remove':
drivers/usb/host/ehci-mxc.c:258: error: implicit declaration of function 'otg_shutdown'
make[3]: *** [drivers/usb/host/ehci-hcd.o] Error 1 make[2]: *** [drivers/usb/host] Error 2
make[1]: *** [drivers/usb] Error 2
make: *** [drivers] Error 2

What other patches need I to apply before applying your patch?

Best Regards,

Alan