Skip to contentSkip to conversation

VFlip problem in gspca_pac7311

PATCH Gustavo Chaín Dumit 3 participants 4 messages Nov 23, 2009 – Nov 24, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi

I'm testing a Pixart Imaging device (0x93a:0x2622) Everything works fine, but vertical orientation. Image looks rotated. So I wrote a little hack to prevent it.

(quoted diff) +0 -0

b/drivers/media/video/gspca/pac 7311.c
index 0527144..f7904ec 100644

drivers/media/video/gspca/pac7311.c +2 -1
@@ -690,27 +690,28 @@ static int sd_start(struct gspca_dev *gspca_dev)
        }
        setgain(gspca_dev);
        setexposure(gspca_dev);
-       sethvflip(gspca_dev);
+       if (gspca_dev->dev->descriptor.idProduct != 0x2622)
+               sethvflip(gspca_dev);
 

Any one has the same problem ?
Thanks!

Signature · 2 lines
Gustavo Chaín Dumit
http://0xff.cl
#1 lore raw

Hi,

Quoted 7 lines · Gustavo Chaín Dumit

Hi

I'm testing a Pixart Imaging device (0x93a:0x2622) Everything works fine, but vertical orientation. Image looks rotated. So I wrote a little hack to prevent it.
[...]
Any one has the same problem ?

You might want to have a look to libv4l ( http://freshmeat.net/projects/libv4l )
and the v4lcontrol_flags[] in
http://linuxtv.org/hg/v4l-dvb/file/2f87f537fb2b/v4l2-apps/libv4l/libv4lconvert/control/libv4lcontrol.c . This user space library has a list of laptops where the webcams are installed
for example upside down.

Regards,

Márton Németh

#2 lore raw
Quoted 16 lines · El Mon, 23 Nov 2009 19:27:04 +0100 Németh Márton <[email protected]> escribió:

Hi,

Quoted 7 lines · Gustavo Chaín Dumit

Hi

I'm testing a Pixart Imaging device (0x93a:0x2622) Everything works fine, but vertical orientation. Image looks rotated. So I wrote a little hack to prevent it. [...]
Any one has the same problem ?

You might want to have a look to libv4l
( http://freshmeat.net/projects/libv4l ) and the v4lcontrol_flags[] in
http://linuxtv.org/hg/v4l-dvb/file/2f87f537fb2b/v4l2-apps/libv4l/libv4lconvert/control/libv4lcontrol.c . This user space library has a list of laptops where the webcams are
installed for example upside down.

Quoted 7 lines

Regards,

Márton Németh
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

thanks you!

Signature · 2 lines
Gustavo Chaín Dumit
http://0xff.cl
#3 lore raw
In reply to Gustavo Chaín Dumit
Quoted 17 lines · On Mon, 23 Nov 2009 14:10:42 -0300 Gustavo Chaín Dumit <[email protected]> wrote:

I'm testing a Pixart Imaging device (0x93a:0x2622) Everything works fine, but vertical orientation. Image looks rotated. So I wrote a little hack to prevent it.

(quoted diff) +0 -0

b/drivers/media/video/gspca/pac 7311.c
index 0527144..f7904ec 100644

drivers/media/video/gspca/pac7311.c +2 -1
@@ -690,27 +690,28 @@ static int sd_start(struct gspca_dev *gspca_dev)
        }
        setgain(gspca_dev);
        setexposure(gspca_dev);
-       sethvflip(gspca_dev);
+       if (gspca_dev->dev->descriptor.idProduct != 0x2622)
+               sethvflip(gspca_dev);
 
Quoted 1 line

Any one has the same problem ?

Yes, other people have the same problem with this webcam. I was changing the driver when I found a problem.

The vertical and horizontal flips are set in the register 0x21 of the page 3. The function sethvflip() sets 0x08 for Hflip and 0x04 for Vflip. By default, this register is set to 0x08 and when sethvflip() is called, it sets back the value to 0 (no H nor V flip).

As your patch prevents sethvflip to be called, the value 0x08 should be Vflip and not Hflip. May you confirm that changing Vflip by program (v4l2ucp, v4l2-ctl...) does mirroring?

Regards.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/