Skip to contentSkip to conversation

Fix build failure in examples/standalone

PATCH New Sanjeev Premi 5 participants 9 messages Nov 9, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Some versions of 'make' do not handle trailing white-spaces properly. Trailing spaces in ELF causes a 'fake' source to be added to the variable COBJS; leading to build failure (listed below). The problem was found with GNU Make 3.80.

Using text-function 'strip' as a workaround for the problem.

make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
arm-none-linux-gnueabi-gcc -g -Os -fno-common -ffixed-r8 -msoft-float
-D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2009q1- 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe -DCONFIG_ ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -g -Os -fno-common -ff
ixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanje
ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/includ e -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-inte rwork -march=armv5 -I.. -Bstatic -T u-boot.lds -Ttext 0x80e80000 -o .c arm-none-linux-gnueabi-gcc: no input files
make[1]: *** [.c] Error 1
make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
make: *** [examples/standalone] Error 2
premi #

---
 examples/standalone/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
examples/standalone/Makefile +7 -1
index 5e2f2bc..c02ce43 100644
@@ -38,7 +38,13 @@ ELF-mpc8260                      += mem_to_mem_idma2intr
 ELF-ppc                          += sched
 ELF-oxc                          += eepro100_eeprom
 
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white spaces properly;
+# leading to build failures. The problem was found with GNU Make 3.80.
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
+
 SREC = $(addsuffix .srec,$(ELF))
 BIN  = $(addsuffix .bin,$(ELF))
 
Signature · 1 line
1.6.2.2
#1 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Hi Sanjeev,

<snip>

examples/standalone/Makefile ELF-mpc8260 += mem_to_mem_idma2intr · line 47

Quoted 9 lines
examples/standalone/Makefile +7 -1
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white spaces properly;
+# leading to build failures. The problem was found with GNU Make 3.80.
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
+

I haven't been following the thread, but am assuming the the capitalization of "ElF" above is a typo?

Best,
Peter

#2 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Quoted 19 lines

-----Original Message-----
From: Peter Tyser [mailto:ptyser at xes-inc.com]
Sent: Monday, November 09, 2009 10:58 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH v2] Fix build failure in examples/standalone

Hi Sanjeev,

<snip>

examples/standalone/Makefile ELF-mpc8260 += mem_to_mem_idma2intr

Quoted 4 lines
examples/standalone/Makefile +2 -1
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white 

spaces properly;

Quoted 1 line

+# leading to build failures. The problem was found with

GNU Make 3.80.

Quoted 8 lines

examples/standalone/Makefile ELF-mpc8260 += mem_to_mem_idma2intr

Quoted 3 lines
examples/standalone/Makefile +3 -0
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) 

$(ELF-$(CPU)))

Quoted 1 line

+

I haven't been following the thread, but am assuming the the capitalization of "ElF" above is a typo?

Sorry, Got back to regular activity much late than expected. Yes. This is a typo; will fix it.

Quoted 6 lines

Best,
Peter

#3 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Quoted 32 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Premi, Sanjeev
Sent: Thursday, December 03, 2009 5:15 PM
To: Peter Tyser
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH v2] Fix build failure in examples/standalone

Quoted 23 lines

-----Original Message-----
From: Peter Tyser [mailto:ptyser at xes-inc.com]
Sent: Monday, November 09, 2009 10:58 PM
To: Premi, Sanjeev
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH v2] Fix build failure in examples/standalone

Hi Sanjeev,

<snip>

examples/standalone/Makefile ELF-mpc8260 += mem_to_mem_idma2intr

Quoted 4 lines
examples/standalone/Makefile +2 -1
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white 

spaces properly;

Quoted 1 line

+# leading to build failures. The problem was found with

GNU Make 3.80.

examples/standalone/Makefile ELF-mpc8260 += mem_to_mem_idma2intr

Quoted 3 lines
examples/standalone/Makefile +3 -0
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) 

$(ELF-$(CPU)))

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

+

I haven't been following the thread, but am assuming the the capitalization of "ElF" above is a typo?

Sorry, Got back to regular activity much late than expected. Yes. This is a typo; will fix it.

Just noticed that patch has already been committed with the fix. Thanks Wolfgang.

Best regards,
Sanjeev

Quoted 11 lines
Quoted 6 lines

Best,
Peter

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#4 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

In reply to Sanjeev Premi
Quoted 73 lines

-----Original Message-----
From: Premi, Sanjeev
Sent: Monday, November 09, 2009 10:43 PM
To: u-boot at lists.denx.de
Cc: Premi, Sanjeev
Subject: [PATCH v2] Fix build failure in examples/standalone

Some versions of 'make' do not handle trailing white-spaces properly. Trailing spaces in ELF causes a 'fake' source to be added to the variable COBJS; leading to build failure (listed below). The problem was found with GNU Make 3.80.

Using text-function 'strip' as a workaround for the problem.

make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
arm-none-linux-gnueabi-gcc -g -Os -fno-common -ffixed-r8

(quoted diff) +0 -3
-msoft-float
-D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
-fno-builtin -ffreestanding -nostdinc -isystem 

/opt/codesourcery/2009q1- 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe
-DCONFIG_
ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork

(quoted diff) +0 -3
-march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -g  -Os   
-fno-common -ff

ixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x80e80000
-I/home/sanje
ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4. 3.3/includ
e -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-inte
rwork -march=armv5 -I.. -Bstatic -T u-boot.lds -Ttext 0x80e80000 -o .c
arm-none-linux-gnueabi-gcc: no input files
make[1]: *** [.c] Error 1
make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
make: *** [examples/standalone] Error 2
premi #

---
 examples/standalone/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
examples/standalone/Makefile +0 -0
index 5e2f2bc..c02ce43 100644
@@ -38,7 +38,13 @@ ELF-mpc8260                      += 

mem_to_mem_idma2intr
ELF-ppc += sched
ELF-oxc += eepro100_eeprom

examples/standalone/Makefile +3 -1
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white spaces properly;
+# leading to build failures. The problem was found with GNU 

Make 3.80.

examples/standalone/Makefile +4 -0
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
+
 SREC = $(addsuffix .srec,$(ELF))
 BIN  = $(addsuffix .bin,$(ELF))
Signature · 2 lines
-- 
1.6.2.2

Hi,

Just wanted to check if this update is okay?

Best regards,
Sanjeev

#5 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Quoted 72 lines
Quoted 66 lines

Some versions of 'make' do not handle trailing white-spaces properly. Trailing spaces in ELF causes a 'fake' source to be added to the variable COBJS; leading to build failure (listed below). The problem was found with GNU Make 3.80.

Using text-function 'strip' as a workaround for the problem.

make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
arm-none-linux-gnueabi-gcc -g -Os -fno-common -ffixed-r8

(quoted diff) +0 -3
-msoft-float
-D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
-fno-builtin -ffreestanding -nostdinc -isystem

/opt/codesourcery/2009q1- 203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe
-DCONFIG_
ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork

(quoted diff) +0 -3
-march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -g  -Os
-fno-common -ff

ixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x80e80000
-I/home/sanje
ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4. 3.3/includ
e -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-inte
rwork -march=armv5 -I.. -Bstatic -T u-boot.lds -Ttext 0x80e80000 -o .c
arm-none-linux-gnueabi-gcc: no input files
make[1]: *** [.c] Error 1
make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
make: *** [examples/standalone] Error 2
premi #

---
 examples/standalone/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)
examples/standalone/Makefile +0 -0
index 5e2f2bc..c02ce43 100644
@@ -38,7 +38,13 @@ ELF-mpc8260                      +=

mem_to_mem_idma2intr
ELF-ppc += sched
ELF-oxc += eepro100_eeprom

examples/standalone/Makefile +3 -1
-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))
+#
+# Some versions of make do not handle trailing white spaces properly;
+# leading to build failures. The problem was found with GNU

Make 3.80.

examples/standalone/Makefile +4 -1
+# Using 'strip' as a workaround for the problem.
+#
+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))
+
 SREC = $(addsuffix .srec,$(ELF))
 BIN  = $(addsuffix .bin,$(ELF))
 
--
Quoted 3 lines

1.6.2.2

Hi,

Quoted 4 lines

Just wanted to check if this update is okay?

Best regards,
Sanjeev

If this is OK with everybody I'd like to push this to u-boot-ti.

Sandeep

#6 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

Dear "Paulraj, Sandeep",

Quoted 2 lines · In message <[email protected]> you…
Quoted 2 lines
Quoted 2 lines

+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))

------^^^^

Quoted 1 line

If this is OK with everybody I'd like to push this to u-boot-ti.

The patch is NOT ok, there is a typo in it ("ElF" != "ELF").

I intend to pull this (fixed) into the master branch ASAP, so you don;t need to become active (actually you are not supposed to become active as this is in no way any TI specific code). Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is mind?  No matter.  What is matter?  Never mind.
                                      -- Thomas Hewitt Key, 1799-1875
#7 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

In reply to Premi
Quoted 4 lines · Sanjeev

From: Premi, Sanjeev

Quoted 1 line

+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))

Just wanted to check if this update is okay?

i'm guessing you missed peter's e-mail pointing out bugs in this change -mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091123/f0765530/attachment.pgp

#8 lore raw

PATCH v2 1/1 Fix build failure in examples/standalone

In reply to Sanjeev Premi

Dear Sanjeev Premi,

Quoted 25 lines · In message <[email protected]> you wrote:

Some versions of 'make' do not handle trailing white-spaces properly. Trailing spaces in ELF causes a 'fake' source to be added to the variable COBJS; leading to build failure (listed below). The problem was found with GNU Make 3.80.

Using text-function 'strip' as a workaround for the problem.

make[1]: Entering directory `/home/sanjeev/u-boot/examples/standalone'
arm-none-linux-gnueabi-gcc -g -Os -fno-common -ffixed-r8 -msoft-float

(quoted diff) +0 -2
-D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanjeev/u-boot/include
-fno-builtin -ffreestanding -nostdinc -isystem /opt/codesourcery/2009q1-

203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/include -pipe -DCONFIG_ ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-interwork -march=armv5
-Wall -Wstrict-prototypes -fno-stack-protector -g -Os -fno-common -ff
ixed-r8 -msoft-float -D__KERNEL__ -DTEXT_BASE=0x80e80000 -I/home/sanje
ev/u-boot/include -fno-builtin -ffreestanding -nostdinc -isystem /opt/co desourcery/2009q1-203/bin/../lib/gcc/arm-none-linux-gnueabi/4.3.3/includ e -pipe -DCONFIG_ARM -D__ARM__ -marm -mabi=aapcs-linux -mno-thumb-inte rwork -march=armv5 -I.. -Bstatic -T u-boot.lds -Ttext 0x80e80000 -o .c arm-none-linux-gnueabi-gcc: no input files
make[1]: *** [.c] Error 1
make[1]: Leaving directory `/home/sanjeev/u-boot/examples/standalone'
make: *** [examples/standalone] Error 2
premi #

Quoted 4 lines
---
 examples/standalone/Makefile |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

Applied...

Quoted 1 line

-ELF := $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU))

...

Quoted 1 line

+ElF := $(strip $(ELF-y) $(ELF-$(ARCH)) $(ELF-$(BOARD)) $(ELF-$(CPU)))

... after fixing the ELF => ElF typo. Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The only person who always got his work done by Friday
                                                 was Robinson Crusoe.