Skip to contentSkip to conversation

Input: i8042 - add Dell Vostro 1520 and 1720 to the reset list

PATCH In review Anisse Astier 2 participants 5 messages Nov 24, 2009 – Nov 30, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Input: i8042 - add Dell Vostro 1520 and 1720 to the reset list

These laptops may have i8042 in a bad state at very first boot or if you plug in a non-Dell power supply.
Thus this patch is needed for proper keyboard and touchpad function.

---
 drivers/input/serio/i8042-x86ia64io.h |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
drivers/input/serio/i8042-x86ia64io.h +14 -0
index a537925..7d1cebc 100644
@@ -447,6 +447,20 @@ static struct dmi_system_id __initdata i8042_dmi_reset_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "N10"),
 		},
 	},
+	{
+		.ident = "Dell Vostro 1520",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1520"),
+		},
+	},
+	{
+		.ident = "Dell Vostro 1720",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 1720"),
+		},
+	},
 	{ }
 };
 
Signature · 1 line
1.6.5.2
maintainer
#1 lore raw

Hi Anisse,

Quoted 4 lines · Anisse Astier

These laptops may have i8042 in a bad state at very first boot or if you plug in a non-Dell power supply.
Thus this patch is needed for proper keyboard and touchpad function.

Could youplease explain in more detail what the "bad state" is. And what exactly do you mean by "first boot"? Cold boot? The very first boot after assembling? Something else?

Thanks.

Signature · 1 line
Dmitry
#2 lore raw
In reply to Anisse Astier

Hi Dmitry,

Sorry for the badly threaded reply, I wasn't subscribed to the list and didn't ask explicitely to be Cc-ed.

Quoted 4 lines · Dmitry Torokhov

Could youplease explain in more detail what the "bad state" is. And what exactly do you mean by "first boot"? Cold boot? The very first boot after assembling? Something else?

By bad state I mean that neither touchpad nor keyboard are working. They are both unresponsive. You can fix this by adding i8042.reset on the kernel command line, or removing the battery and waiting long enough. By very first boot I mean when the laptops are received from Dell and booted in Linux.

If you cold boot with a working non-Dell power supply (with same electrical characteristics), you can reproduce the "first boot" bug as much as you want, and laptops won't work unless you remove the battery and wait long enough OR add i8042.reset on the cmdline.

Regards,

--
Anisse

maintainer
#3 lore raw
Quoted 16 lines · Anisse Astier

Hi Dmitry,

Sorry for the badly threaded reply, I wasn't subscribed to the list and didn't ask explicitely to be Cc-ed.

Quoted 4 lines · Dmitry Torokhov

Could youplease explain in more detail what the "bad state" is. And what exactly do you mean by "first boot"? Cold boot? The very first boot after assembling? Something else?

By bad state I mean that neither touchpad nor keyboard are working. They are both unresponsive. You can fix this by adding i8042.reset on the kernel command line, or removing the battery and waiting long enough. By very first boot I mean when the laptops are received from Dell and booted in Linux.

Quoted 5 lines

If you cold boot with a working non-Dell power supply (with same electrical characteristics), you can reproduce the "first boot" bug as much as you want, and laptops won't work unless you remove the battery and wait long enough OR add i8042.reset on the cmdline.

Ok, I see... what about 1320? I did a quick round of googling and it seem to have the similar issue...

Signature · 1 line
Dmitry
#4 lore raw
Quoted 4 lines · Dmitry Torokhov

Ok, I see... what about 1320? I did a quick round of googling and it seem to have the similar issue...

Unfortunately I don't have the hardware, so I can't tell for sure. But it does indeed look very alike the problem we experienced.

--
Anisse