Skip to contentSkip to conversation

WE: Fix set events not propagated

PATCH New Jean Tourrilhes 1 participant 1 message Nov 24, 2009 802.11 (including cfg80211/NL80211)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 WE: Fix set events not propagated

	Hi,

	I've just noticed that some events are no longer propagated

for some wireless drivers. Basically, SET request with a extra payload for driver without commit handler. The fix is pretty simple, see attached.
Actually, a few lines below this line, you will see that the
event generation for simple SET (iwpoint-less ?) is done properly, and this other event generation does not need fixing.
Regards,

Jean

net/wireless/wext.c renamed from net/wireless/wext.j1.c +2 -1
diff -u -p linux/net/wireless/wext.j1.c linux/net/wireless/wext.c
@@ -809,7 +809,8 @@ static int ioctl_standard_iw_point(struc
 	}
 
 	/* Generate an event to notify listeners of the change */
-	if ((descr->flags & IW_DESCR_FLAG_EVENT) && err == -EIWCOMMIT) {
+	if ((descr->flags & IW_DESCR_FLAG_EVENT) &&
+	    ((err == 0) || (err == -EIWCOMMIT))) {
 		union iwreq_data *data = (union iwreq_data *) iwp;
 
 		if (descr->flags & IW_DESCR_FLAG_RESTRICT)