usb: ehci: Allow EHCI to be built on OMAP3
Subsystems (4)
PATCH 2/2 usb: ehci: Allow EHCI to be built on OMAP3
usb: ehci: Allow EHCI to be built on OMAP3
OMAP3 chips have a built-in EHCI controller. The recently introduced omap ehci-hcd driver missed out on selecting USB_ARCH_HAS_EHCI in Kconfig.
Without this, the driver cannot be built.
---
I've based this on current Linus' tree plus your usb patch queue (gregkh-07-usb-2.6.32-rc6.patch).
drivers/usb/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/usb/Kconfig +1 -0
@@ -61,6 +61,7 @@ config USB_ARCH_HAS_EHCI default y if ARCH_W90X900 default y if ARCH_AT91SAM9G45 default y if ARCH_MXC + default y if ARCH_OMAP34XX default PCI # ARM SA1111 chips have a non-PCI based "OHCI-compatible" USB host interface.
OMAP34XX has EHCI, so select USB_ARCH_HAS_EHCI.
---
Quoted 7 lines · Anand Gadiyar
usb: ehci: Allow EHCI to be built on OMAP3
OMAP3 chips have a built-in EHCI controller. The recently introduced omap ehci-hcd driver missed out on selecting
USB_ARCH_HAS_EHCIinKconfig.Without this, the driver cannot be built.
This is a losing battle. It scales much better to select the option from OMAP34XX, instead of starting to enumerate the various platforms in drivers/usb.
arch/arm/mach-omap2/Kconfig +1 -0
@@ -18,6 +18,7 @@ config ARCH_OMAP2430 config ARCH_OMAP34XX bool "OMAP34xx Based System" depends on ARCH_OMAP3 + select USB_ARCH_HAS_EHCI config ARCH_OMAP3430 bool "OMAP3430 support"
A message that is not in the archive (sent off-list or not yet received): [email protected]
Gadiyar, Anand
Acked-byQuoted 4 lines · Olof Johansson
OMAP34XX has EHCI, so select
USB_ARCH_HAS_EHCI.Signed-off-by Olof Johansson <[email protected]>
Quoted 10 lines
---
Quoted 6 lines · Anand Gadiyar
usb: ehci: Allow EHCI to be built on OMAP3
OMAP3 chips have a built-in EHCI controller. The recently introduced omap ehci-hcd driver missed out on selecting
USB_ARCH_HAS_EHCIinKconfig.
Quoted 6 lines
Quoted 1 line
Without this, the driver cannot be built.
This is a losing battle. It scales much better to select the option from OMAP34XX, instead of starting to enumerate the various platforms in
drivers/usb.
Yes, I agree. Okay with me to drop my patch and use this one instead.
- Anand
Quoted 6 lines
arch/arm/mach-omap2/Kconfig +0
-0
arch/arm/mach-omap2/Kconfig config ARCH_OMAP2430
Quoted 8 lines
arch/arm/mach-omap2/Kconfig +1
-1@@ -18,6 +18,7 @@ config ARCH_OMAP2430 config ARCH_OMAP34XX bool "OMAP34xx Based System" depends on ARCH_OMAP3 + select USB_ARCH_HAS_EHCI config ARCH_OMAP3430 bool "OMAP3430 support" --
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Tony Lindgren
maintainerPATCH 2/2 usb: ehci: Allow EHCI to be built on OMAP3
In reply to Olof JohanssonThis patch has been applied to the linux-omap
by youw fwiendly patch wobot.
Branch in linux-omap: for-next-vol2
Initial commit ID (Likely to change): caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266
PatchWorks
http://patchwork.kernel.org/patch/62727/
Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266
Quoted 5 lines · Tony Lindgren
This patch has been applied to the linux-omap
by youw fwiendly patch wobot.Branch in linux-omap: for-next-vol2
Quoted 9 lines
Initial commit ID (Likely to change):
caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266PatchWorks
http://patchwork.kernel.org/patch/62727/Git (Likely to change, and takes a while to get mirrored)
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commit;h=caeaa2f4d7e3c8a2576bff1ca1b58e104e8f0266
Thanks Tony,
It seemed these patches were somehow lost upstream. Regards
Sid.
Signature · 4 lines
Sid Boyce ... Hamradio License G3VBV, Licensed Private Pilot Emeritus IBM/Amdahl Mainframes and Sun/Fujitsu Servers Tech Support Specialist, Cricket Coach Microsoft Windows Free Zone - Linux used for all Computing Tasks