Skip to contentSkip to conversation

airo: Fix integer overflow warning

PATCH New Michael Buesch 1 participant 1 message Nov 25, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 airo: Fix integer overflow warning

On BigEndian gcc complains:

drivers/net/wireless/airo.c: In function ‘sniffing_mode’:
drivers/net/wireless/airo.c:4809: warning: integer overflow in expression

Fix this by doing the bitwise AND on the host-endian value.

---

I don't know why GCC warns, however. The original code looks OK to me, too.

drivers/net/wireless/airo.c +1 -1
Index: wireless-testing/drivers/net/wireless/airo.c
===================================================================
@@ -4806,7 +4806,7 @@ static int airo_config_commit(struct net
 
 static inline int sniffing_mode(struct airo_info *ai)
 {
-	return le16_to_cpu(ai->config.rmode & RXMODE_MASK) >=
+	return (le16_to_cpu(ai->config.rmode) & le16_to_cpu(RXMODE_MASK)) >=
 		le16_to_cpu(RXMODE_RFMON);
 }
 
Signature · 1 line
Greetings, Michael.