Skip to contentSkip to conversation

crypto: Fix ghash pclmulqdqni algorithm without test

PATCH In review Youquan,Song 2 participants 2 messages Nov 25, 2009 – Nov 26, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: Fix ghash pclmulqdqni algorithm without test

when load ghash-clmulni-intel driver,kernel will report no test for some algorithm with PCLMULQDQ NI. The strange information as following:

alg: No test for __ghash (__ghash-pclmulqdqni)
alg: No test for __ghash (cryptd(__ghash-pclmulqdqni))

crypto_alg's cra_name is use to descript algorithm itself, do not care the concrete implement. So this patch unify them and also can fix the algorithm implementation without test.

---

arch/x86/crypto/ghash-clmulni-intel_glue.c +1 -1
index cbcc8d8..3fab6cb 100644
@@ -141,7 +141,7 @@ static struct shash_alg ghash_alg = {
 	.setkey		= ghash_setkey,
 	.descsize	= sizeof(struct ghash_desc_ctx),
 	.base		= {
-		.cra_name		= "__ghash",
+		.cra_name		= "ghash",
 		.cra_driver_name	= "__ghash-pclmulqdqni",
 		.cra_priority		= 0,
 		.cra_flags		= CRYPTO_ALG_TYPE_SHASH,
maintainer
#1 lore raw
Quoted 11 lines · Youquan,Song

when load ghash-clmulni-intel driver,kernel will report no test for some algorithm with PCLMULQDQ NI. The strange information as following:

alg: No test for __ghash (__ghash-pclmulqdqni)
alg: No test for __ghash (cryptd(__ghash-pclmulqdqni))

crypto_alg's cra_name is use to descript algorithm itself, do not care the concrete implement. So this patch unify them and also can fix the algorithm implementation without test.

Please talk to Huang Ying who wrote these patches. Thanks!

Signature · 4 lines
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt