Skip to contentSkip to conversation

libata: add comment documenting PIO latency issues on UP

PATCH Applied Bartlomiej Zolnierkiewicz 2 participants 2 messages Nov 26, 2009 – Dec 3, 2009 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libata: add comment documenting PIO latency issues on UP

Based on:
http://lkml.indiana.edu/hypermail/linux/kernel/0908.2/01420.html

---
 drivers/ata/libata-core.c |    7 +++++++
 1 file changed, 7 insertions(+)
drivers/ata/libata-core.c +7 -0
Index: b/drivers/ata/libata-core.c
===================================================================
@@ -6624,6 +6624,13 @@ static int __init ata_init(void)
 {
 	ata_parse_force_param();
 
+	/*
+	 * FIXME: In UP case, there is only one workqueue thread and if you
+	 * have more than one PIO device, latency is bloody awful, with
+	 * occasional multi-second "hiccups" as one PIO device waits for
+	 * another.  It's an ugly wart that users DO occasionally complain
+	 * about; luckily most users have at most one PIO polled device.
+	 */
 	ata_wq = create_workqueue("ata");
 	if (!ata_wq)
 		goto free_force_tbl;