mm: uncached vma support with writenotify
Subsystems (2)
PATCH RESEND 1/1 mm: uncached vma support with writenotify
From: Magnus Damm <[email protected]>
This patch modifies the generic mmap() code to keep the cache attribute in vma->vm_page_prot regardless if writenotify is enabled or not. Without this patch the cache configuration selected by f_op->mmap() is overwritten if writenotify is enabled, making it impossible to keep the vma uncached.
Needed by drivers such as drivers/video/sh_mobile_lcdcfb.c which uses deferred io together with uncached memory.
---
Identical to the patch sent 20090614.
It's been a while since then, is it now safe to use pgprot_noncached() without #ifdefs?
mm/mmap.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
mm/mmap.c +13 -1
@@ -1220,8 +1220,20 @@ munmap_back: goto free_vma; } -if (vma_wants_writenotify (vma)) +if (vma_wants_writenotify (vma)) { +pgprot_t pprot = vma->vm_page_prot; + +/* Can vma->vm_page_prot have changed?? +* +* Answer: Yes, drivers may have changed it in their +* f_op->mmap method. +* +* Ensures that vmas marked as uncached stay that way. +*/ vma->vm_page_prot =vm_get_page_prot (vm_flags & ~VM_SHARED ); +if (pgprot_val (pprot) ==pgprot_val (pgprot_noncached (pprot))) + vma->vm_page_prot =pgprot_noncached (vma->vm_page_prot); + }vma_link (mm, vma, prev, rb_link, rb_parent); file = vma->vm_file;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>