Skip to contentSkip to conversation

Sound support for Neuros OSD2 Davinci based board.

PATCH A. Porodko 4 participants 9 messages Nov 26, 2009 – Nov 30, 2009

Subsystems (2)
lore
Share & tools
lore

A. Porodko

author
#0 lore raw

Hello,

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.
------------------------------------------

Signature · 2 lines
Best regards
Andrey A. Porodko
Quoted 1 line

From 72b5b0efa71d0ca0bbe3a0c3ab577ee365385a28 Mon Sep 17 00:00:00 2001

From: Andrey Porodko <[email protected]>
Date: Mon, 23 Nov 2009 13:56:53 +0500
Subject: [PATCH] Davinci sound soc driver patch for Neuros OSD2 board support.

---
 sound/soc/davinci/davinci-evm.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
sound/soc/davinci/davinci-evm.c +6 -0
index 67414f6..ffdd30e 100644
@@ -55,6 +55,9 @@ static int evm_hw_params(struct snd_pcm_substream *substream,
 	else if (machine_is_davinci_evm())
 		sysclk = 12288000;
 
+	else if (machine_is_neuros_osd2())
+		sysclk = 27000000;
+
 	else if (machine_is_davinci_da830_evm() ||
 				machine_is_davinci_da850_evm())
 		sysclk = 24576000;
@@ -246,6 +249,9 @@ static int __init evm_init(void)
 	if (machine_is_davinci_evm()) {
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 0;
+	} else if (machine_is_neuros_osd2()) {
+		evm_snd_dev_data = &evm_snd_devdata;
+		index = 0;
 	} else if (machine_is_davinci_dm355_evm()) {
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 1;
Signature · 1 line
1.5.6.5
#1 lore raw

Hello,

Quoted 12 lines · A. Porodko

Hello,

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.
------------------------------------------

--
Best regards
Andrey A. Porodko

@@ -246,6 +249,9 @@ static int __init evm_init(void)
if (machine_is_davinci_evm()) {
evm_snd_dev_data = &evm_snd_devdata; index = 0;
+ } else if (machine_is_neuros_osd2()) {
+ evm_snd_dev_data = &evm_snd_devdata;
+ index = 0;

The above can be combined with the check for DaVinci EVM

	if (machine_is_davinci_evm() ||
				(machine_is_neuros_osd2()) {

evm_snd_dev_data = &evm_snd_devdata; index = 0;

Regards,
Chaithrika

#2 lore raw

sound/soc/davinci/davinci-evm.c static int __init evm_init(void) · line 251

Quoted 13 lines · Chaithrika U S
sound/soc/davinci/davinci-evm.c +3 -0
@@ -246,6 +249,9 @@ static int __init evm_init(void)
 	if (machine_is_davinci_evm()) {
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 0;
+	} else if (machine_is_neuros_osd2()) {
+		evm_snd_dev_data = &evm_snd_devdata;
+		index = 0;
 

The above can be combined with the check for DaVinci EVM

	if (machine_is_davinci_evm() ||
				(machine_is_neuros_osd2()) {
sound/soc/davinci/davinci-evm.c +0 -0
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 0;

I raised the same query when Andrey sent an off-list copy to me by mistake - he said that in future he intends to extend the driver to have additional features not present on the EVM (though for me that could always change the || later).

Andrey, with Linux kernel patches reply to all is generally the way forward.

author
#3 lore raw
Quoted 20 lines · Mark Brown
Quoted 14 lines · Chaithrika U S
sound/soc/davinci/davinci-evm.c +3 -0
@@ -246,6 +249,9 @@ static int __init evm_init(void)
 	if (machine_is_davinci_evm()) {
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 0;
+	} else if (machine_is_neuros_osd2()) {
+		evm_snd_dev_data = &evm_snd_devdata;
+		index = 0;
 
 
 

The above can be combined with the check for DaVinci EVM

	if (machine_is_davinci_evm() ||
				(machine_is_neuros_osd2()) {

sound/soc/davinci/davinci-evm.c static int __init evm_init(void) · line 251

Quoted 2 lines
sound/soc/davinci/davinci-evm.c +0 -0
 		evm_snd_dev_data = &evm_snd_devdata;
 		index = 0;
Quoted 8 lines

I raised the same query when Andrey sent an off-list copy to me by mistake - he said that in future he intends to extend the driver to have additional features not present on the EVM (though for me that could always change the || later).

Andrey, with Linux kernel patches reply to all is generally the way forward.

Mark,

Understood. Shall I change if if to if || then?

Signature · 2 lines
Best regards
Andrey A. Porodko
#4 lore raw
Quoted 8 lines · A. Porodko
Quoted 4 lines · Mark Brown

I raised the same query when Andrey sent an off-list copy to me by mistake - he said that in future he intends to extend the driver to have additional features not present on the EVM (though for me that could always change the || later).

Understood. Shall I change if if to if || then?

Honestly I'm not that bothered, I was mostly following up to the list so that readers and the archives could see the answer to the query (I guessed you may have mistakenly replied off list).

#5 lore raw
In reply to A. Porodko
Quoted 4 lines · A. Porodko

Hello,

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.

This doesn't apply against current ASoC. Could you please regenerate against this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33

#6 lore raw
Quoted 14 lines · Mark Brown
Quoted 5 lines · A. Porodko

Hello,

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.

This doesn't apply against current ASoC. Could you please regenerate against this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33

Quoted 4 lines · Mark Brown
Quoted 2 lines · A. Porodko

Hello,

Quoted 10 lines
Quoted 3 lines

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.

This doesn't apply against current ASoC. Could you please regenerate against this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33

Hi,

I wish I knew how to do this. I'm new with git and anly learn how to work with one tree.
Complex operations confuse me a little. I generated something, but it doesn't look different from what I had before.

P.S. Reading alsa-project wiki didn't shed more light. For my main tree is davinci tree and git is damn tricky.
---------------------------

Quoted 1 line

From 699bbf676a3e74989063b398ff662fcf40469a16 Mon Sep 17 00:00:00 2001

From: Andrey Porodko <[email protected]>
Date: Mon, 23 Nov 2009 13:56:53 +0500
Subject: [PATCH] Davinci sound soc driver patch for Neuros OSD2 board support.

---
 sound/soc/davinci/davinci-evm.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
(quoted diff) +0 -0

b/sound/soc/davinci/davinci-evm.c
index 67414f6..ffdd30e 100644

sound/soc/davinci/davinci-evm.c +0 -0
@@ -55,6 +55,9 @@ static int evm_hw_params(struct snd_pcm_substream

*substream,
else if (machine_is_davinci_evm())
sysclk = 12288000;

+ else if (machine_is_neuros_osd2())
+ sysclk = 27000000;
+

     else if (machine_is_davinci_da830_evm() ||
                 machine_is_davinci_da850_evm())
         sysclk = 24576000;
@@ -246,6 +249,9 @@ static int __init evm_init(void)
     if (machine_is_davinci_evm()) {
         evm_snd_dev_data = &evm_snd_devdata;
         index = 0;
+    } else if (machine_is_neuros_osd2()) {
+        evm_snd_dev_data = &evm_snd_devdata;
+        index = 0;
     } else if (machine_is_davinci_dm355_evm()) {
         evm_snd_dev_data = &evm_snd_devdata;
         index = 1;
Signature · 13 lines
1.5.6.5
-----------------------------------------

-- 
Best regards
Andrey A. Porodko
 



-- 
Best regards
Andrey A. Porodko
#7 lore raw
In reply to Mark Brown
Quoted 4 lines · Mark Brown
Quoted 2 lines · A. Porodko

Hello,

Quoted 10 lines
Quoted 3 lines

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.

This doesn't apply against current ASoC. Could you please regenerate against this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33

Hi Mark,

Are you sure you have the latest davinci soc support in your tree? Mine file davinci_evm.c is 7.5k size, in your

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git

repo your is 5.5k. Quick glance shows that in your repo davinci support lacks of da830_evm support.
I'm confused which one is I have to use and apply patch to?

Signature · 2 lines
Best regards
Andrey A. Porodko
#8 lore raw

Andrey A. Porodko wrote:

Please, disregard my previous message. It's me stupid enough to forget to switch to the right branch.
Sorry.

Quoted 30 lines
Quoted 5 lines · Mark Brown
Quoted 2 lines · A. Porodko

Hello,

Quoted 11 lines
Quoted 4 lines

Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. Patch made against 2.6.32-rc6 kernel.

This doesn't apply against current ASoC. Could you please regenerate against this branch:

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33

Hi Mark,

Are you sure you have the latest davinci soc support in your tree? Mine file davinci_evm.c is 7.5k size, in your

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git

repo your is 5.5k. Quick glance shows that in your repo davinci support lacks of da830_evm support.
I'm confused which one is I have to use and apply patch to?

Signature · 2 lines
Best regards
Andrey A. Porodko