Skip to contentSkip to conversation

CLD: fix crash in __mutex_get_max (libdb-4.7.so) on F13

PATCH Applied Pete Zaitcev 2 participants 6 messages Nov 30, 2009 – Dec 2, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CLD: fix crash in __mutex_get_max (libdb-4.7.so) on F13

Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust. Let us link with 4.8 as a workaround.

---
 configure.ac |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Not sure how safe or desirable this is, but it seems to work.

commit 77e89dfc8f0a9296ebfb02d5ca34d48f083df50c

Author: Master <[email protected]>
Date:   Sun Nov 29 18:12:40 2009 -0700

Fix crash in __mutex_get_max because db4.7 is toast on F13 by letting to link against db4.8.

configure.ac +3 -2
index b1247b6..aec971f 100644
@@ -73,11 +73,12 @@ dnl AC_TYPE_PID_T
 dnl -----------------------------
 dnl Checks for required libraries
 dnl -----------------------------
-AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
+AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
+	AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
 	AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6,
 	AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5,
 	AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4,
-	AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3, exit 1)))))
+	AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3, exit 1))))))
 AC_CHECK_LIB(argp, argp_parse, ARGP_LIBS=-largp)
 AC_CHECK_LIB(crypto, MD5_Init, CRYPTO_LIBS=-lcrypto)
 AC_CHECK_LIB(resolv, ns_initparse, RESOLV_LIBS=-lresolv)
#1 lore raw
Quoted 9 lines · Pete Zaitcev

Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust. Let us link with 4.8 as a workaround.

---
  configure.ac |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 8 lines

Not sure how safe or desirable this is, but it seems to work.

commit 77e89dfc8f0a9296ebfb02d5ca34d48f083df50c

Author: Master<[email protected]>
Date:   Sun Nov 29 18:12:40 2009 -0700

Fix crash in __mutex_get_max because db4.7 is toast on F13 by letting to link against db4.8.

Interesting... I recall the root cause clearly, now: /usr/include/db.h always refers to the latest installed db4, even if compat-db{,45,46} is installed. Our configure recipe links with the most recent db4 listed in configure.ac, combined with the installed /usr/include/db.h. Thus, each new db4 version produces a mismatch.

If we could include /usr/include/db4.6.21/db.h when db-4.6 is present, that would be ideal. But given that db4 lacks anything approaching pkgconfig, autodetection becomes quite difficult.

While I would like to see configure.ac have a better test (surely Google can find an autoconf recipe for db4?), I think your proposed patch will be the best method we can find.

Jeff

#2 lore raw
Quoted 10 lines · Jeff Garzik
Quoted 2 lines · Pete Zaitcev

Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust. Let us link with 4.8 as a workaround.

Interesting... I recall the root cause clearly, now: /usr/include/db.h always refers to the latest installed db4, even if compat-db{,45,46} is installed. Our configure recipe links with the most recent db4 listed in configure.ac, combined with the installed /usr/include/db.h. Thus, each new db4 version produces a mismatch.

Aww, I didn't realize how it worked. Could you add this to the commit message, in case?

-- Pete

#3 lore raw
In reply to Jeff Garzik
Quoted 5 lines · On Sun, 29 Nov 2009 20:38:45 -0500 Jeff Garzik <[email protected]> wrote:

Interesting... I recall the root cause clearly, now: /usr/include/db.h always refers to the latest installed db4, even if compat-db{,45,46} is installed. Our configure recipe links with the most recent db4 listed in configure.ac, combined with the installed /usr/include/db.h. Thus, each new db4 version produces a mismatch.

I solicited suggestions on a blog, and someone asked why we don't use db without specific version. I assumed we do it so we don't get linked with something ancient like db3. Is that so? If yes, how about something like this:

configure.ac +5 -7
@@ -76,13 +76,11 @@ dnl -----------------------------
 AC_CHECK_LIB(pcre, pcre_compile, PCRE_LIBS=-lpcre)
 AC_CHECK_LIB(crypto, MD5_Init, CRYPTO_LIBS=-lcrypto)
 AC_CHECK_LIB(ssl, SSL_new, SSL_LIBS=-lssl)
-AC_CHECK_LIB(db-4.8, db_create, DB4_LIBS=-ldb-4.8,
-       AC_CHECK_LIB(db-4.7, db_create, DB4_LIBS=-ldb-4.7,
-       AC_CHECK_LIB(db-4.6, db_create, DB4_LIBS=-ldb-4.6,
-       AC_CHECK_LIB(db-4.5, db_create, DB4_LIBS=-ldb-4.5,
-       AC_CHECK_LIB(db-4.4, db_create, DB4_LIBS=-ldb-4.4,
-       AC_CHECK_LIB(db-4.3, db_create, DB4_LIBS=-ldb-4.3,
-  [AC_MSG_ERROR([Missing required libdb 4.x])]))))))
+
+AC_CHECK_HEADERS([db.h], [], [AC_MSG_ERROR(Missing required db.h)])
+dnl We do not use sequence objects. It is a trick to force db4.3 or later.
+AC_CHECK_LIB(db, db_sequence_create, DB4_LIBS=-ldb)
+
 AC_CHECK_LIB(event, event_base_new, EVENT_LIBS=-levent,
   [AC_MSG_ERROR([Missing required libevent])])
 AC_CHECK_LIB(argp, argp_parse, ARGP_LIBS=-largp)

(URL http://zaitcev.livejournal.com/195586.html)

-- Pete

#4 lore raw
Quoted 9 lines · Pete Zaitcev
Quoted 5 lines · On Sun, 29 Nov 2009 20:38:45 -0500 Jeff Garzik<[email protected]> wrote:

Interesting... I recall the root cause clearly, now: /usr/include/db.h always refers to the latest installed db4, even if compat-db{,45,46} is installed. Our configure recipe links with the most recent db4 listed in configure.ac, combined with the installed /usr/include/db.h. Thus, each new db4 version produces a mismatch.

Quoted 4 lines

I solicited suggestions on a blog, and someone asked why we don't use db without specific version. I assumed we do it so we don't get linked with something ancient like db3. Is that so? If yes, how about something like this:

libdb does not exist anywhere but more recent versions of Linux. That link does not exist on older, non-RHL Linux's, nor on FreeBSD, nor on Solaris. The proposed configure change would actually make us much -less- portable, unfortunately.

The ideal is somewhat close to what a LJ poster proposed:
* include from $include_dir/$db_version
* link from libdb-$db_version
* provide pkgconfig info that gives us precise location information

That's how, eg. glib/gtk+ 1.x can co-exist with glib/gtk+ 2.x.

But we lack a time machine to make this happen :/

Jeff

Applied
#5 lore raw
In reply to Pete Zaitcev
Quoted 9 lines · Pete Zaitcev

Fedora 13 comes with db4.8 and apparently the compat-db4.7 is bust. Let us link with 4.8 as a workaround.

---
  configure.ac |    5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
Quoted 8 lines

Not sure how safe or desirable this is, but it seems to work.

commit 77e89dfc8f0a9296ebfb02d5ca34d48f083df50c

Author: Master<[email protected]>
Date:   Sun Nov 29 18:12:40 2009 -0700

Fix crash in __mutex_get_max because db4.7 is toast on F13 by letting to link against db4.8.

applied, with updated commit message.