matroxfb: Fix problems with display stability
PATCH 1/1 matroxfb: Fix problems with display stability
Regression caused in 2.6.23 and then despite repeated requests never fixed or dealt with (Petr promised to sort it in 2008 but seems to have forgotten).
Enough is enough - remove the problem line that was added. If it upsets someone they've had two years to deal with it and at the very least it'll rattle their cage and wake them up.
Closes-bug: http://bugzilla.kernel.org/show_bug.cgi?id=9709
---
drivers/video/matrox/g450_pll.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/video/matrox/g450_pll.c +2 -1
@@ -368,7 +368,8 @@ static int __g450_setclk(struct matrox_fb_info *minfo, unsigned int fout,M1064_XDVICLKCTRL_C1DVICLKEN |M1064_XDVICLKCTRL_DVILOOPCTL |M1064_XDVICLKCTRL_P1LOOPBWDTCTL ; -matroxfb_DAC_out (minfo,M1064_XDVICLKCTRL , tmp); +/* Setting this breaks PC systems so don't do it */ +/* matroxfb_DAC_out(minfo, M1064_XDVICLKCTRL, tmp); */ matroxfb_DAC_out (minfo,M1064_XPWRCTRL , xpwrctrl);
Hi Alan,
Quoted 11 lines · Alan Cox
Regression caused in 2.6.23 and then despite repeated requests never fixed or dealt with (Petr promised to sort it in 2008 but seems to have forgotten).
Enough is enough - remove the problem line that was added. If it upsets someone they've had two years to deal with it and at the very least it'll rattle their cage and wake them up.
Closes-bug: http://bugzilla.kernel.org/show_bug.cgi?id=9709
Signed-off-by Alan Cox <[email protected]>Cc <[email protected]>
We might as well ask for a Tested-by tag from Ruud (whom I've added to CC) while we're at it.
Quoted 27 lines
---
drivers/video/matrox/g450_pll.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)drivers/video/matrox/g450_pll.c +0
-0@@ -368,7 +368,8 @@ static int __g450_setclk(struct matrox_fb_info *minfo, unsigned int fout,M1064_XDVICLKCTRL_C1DVICLKEN |
M1064_XDVICLKCTRL_DVILOOPCTL|M1064_XDVICLKCTRL_P1LOOPBWDTCTL;
-matroxfb_DAC_out(minfo, M1064_XDVICLKCTRL, tmp);
+ /* Setting this breaks PC systems so don't do it */
+ /*matroxfb_DAC_out(minfo, M1064_XDVICLKCTRL, tmp); */matroxfb_DAC_out(minfo, M1064_XPWRCTRL, xpwrctrl);--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/