Skip to contentSkip to conversation

mwl8k: don't forget to call pci_disable_device()

PATCH New Lennert Buytenhek 1 participant 1 message Nov 30, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 9/12 mwl8k: don't forget to call pci_disable_device()

Don't forget to call pci_disable_device() if pci_request_regions() fails during probe.

---
 drivers/net/wireless/mwl8k.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
drivers/net/wireless/mwl8k.c +3 -1
index b3eba35..5e67ae9 100644
@@ -3378,7 +3378,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
 	if (rc) {
 		printk(KERN_ERR "%s: Cannot obtain PCI resources\n",
 		       MWL8K_NAME);
-		return rc;
+		goto err_disable_device;
 	}
 
 	pci_set_master(pdev);
@@ -3609,6 +3609,8 @@ err_iounmap:
 
 err_free_reg:
 	pci_release_regions(pdev);
+
+err_disable_device:
 	pci_disable_device(pdev);
 
 	return rc;
Signature · 1 line
1.5.6.4