Skip to contentSkip to conversation

ieee802154: merge cleanup

PATCH Applied Eric Dumazet 2 participants 4 messages Dec 1, 2009 – Dec 2, 2009 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 ieee802154: merge cleanup

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

---
 drivers/ieee802154/fakehard.c |    3 ---
 1 files changed, 3 deletions(-)
drivers/ieee802154/fakehard.c +0 -3
index 5f67540..d9d0e13 100644
@@ -282,9 +282,6 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
                                              struct net_device *dev)
 {
-       skb->skb_iif = dev->ifindex;
-       skb->dev = dev;
-
        dev->stats.tx_packets++;
        dev->stats.tx_bytes += skb->len;
 
maintainer
#2 lore raw

From: Eric Dumazet <[email protected]>
Date: Tue, 01 Dec 2009 04:59:20 +0100

Quoted 5 lines

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

-ECORRUPTEDPATCH

Are you really sure you want to keep using Thunderbird for your email? :-)

#3 lore raw
Quoted 5 lines · David Miller

From: Eric Dumazet <[email protected]>
Date: Tue, 01 Dec 2009 04:59:20 +0100

Quoted 2 lines

A small cleanup after last net-2.6 merge into net-next-2.6

Quoted 8 lines
Quoted 3 lines

As we are going to free skb, no need to set skb->skb_iif or skb->dev

-ECORRUPTEDPATCH

Are you really sure you want to keep using Thunderbird for your email? :-)

Sorry, my bad, sending patches at 4h30 am is error prone, I did a stupid copy/paste from a wrong window.

[PATCH net-next-2.6] ieee802154: merge cleanup

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

---
 drivers/ieee802154/fakehard.c |    3 ---
 1 files changed, 3 deletions(-)
drivers/ieee802154/fakehard.c +0 -3
index 5f67540..d9d0e13 100644
@@ -282,9 +282,6 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
 					      struct net_device *dev)
 {
-	skb->skb_iif = dev->ifindex;
-	skb->dev = dev;
-
 	dev->stats.tx_packets++;
 	dev->stats.tx_bytes += skb->len;
 
maintainer Applied
#4 lore raw

From: Eric Dumazet <[email protected]>
Date: Tue, 01 Dec 2009 07:05:22 +0100

Quoted 7 lines

[PATCH net-next-2.6] ieee802154: merge cleanup

A small cleanup after last net-2.6 merge into net-next-2.6

As we are going to free skb, no need to set skb->skb_iif or skb->dev

Applied, thanks.