Skip to contentSkip to conversation

#define and use INTERNAL_ERROR

PATCH New Petr Rockai 2 participants 2 messages Dec 1, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 #define and use INTERNAL_ERROR

Hi,

patch attached to #define an INTERNAL_ERROR macro and use it throughout LVM. There's a couple of internal errors in libdm as well, and it seems that the log_error used by libdm actually comes from lib/ (i.e. LVM) so it may make sense to convert those as well.

Yours,
Petr.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: internal-err-define.diff
Type: text/x-diff
Size: 14524 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20091201/ccccc6fb/attachment.bin>

#1 lore raw

PATCH 1/1 #define and use INTERNAL_ERROR

Quoted 4 lines · Peter Rockai

patch attached to #define an INTERNAL_ERROR macro and use it throughout LVM. There's a couple of internal errors in libdm as well, and it seems that the log_error used by libdm actually comes from lib/ (i.e. LVM) so it may make sense to convert those as well.

Ack.

Each source file includes (normally via another header) either dm-logging.h or lvm-logging.h which deals with routing the messages to the right logging function and with the right set of parameters. log.h contains the part they have in common.

Alasdair