Skip to contentSkip to conversation

sysfs: fix SYSFS_DEPRECATED_V2 prompt

PATCH In review Randy Dunlap 2 participants 5 messages Nov 23, 2009 – Dec 3, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sysfs: fix SYSFS_DEPRECATED_V2 prompt

From: Randy Dunlap <[email protected]>

The SYSFS_DEPRECATED_V2 says "remove" older, deprecated features, but it actually enables them, so correct this confusing, backwards text.

---
 init/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
init/Kconfig +1 -1
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
 	bool
 
 config SYSFS_DEPRECATED_V2
-	bool "remove sysfs features which may confuse old userspace tools"
+	bool "enable deprecated sysfs features which may confuse old userspace tools"
 	depends on SYSFS
 	default n
 	select SYSFS_DEPRECATED
#1 lore raw

Hello,

init/Kconfig config SYSFS_DEPRECATED · line 609

Quoted 3 lines

config SYSFS_DEPRECATED_V2

init/Kconfig +1 -1
-	bool "remove sysfs features which may confuse old userspace tools"
+	bool "enable deprecated sysfs features which may confuse old userspace tools"

Is this better? SYSFS_DEPRECATED_V2 enables deprecated sysfs features, but this is done to *not* confuse old userspace tools, isn't it?

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
#2 lore raw
Quoted 7 lines · On Thu, 3 Dec 2009 09:03:41 +0100 Uwe Kleine-König wrote:

Hello,

init/Kconfig config SYSFS_DEPRECATED · line 609

Quoted 3 lines

config SYSFS_DEPRECATED_V2

init/Kconfig +1 -1
-	bool "remove sysfs features which may confuse old userspace tools"
+	bool "enable deprecated sysfs features which may confuse old userspace tools"

Is this better? SYSFS_DEPRECATED_V2 enables deprecated sysfs features, but this is done to *not* confuse old userspace tools, isn't it?

Hm, agreed that it is still a bit ambiguous.
Feel free to send (another) patch.

thanks,
---
~Randy

#3 lore raw

PATCH 1/1 sysfs: deprecated features are to help old tools not to confuse them

Cc Greg KH <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Kay Sievers <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Linus Torvalds <[email protected]>
---
 init/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
init/Kconfig +1 -1
index eb4b337..d7ac66b 100644
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
 	bool
 
 config SYSFS_DEPRECATED_V2
-	bool "enable deprecated sysfs features which may confuse old userspace tools"
+	bool "enable deprecated sysfs features to support old userspace tools"
 	depends on SYSFS
 	default n
 	select SYSFS_DEPRECATED
Signature · 1 line
1.6.5.2
author Acked-by on v1 1/1
#4 lore raw

Re: [PATCH] sysfs: deprecated features are to help old tools not to confuse them

Quoted 6 lines · On Thu, 3 Dec 2009 19:58:00 +0100 Uwe Kleine-König wrote:
Cc Greg KH <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Kay Sievers <[email protected]>
Cc Randy Dunlap <[email protected]>
Cc Linus Torvalds <[email protected]>

Thanks.

Quoted 10 lines
---
 init/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
init/Kconfig +0 -0
index eb4b337..d7ac66b 100644

init/Kconfig config SYSFS_DEPRECATED · line 612

Quoted 8 lines
init/Kconfig +1 -1
@@ -606,7 +606,7 @@ config SYSFS_DEPRECATED
 	bool
 
 config SYSFS_DEPRECATED_V2
-	bool "enable deprecated sysfs features which may confuse old userspace tools"
+	bool "enable deprecated sysfs features to support old userspace tools"
 	depends on SYSFS
 	default n
 	select SYSFS_DEPRECATED

---
~Randy