Skip to contentSkip to conversation

Removes dead code in the file common/cmd_i2c.c

PATCH New Pratap Chandu 3 participants 5 messages Nov 12, 2009 – Dec 5, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Removes dead code in the file common/cmd_i2c.c

There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.

---
 common/cmd_i2c.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)
common/cmd_i2c.c +0 -8
index 8f0fc9e..8d6feda 100644
@@ -326,14 +326,6 @@ int do_i2c_mw ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[])
 #if !defined(CONFIG_SYS_I2C_FRAM)
 		udelay(11000);
 #endif
-
-#if 0
-		for (timeout = 0; timeout < 10; timeout++) {
-			udelay(2000);
-			if (i2c_probe(chip) == 0)
-				break;
-		}
-#endif
 	}
 
 	return (0);
Signature · 1 line
1.5.6.5
#1 lore raw

PATCH 1/1 Removes dead code in the file common/cmd_i2c.c

Dear Pratap Chandu,

Quoted 7 lines · In message <[email protected]> you wrote:

There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.

---
 common/cmd_i2c.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

Applied, thanks.

Heiko, I hope this is OK with you.

Best regards,

Wolfgang Denk

Signature · 8 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
COMPONENT EQUIVALENCY NOTICE:  The  Subatomic  Particles  (Electrons,
Protons,  etc.) Comprising This Product Are Exactly the Same in Every
Measurable Respect as Those Used in the Products of Other  Manufactu-
rers,  and  No Claim to the Contrary May Legitimately Be Expressed or
Implied.
#2 lore raw

PATCH 1/1 Removes dead code in the file common/cmd_i2c.c

Hello Wolfgang,

Quoted 6 lines · Wolfgang Denk

Dear Pratap Chandu,

Quoted 3 lines · In message <[email protected]> you wrote:

There is some dead code enclosed by #if 0 .... #endif in the file common/cmd_i2c.c This patch removes the dead code.

Quoted 8 lines
Quoted 4 lines
---
 common/cmd_i2c.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

Applied, thanks.

Heiko, I hope this is OK with you.

Hmm.. not really, my last comment on this was:

http://lists.denx.de/pipermail/u-boot/2009-November/064245.html

I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
#3 lore raw

PATCH 1/1 Removes dead code in the file common/cmd_i2c.c

Dear Heiko,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 4 lines

Applied, thanks.

Heiko, I hope this is OK with you.

Hmm.. not really, my last comment on this was:

Ouch, sorry.

Quoted 1 line

http://lists.denx.de/pipermail/u-boot/2009-November/064245.html

I missed that, sorry. This was in another thread, not connected with the patch.

Quoted 2 lines

I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.

What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?]

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Irrtum wiederholt sich immerfort in der Tat.  Deshalb mu? man das
Wahre unerm?dlich in Worten wiederholen.                     - Goethe
#4 lore raw

PATCH 1/1 Removes dead code in the file common/cmd_i2c.c

Hello Wolfgang,

Quoted 7 lines · Wolfgang Denk
Quoted 4 lines · In message <[email protected]> you wrote:
Quoted 3 lines

Applied, thanks.

Heiko, I hope this is OK with you.

Hmm.. not really, my last comment on this was:

Ouch, sorry.

No probelm.

Quoted 11 lines
Quoted 1 line

http://lists.denx.de/pipermail/u-boot/2009-November/064245.html

I missed that, sorry. This was in another thread, not connected with the patch.

Quoted 2 lines

I don;t know, if this was ever used, but we should make this as a CONFIG option, like CONFIG_SYS_I2C_CMD_MW_WITH_PROBE.

What do you suggest? Shall I revert the patch, or can you provide a new commit to re-add this feature? [But then, it would be unused code, which we don't want to add, right?]

I actually vote for removing the code, so I sent soon a patch, which fixes the comment.

bye
Heiko

Signature · 2 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany