cfq: Optimization for close cooperating queue searching
PATCH 1/1 cfq: Optimization for close cooperating queue searching
It doesn't make any sense to try to find out a close cooperating queue if current cfqq is the only one in the group.
Signed-off-by Gui Jianfeng <[email protected]>
--- block/cfq-iosched.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
block/cfq-iosched.c +6 -0
@@ -1750,6 +1750,12 @@ static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd,return NULL ;/* +* Don't search priority tree if it's the only queue in the group. +*/ +if (cur_cfqq->cfqg->nr_cfqq ==1 ) +return NULL ; + +/* * We should notice if some of the queues are cooperating, eg * working closely on the same area of the disk. In that case, * we can group them together and don't waste time idling.
Signature · 1 line
1.5.4.rc3
Quoted 27 lines · Gui Jianfeng
It doesn't make any sense to try to find out a close cooperating queue if current cfqq is the only one in the group.
Signed-off-by Gui Jianfeng <[email protected]>--- block/cfq-iosched.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)block/cfq-iosched.c +6
-0@@ -1750,6 +1750,12 @@ static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd,return NULL ;/* +* Don't search priority tree if it's the only queue in the group. +*/ +if (cur_cfqq->cfqg->nr_cfqq ==1 ) +return NULL ; + +/* * We should notice if some of the queues are cooperating, eg * working closely on the same area of the disk. In that case, * we can group them together and don't waste time idling. Signature · 1 line
1.5.4.rc3
Good point, thanks applied.
Signature · 1 line
Jens Axboe
Quoted 4 lines · Gui Jianfeng
It doesn't make any sense to try to find out a close cooperating queue if current cfqq is the only one in the group.
Signed-off-by Gui Jianfeng <[email protected]>
Thanks Gui. Looks good.
Vivek
Quoted 23 lines
--- block/cfq-iosched.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)block/cfq-iosched.c +6
-0@@ -1750,6 +1750,12 @@ static struct cfq_queue *cfq_close_cooperator(struct cfq_data *cfqd,return NULL ;/* +* Don't search priority tree if it's the only queue in the group. +*/ +if (cur_cfqq->cfqg->nr_cfqq ==1 ) +return NULL ; + +/* * We should notice if some of the queues are cooperating, eg * working closely on the same area of the disk. In that case, * we can group them together and don't waste time idling. Signature · 1 line
1.5.4.rc3