radio/sound/miro: fix build, cleanup depends/selects
PATCH 1/1 radio/sound/miro: fix build, cleanup depends/selects
From: Randy Dunlap <[email protected]>
miropcm20 uses ALSA (snd_) interfaces from the SND_MIRO driver, so it should depend on SND.
(selecting SND_MIRO when CONFIG_SND is not enabled is a problem.)
drivers/built-in.o: In function `vidioc_s_ctrl':
radio-miropcm20.c:(.text+0x227499): undefined reference to snd_aci_cmd' drivers/built-in.o: In function vidioc_s_frequency':
radio-miropcm20.c:(.text+0x227574): undefined reference to snd_aci_cmd' radio-miropcm20.c:(.text+0x227588): undefined reference to snd_aci_cmd' drivers/built-in.o: In function `pcm20_init':
radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci'
miropcm20 selects SND_MIRO but SND_ISA may be not enabled, so also select SND_ISA so that the snd-miro driver will be built. Otherwise there are missing symbols:
ERROR: "snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined!
--- drivers/media/radio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/radio/Kconfig +2 -1
@@ -197,7 +197,8 @@ config RADIO_MAESTRO config RADIO_MIROPCM20 tristate "miroSOUND PCM20 radio" - depends on ISA && VIDEO_V4L2 + depends on ISA && VIDEO_V4L2 && SND + select SND_ISA select SND_MIRO ---help--- Choose Y here if you have this FM radio card. You also need to enable
Takashi Iwai
AppliedAt Tue, 8 Dec 2009 09:13:07 -0800,
Quoted 26 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
miropcm20 uses ALSA (
snd_) interfaces from theSND_MIROdriver, so it should depend on SND.
(selectingSND_MIROwhenCONFIG_SNDis not enabled is a problem.)
drivers/built-in.o: In function `vidioc_s_ctrl':
radio-miropcm20.c:(.text+0x227499): undefined reference tosnd_aci_cmd' drivers/built-in.o: In functionvidioc_s_frequency':
radio-miropcm20.c:(.text+0x227574): undefined reference tosnd_aci_cmd' radio-miropcm20.c:(.text+0x227588): undefined reference tosnd_aci_cmd'drivers/built-in.o: In function `pcm20_init':
radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci'miropcm20 selects
SND_MIRObutSND_ISAmay be not enabled, so also selectSND_ISAso that the snd-miro driver will be built. Otherwise there are missing symbols:ERROR: "
snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined!
Quoted 4 lines
Signed-off-by Randy Dunlap <[email protected]>Cc Krzysztof Helt <[email protected]>Cc Takashi Iwai <[email protected]>
Thanks, applied to sound git tree now.
I'm going to send the second pull request tomorrow or so.
Takashi
Quoted 25 lines · On Tue, 8 Dec 2009 09:13:07 -0800 Randy Dunlap <[email protected]> wrote:
From: Randy Dunlap <[email protected]>
miropcm20 uses ALSA (
snd_) interfaces from theSND_MIROdriver, so it should depend on SND.
(selectingSND_MIROwhenCONFIG_SNDis not enabled is a problem.)
drivers/built-in.o: In function `vidioc_s_ctrl':
radio-miropcm20.c:(.text+0x227499): undefined reference tosnd_aci_cmd' drivers/built-in.o: In functionvidioc_s_frequency':
radio-miropcm20.c:(.text+0x227574): undefined reference tosnd_aci_cmd' radio-miropcm20.c:(.text+0x227588): undefined reference tosnd_aci_cmd'drivers/built-in.o: In function `pcm20_init':
radio-miropcm20.c:(.init.text+0x2a784): undefined reference to `snd_aci_get_aci'miropcm20 selects
SND_MIRObutSND_ISAmay be not enabled, so also selectSND_ISAso that the snd-miro driver will be built. Otherwise there are missing symbols:ERROR: "
snd_opl4_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_pcm" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_timer" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_create" [sound/isa/opti9xx/snd-miro.ko] undefined!
ERROR: "snd_wss_mixer" [sound/isa/opti9xx/snd-miro.ko] undefined!
Quoted 8 lines
Signed-off-by Randy Dunlap <[email protected]>Cc Krzysztof Helt <[email protected]>Cc Takashi Iwai <[email protected]>--- drivers/media/radio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
Internetowi nie placa! Otworz Konto Direct.
http://link.interia.pl/f24f7