Remove superfluous uses of V_PROMPT macro.
PATCH 1/1 Remove superfluous uses of V_PROMPT macro.
A number of config files define the V_PROMPT macro for the command-line prompt, only to immediately use that macro to define CONFIG_SYS_PROMPT, making V_PROMPT entirely superfluous.
---
i think this takes care of all of them.
include/configs/apollon.h | 4 +--- include/configs/omap2420h4.h | 8 +++----- include/configs/omap3_beagle.h | 4 +--- include/configs/omap3_evm.h | 4 +--- include/configs/omap3_overo.h | 4 +--- include/configs/omap3_pandora.h | 4 +--- include/configs/omap3_sdp3430.h | 3 +-- include/configs/omap3_zoom1.h | 4 +--- 8 files changed, 10 insertions(+), 25 deletions(-)
include/configs/apollon.h +1 -3
@@ -183,10 +183,8 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "Apollon # " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "Apollon # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
include/configs/omap2420h4.h +3 -5
@@ -163,14 +163,12 @@/* * Miscellaneous configurable options */ +#define CONFIG_SYS_LONGHELP /* undef to save memory */ #ifdef CONFIG_APTIX -#define V_PROMPT "OMAP2420 Aptix # " +# define CONFIG_SYS_PROMPT "OMAP2420 Aptix # "#else -#define V_PROMPT "OMAP242x H4 # " +# define CONFIG_SYS_PROMPT "OMAP242x H4 # "#endif - -#define CONFIG_SYS_LONGHELP /* undef to save memory */ -#define CONFIG_SYS_PROMPT V_PROMPT#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE+sizeof(CONFIG_SYS_PROMPT)+16)
include/configs/omap3_beagle.h +1 -3
@@ -213,12 +213,10 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "OMAP3 beagleboard.org # " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "OMAP3 beagleboard.org # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
include/configs/omap3_evm.h +1 -3
@@ -194,12 +194,10 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "OMAP3_EVM # " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "OMAP3_EVM # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
include/configs/omap3_overo.h +1 -3
@@ -199,12 +199,10 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "Overo # " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "Overo # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
include/configs/omap3_pandora.h +1 -3
@@ -191,12 +191,10 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "Pandora # " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "Pandora # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
include/configs/omap3_sdp3430.h +1 -2
@@ -263,12 +263,11 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "OMAP34XX SDP # "#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "OMAP34XX SDP # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
include/configs/omap3_zoom1.h +1 -3
@@ -199,12 +199,10 @@/* * Miscellaneous configurable options */ -#define V_PROMPT "OMAP3 Zoom1# " -#define CONFIG_SYS_LONGHELP /* undef to save memory */ #define CONFIG_SYS_HUSH_PARSER /* use "hush" command parser */ #define CONFIG_SYS_PROMPT_HUSH_PS2 "> " -#define CONFIG_SYS_PROMPT V_PROMPT +#define CONFIG_SYS_PROMPT "OMAP3 Zoom1 # "#define CONFIG_SYS_CBSIZE 256/* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca Twitter: http://twitter.com/rpjday
========================================================================
PATCH 1/1 Remove superfluous uses of V_PROMPT macro.
Dear "Robert P. J. Day",
Quoted 11 lines · In message <alpine.LFD.2.00.0912071945100.4417@localhost> you wrote:
A number of config files define the
V_PROMPTmacro for the command-line prompt, only to immediately use that macro to defineCONFIG_SYS_PROMPT, makingV_PROMPTentirely superfluous.Signed-off-by Robert P. J. Day <[email protected]>---
i think this takes care of all of them.
Quoted 9 lines
include/configs/apollon.h | 4 +--- include/configs/omap2420h4.h | 8 +++----- include/configs/omap3_beagle.h | 4 +--- include/configs/omap3_evm.h | 4 +--- include/configs/omap3_overo.h | 4 +--- include/configs/omap3_pandora.h | 4 +--- include/configs/omap3_sdp3430.h | 3 +-- include/configs/omap3_zoom1.h | 4 +--- 8 files changed, 10 insertions(+), 25 deletions(-)
Best regards,
Wolfgang Denk
Signature · 5 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Q: How many IBM CPU's does it take to execute a job? A: Four; three to hold it down, and one to rip its head off.