Skip to contentSkip to conversation

gianfar breaking builds

PATCH Applied Benjamin Herrenschmidt 4 participants 8 messages Dec 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

In my next (not pushed out yet as I'm writing this but will be by the time you read it hopefully), I get a build failure:

/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In function ‘gfar_netpoll’:
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653: error: invalid storage class for function ‘gfar_interrupt’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652: warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681: error: invalid storage class for function ‘adjust_link’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764: error: invalid storage class for function ‘gfar_set_multi’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855: error: invalid storage class for function ‘gfar_clear_exact_match’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877: error: invalid storage class for function ‘gfar_set_hash_for_addr’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898: error: invalid storage class for function ‘gfar_set_mac_for_addr’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922: error: invalid storage class for function ‘gfar_error’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017: warning: ‘alias’ attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032: error: invalid storage class for function ‘gfar_init’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037: error: invalid storage class for function ‘gfar_exit’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041: error: invalid storage class for function ‘__inittest’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041: warning: ‘alias’ attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: error: invalid storage class for function ‘__exittest’ /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: warning: ‘alias’ attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042: error: expected declaration or statement at end of input make[3]: *** [drivers/net/gianfar.o] Error 1

Stephen says that breakage has been in -next for some time...

Can you guys sort it out ?

Cheers,
Ben.

#1 lore raw

Hi Ben,

Can you point to me from where you cloned the tree.

Also, net-next-2.6 tree was building for me.

--
Thanks
Sandeep

Quoted 65 lines

-----Original Message-----
From:=20 linuxppc-dev-bounces+sandeep.kumar=3Dfreescale.com@lists.ozlabs.o rg=20 [mailto:linuxppc-dev-bounces+sandeep.kumar=3Dfreescale.com@lists. ozlabs.org] On Behalf Of Benjamin Herrenschmidt
Sent: Wednesday, December 09, 2009 12:27 PM
To: Kumar Gala
Cc: linuxppc-dev
Subject: gianfar breaking builds

In my next (not pushed out yet as I'm writing this but will be=20 by the time you read it hopefully), I get a build failure:

/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In=20 function 'gfar_netpoll':
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653:=20
error: invalid storage class for function 'gfar_interrupt' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652:=20
warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681:=20
error: invalid storage class for function 'adjust_link' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764:=20
error: invalid storage class for function 'gfar_set_multi' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855:=20
error: invalid storage class for function 'gfar_clear_exact_match' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877:=20
error: invalid storage class for function 'gfar_set_hash_for_addr' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898:=20
error: invalid storage class for function 'gfar_set_mac_for_addr' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922:=20
error: invalid storage class for function 'gfar_error' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017:=20
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032:=20
error: invalid storage class for function 'gfar_init' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037:=20
error: invalid storage class for function 'gfar_exit' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:=20
error: invalid storage class for function '__inittest' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:=20
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
error: invalid storage class for function '__exittest' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:=20
error: expected declaration or statement at end of input make[3]: *** [drivers/net/gianfar.o] Error 1

Stephen says that breakage has been in -next for some time...

Can you guys sort it out ?

Cheers,
Ben.

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

#2 lore raw
Quoted 5 lines · On Wed, 2009-12-09 at 14:20 +0530, Kumar Gopalpet-B05799 wrote:

Hi Ben,

Can you point to me from where you cloned the tree.

Also, net-next-2.6 tree was building for me.

This is powerpc-next which contains the current Linus stuff plus the pending powerpc stuff. If that's fixed in net-next then we shall wait for Dave to merge it I suppose.

Cheers,
Ben.

Quoted 69 lines

--
Thanks
Sandeep

Quoted 65 lines

-----Original Message-----
From:
[email protected] rg [mailto:linuxppc-dev-bounces+sandeep.kumar=freescale.com@lists. ozlabs.org] On Behalf Of Benjamin Herrenschmidt
Sent: Wednesday, December 09, 2009 12:27 PM
To: Kumar Gala
Cc: linuxppc-dev
Subject: gianfar breaking builds

In my next (not pushed out yet as I'm writing this but will be by the time you read it hopefully), I get a build failure:

/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In function 'gfar_netpoll':
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653:
error: invalid storage class for function 'gfar_interrupt' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2652:
warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2681:
error: invalid storage class for function 'adjust_link' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2764:
error: invalid storage class for function 'gfar_set_multi' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2855:
error: invalid storage class for function 'gfar_clear_exact_match' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2877:
error: invalid storage class for function 'gfar_set_hash_for_addr' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2898:
error: invalid storage class for function 'gfar_set_mac_for_addr' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:2922:
error: invalid storage class for function 'gfar_error' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3017:
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3032:
error: invalid storage class for function 'gfar_init' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3037:
error: invalid storage class for function 'gfar_exit' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:
error: invalid storage class for function '__inittest' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3041:
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
error: invalid storage class for function '__exittest' /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
warning: ISO C90 forbids mixed declarations and code /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
warning: 'alias' attribute ignored /home/benh/linux-powerpc-test/drivers/net/gianfar.c:3042:
error: expected declaration or statement at end of input make[3]: *** [drivers/net/gianfar.o] Error 1

Stephen says that breakage has been in -next for some time...

Can you guys sort it out ?

Cheers,
Ben.

_______________________________________________
Linuxppc-dev mailing list
[email protected]
https://lists.ozlabs.org/listinfo/linuxppc-dev

#3 lore raw

=20

Quoted 5 lines

This is powerpc-next which contains the current Linus stuff=20 plus the pending powerpc stuff. If that's fixed in net-next=20 then we shall wait for Dave to merge it I suppose.

I din't notice that netpoll wa enabled in your compilation. This is also not wotking on net-next tree.

Will send out a patch today in some time.

--

Thanks
Sandeep

#4 lore raw
Quoted 5 lines · On Wed, 2009-12-09 at 15:02 +0530, Kumar Gopalpet-B05799 wrote:

I din't notice that netpoll wa enabled in your compilation. This is also not wotking on net-next tree.

Will send out a patch today in some time.

Ah yes, this is something close to a 6xx_defconfig. Thanks.

Cheers,
Ben.

#5 lore raw

PATCH 1/1 gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y

In reply to Benjamin Herrenschmidt

commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add Multiple group Support") introduced the following build error with CONFIG_NET_POLL_CONTROLLER=y:

CC ggianfar.o
ggianfar.c: In function 'gfar_netpoll':
ggianfar.c:2653: error: invalid storage class for function 'gfar_interrupt' ggianfar.c:2652: warning: ISO C90 forbids mixed declarations and code ggianfar.c:2681: error: invalid storage class for function 'adjust_link' ggianfar.c:2764: error: invalid storage class for function 'gfar_set_multi' ggianfar.c:2855: error: invalid storage class for function 'gfar_clear_exact_match' ggianfar.c:2877: error: invalid storage class for function 'gfar_set_hash_for_addr' ggianfar.c:2898: error: invalid storage class for function 'gfar_set_mac_for_addr' ggianfar.c:2922: error: invalid storage class for function 'gfar_error' ggianfar.c:3020: warning: ISO C90 forbids mixed declarations and code ggianfar.c:3032: error: invalid storage class for function 'gfar_init' ggianfar.c:3037: error: invalid storage class for function 'gfar_exit' ggianfar.c:3041: error: initializer element is not constant ggianfar.c:3042: error: initializer element is not constant ggianfar.c:3042: warning: ISO C90 forbids mixed declarations and code ggianfar.c:3042: error: expected declaration or statement at end of input make[1]: *** [ggianfar.o] Error 1

This patch fixes the issue.

---

Quoted 5 lines · Benjamin Herrenschmidt

In my next (not pushed out yet as I'm writing this but will be by the time you read it hopefully), I get a build failure:

/home/benh/linux-powerpc-test/drivers/net/gianfar.c: In function ‘gfar_netpoll’:
/home/benh/linux-powerpc-test/drivers/net/gianfar.c:2653: error: invalid storage class for function ‘gfar_interrupt’

[...]

Quoted 5 lines

make[3]: *** [drivers/net/gianfar.o] Error 1

Stephen says that breakage has been in -next for some time...

Can you guys sort it out ?

 drivers/net/gianfar.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/gianfar.c +1 -0
index 16def13..6850dc0 100644
@@ -2644,6 +2644,7 @@ static void gfar_netpoll(struct net_device *dev)
 			gfar_interrupt(priv->gfargrp[i].interruptTransmit,
 						&priv->gfargrp[i]);
 			enable_irq(priv->gfargrp[i].interruptTransmit);
+		}
 	}
 }
 #endif
Signature · 1 line
1.6.3.3
maintainer Applied
#6 lore raw

Re: [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y

From: Anton Vorontsov <[email protected]>
Date: Wed, 9 Dec 2009 13:44:27 +0300

Quoted 3 lines

commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add Multiple group Support") introduced the following build error with CONFIG_NET_POLL_CONTROLLER=y:

...

Quoted 4 lines

This patch fixes the issue.

Applied, but this shows that netconsole needs some serious testing with this drive now :-/

Thanks.

#7 lore raw

RE: [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y

Quoted 13 lines

From: Anton Vorontsov <[email protected]>
Date: Wed, 9 Dec 2009 13:44:27 +0300

Quoted 3 lines

commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 ("gianfar: Add Multiple group Support") introduced the following build error with CONFIG_NET_POLL_CONTROLLER=y:

...

Quoted 4 lines

This patch fixes the issue.

Thanks Anton !