Skip to contentSkip to conversation

i386: remove 'usedac' kernel parameter

PATCH In review Amerigo Wang 2 participants 3 messages Dec 9, 2009 – Dec 14, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i386: remove 'usedac' kernel parameter

It is scheduled to be removed.

Cc Glauber Costa <[email protected]>
Cc Ingo Molnar <[email protected]>

---

Documentation/feature-removal-schedule.txt +0 -7
index 591e944..8c895f6 100644
@@ -291,13 +291,6 @@ Who:	Michael Buesch <[email protected]>
 
 ---------------------------
 
-What:	usedac i386 kernel parameter
-When:	2.6.27
-Why:	replaced by allowdac and no dac combination
-Who:	Glauber Costa <[email protected]>
-
----------------------------
-
 What: print_fn_descriptor_symbol()
 When: October 2009
 Why:  The %pF vsprintf format provides the same functionality in a
arch/x86/kernel/pci-dma.c +0 -4
index afcc58b..2f76c7b 100644
@@ -210,10 +210,6 @@ static __init int iommu_setup(char *p)
 			forbid_dac = 0;
 		if (!strncmp(p, "nodac", 5))
 			forbid_dac = 1;
-		if (!strncmp(p, "usedac", 6)) {
-			forbid_dac = -1;
-			return 1;
-		}
 #ifdef CONFIG_SWIOTLB
 		if (!strncmp(p, "soft", 4))
 			swiotlb = 1;
#1 lore raw
Quoted 12 lines · On Wed, 9 Dec 2009 01:25:48 -0500 Amerigo Wang <[email protected]> wrote:

It is scheduled to be removed.

Cc Glauber Costa <[email protected]>
Cc Ingo Molnar <[email protected]>

---

Documentation/feature-removal-schedule.txt +0 -0
index 591e944..8c895f6 100644

Documentation/feature-removal-schedule.txt Who: Michael Buesch <[email protected]> · line 300

Quoted 10 lines
Documentation/feature-removal-schedule.txt +0 -7
@@ -291,13 +291,6 @@ Who:	Michael Buesch <[email protected]>
 
 ---------------------------
 
-What:	usedac i386 kernel parameter
-When:	2.6.27
-Why:	replaced by allowdac and no dac combination
-Who:	Glauber Costa <[email protected]>
-
----------------------------
-

I'm not sure about the above description, I'm not against removing this option though.

IIUC, the usedac option enables us to stop via_no_dac() setting forbid_dac to 1. That is, someone who uses VIA bridges can use DAC with this option even if some of VIA bridges seem to be broken about DAC. I can't see how we can do the same thing with "allowdac" and "nodac" combination.

author
#2 lore raw
Quoted 29 lines · FUJITA Tomonori
Quoted 12 lines · On Wed, 9 Dec 2009 01:25:48 -0500 Amerigo Wang <[email protected]> wrote:

It is scheduled to be removed.

Cc Glauber Costa <[email protected]>
Cc Ingo Molnar <[email protected]>

---

Documentation/feature-removal-schedule.txt +0 -0
index 591e944..8c895f6 100644

Documentation/feature-removal-schedule.txt Who: Michael Buesch <[email protected]> · line 300

Quoted 10 lines
Documentation/feature-removal-schedule.txt +0 -7
@@ -291,13 +291,6 @@ Who:	Michael Buesch <[email protected]>
 
 ---------------------------
 
-What:	usedac i386 kernel parameter
-When:	2.6.27
-Why:	replaced by allowdac and no dac combination
-Who:	Glauber Costa <[email protected]>
-
----------------------------
-

I'm not sure about the above description, I'm not against removing this option though.

Quoted 5 lines

IIUC, the usedac option enables us to stop via_no_dac() setting forbid_dac to 1. That is, someone who uses VIA bridges can use DAC with this option even if some of VIA bridges seem to be broken about DAC. I can't see how we can do the same thing with "allowdac" and "nodac" combination.

Hmm, yes, right, I missed this point.

Thanks!