qemu/tap: add -net tap,dev= option
PATCH 1/1 qemu/tap: add -net tap,dev= option
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
---
net.c +5 -0
@@ -955,6 +955,11 @@ static struct { }, #ifndef _WIN32 { + .name = "dev", + .type = QEMU_OPT_STRING, + .help = "character device pathname", + }, + { .name = "fd", .type = QEMU_OPT_STRING, .help = "file descriptor of an already opened tap",
net/tap-aix.c +2 -1
@@ -25,7 +25,8 @@#include "net/tap.h" #include <stdio.h> -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {fprintf (stderr,"no tap on AIX\n" );return -1 ;
net/tap-bsd.c +2 -1
@@ -40,7 +40,8 @@#include <util.h> #endif -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;
net/tap-linux.c +11 -4
@@ -32,14 +32,21 @@#include "sysemu.h" #include "qemu-common.h" -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {struct ifreq ifr;int fd, ret; +const char *path; -TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (dev[0 ] =='\0' ) + path ="/dev/net/tun" ; +else + path = dev; + +TFR (fd =open (dev,O_RDWR ));if (fd <0 ) { -fprintf (stderr,"warning: could not open /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not open %s: no virtual network emulation\n" , path);return -1 ; }memset (&ifr,0 ,sizeof (ifr));
@@ -70,7 +77,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_requiredpstrcpy (ifr.ifr_name,IFNAMSIZ ,"tap%d" ); ret =ioctl (fd,TUNSETIFF , (void *) &ifr);if (ret !=0 ) { -fprintf (stderr,"warning: could not configure /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not configure %s: no virtual network emulation\n" , path);close (fd);return -1 ; }
net/tap-solaris.c +2 -1
@@ -171,7 +171,8 @@ static int tap_alloc(char *dev, size_t dev_size)return tap_fd; } -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {char dev[10 ]="" ;int fd;
net/tap.c +15 -5
@@ -343,12 +343,17 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +char dev[128 ] = {0 ,};const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); } +if (qemu_opt_get (opts,"dev" )) { +pstrcpy (dev,sizeof (dev),qemu_opt_get (opts,"dev" )); + } + *vnet_hdr =qemu_opt_get_bool (opts,"vnet_hdr" ,1 );if (qemu_opt_get (opts,"vnet_hdr" )) { vnet_hdr_required = *vnet_hdr;
@@ -356,7 +361,8 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) vnet_hdr_required =0 ; } -TFR (fd =tap_open (ifname,sizeof (ifname), vnet_hdr, vnet_hdr_required)); +TFR (fd =tap_open (ifname,sizeof (ifname), dev,sizeof (dev), + vnet_hdr, vnet_hdr_required));if (fd <0 ) {return -1 ; }
@@ -371,6 +377,7 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) }qemu_opt_set (opts,"ifname" , ifname); +qemu_opt_set (opts,"dev" , dev);return fd; }
@@ -382,10 +389,12 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {if (qemu_opt_get (opts,"ifname" ) || +qemu_opt_get (opts,"dev" ) ||qemu_opt_get (opts,"script" ) ||qemu_opt_get (opts,"downscript" ) ||qemu_opt_get (opts,"vnet_hdr" )) { -qemu_error ("ifname=, script=, downscript= and vnet_hdr= is invalid with fd=\n" ); +qemu_error ("ifname=, dev=, script=, downscript= and vnet_hdr= is " +"invalid with fd=\n" );return -1 ; }
@@ -425,15 +434,16 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {snprintf (s->nc.info_str,sizeof (s->nc.info_str),"fd=%d" , fd); }else { -const char *ifname, *script, *downscript; +const char *ifname, *dev, *script, *downscript; ifname =qemu_opt_get (opts,"ifname" ); + dev =qemu_opt_get (opts,"dev" ); script =qemu_opt_get (opts,"script" ); downscript =qemu_opt_get (opts,"downscript" );snprintf (s->nc.info_str,sizeof (s->nc.info_str), -"ifname=%s,script=%s,downscript=%s" , - ifname, script, downscript); +"ifname=%s,dev=%s,script=%s,downscript=%s" , + ifname, dev, script, downscript);if (strcmp (downscript,"no" ) !=0 ) {snprintf (s->down_script,sizeof (s->down_script),"%s" , downscript);
net/tap.h +2 -1
@@ -34,7 +34,8 @@int net_init_tap (QemuOpts *opts,Monitor *mon,const char *name,VLANState *vlan); -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required); +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required);ssize_t tap_read_packet (int tapfd,uint8_t *buf,int maxlen);
qemu-options.hx +3 -1
@@ -810,12 +810,14 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, "-net tap[,vlan=n][,name=str],ifname=name\n" " connect the host TAP network interface to VLAN 'n'\n" #else - "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" + "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,dev=str][,script=file]\n" + " [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" + " use 'dev=str' to open a specific tap character device\n" " use 'sndbuf=nbytes' to limit the size of the send buffer; the\n" " default of 'sndbuf=1048576' can be disabled using 'sndbuf=0'\n" " use vnet_hdr=off to avoid enabling the IFF_VNET_HDR tap flag; use\n"
Quoted 6 lines · Arnd Bergmann
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
Signed-off-by Arnd Bergmann <[email protected]>
Looks fine to me
Cheers,
Mark.
Quoted 42 lines · Arnd Bergmann
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
Signed-off-by Arnd Bergmann <[email protected]>---
net.c +5
-0@@ -955,6 +955,11 @@ static struct { }, #ifndef _WIN32 { + .name = "dev", + .type = QEMU_OPT_STRING, + .help = "character device pathname", + }, + { .name = "fd", .type = QEMU_OPT_STRING, .help = "file descriptor of an already opened tap",net/tap-aix.c +2
-1@@ -25,7 +25,8 @@#include "net/tap.h" #include <stdio.h> -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {fprintf (stderr,"no tap on AIX\n" );return -1 ;net/tap-bsd.c +0
-0
net/tap-bsd.c line 47
Quoted 9 lines
net/tap-bsd.c +2
-1@@ -40,7 +40,8 @@#include <util.h> #endif -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;
Does this compile?
net/tap-linux.c line 35
Quoted 10 lines
net/tap-linux.c +1
-1@@ -32,14 +32,21 @@#include "sysemu.h" #include "qemu-common.h" -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open(char *ifname, int ifname_size, char *dev, int dev_size,
dev is never modified, so it should be const char *.
net/tap-linux.c line 42
Quoted 8 lines
net/tap-linux.c +3
-1+ int *vnet_hdr, int vnet_hdr_required) {struct ifreq ifr;int fd, ret; +const char *path; -TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (dev[0 ] =='\0' )
== 0 checks are ugly. if (*dev) is shorter, and it's a standard C idiom to detect non-empty string. Or better pass NULL if no device, then you can just path = dev ? dev : "/dev/net/tun".
net/tap-linux.c line 45
Quoted 3 lines
net/tap-linux.c +3
-0+ path ="/dev/net/tun" ; + else + path = dev;
Please do not indent by single space.
Quoted 22 lines
net/tap-linux.c +4
-2+ +TFR (fd =open (dev,O_RDWR ));if (fd <0 ) { -fprintf (stderr,"warning: could not open /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not open %s: no virtual network emulation\n" , path);return -1 ; }memset (&ifr,0 ,sizeof (ifr));@@ -70,7 +77,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_requiredpstrcpy (ifr.ifr_name,IFNAMSIZ ,"tap%d" ); ret =ioctl (fd,TUNSETIFF , (void *) &ifr);if (ret !=0 ) { -fprintf (stderr,"warning: could not configure /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not configure %s: no virtual network emulation\n" , path);close (fd);return -1 ; }net/tap-solaris.c +0
-0
net/tap-solaris.c static int tap_alloc(char *dev, size_t dev_size) · line 178
Quoted 9 lines
net/tap-solaris.c +2
-1@@ -171,7 +171,8 @@ static int tap_alloc(char *dev, size_t dev_size)return tap_fd; } -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {char dev[10 ]="" ;int fd;
Does this compile?
Quoted 9 lines
net/tap.c +1
-0@@ -343,12 +343,17 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +char dev[128 ] = {0 ,};
net/tap.c static int net_tap_init(QemuOpts *opts, int *vnet_hdr) · line 356
Quoted 10 lines
net/tap.c +4
-0const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); } +if (qemu_opt_get (opts,"dev" )) { +pstrcpy (dev,sizeof (dev),qemu_opt_get (opts,"dev" )); + } +
While in this case this is unlikely to be a problem in practice, we still should not add arbitrary limitations on file name lengths. Just teach tap_open to get NULL instead of and empty string, or better supply default /dev/net/tun to the option, and you will not need the strcpy.
Quoted 41 lines
net/tap.c +7
-3*vnet_hdr =qemu_opt_get_bool (opts,"vnet_hdr" ,1 );if (qemu_opt_get (opts,"vnet_hdr" )) { vnet_hdr_required = *vnet_hdr;@@ -356,7 +361,8 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) vnet_hdr_required =0 ; } -TFR (fd =tap_open (ifname,sizeof (ifname), vnet_hdr, vnet_hdr_required)); +TFR (fd =tap_open (ifname,sizeof (ifname), dev,sizeof (dev), + vnet_hdr, vnet_hdr_required));if (fd <0 ) {return -1 ; }@@ -371,6 +377,7 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) }qemu_opt_set (opts,"ifname" , ifname); +qemu_opt_set (opts,"dev" , dev);return fd; }@@ -382,10 +389,12 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {if (qemu_opt_get (opts,"ifname" ) || +qemu_opt_get (opts,"dev" ) ||qemu_opt_get (opts,"script" ) ||qemu_opt_get (opts,"downscript" ) ||qemu_opt_get (opts,"vnet_hdr" )) { -qemu_error ("ifname=, script=, downscript= and vnet_hdr= is invalid with fd=\n" ); +qemu_error ("ifname=, dev=, script=, downscript= and vnet_hdr= is " +"invalid with fd=\n" );return -1 ; }@@ -425,15 +434,16 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {snprintf (s->nc.info_str,sizeof (s->nc.info_str),"fd=%d" , fd); }else { -const char *ifname, *script, *downscript; +const char *ifname, *dev, *script, *downscript;
net/tap.c int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan · line 445
Quoted 10 lines
net/tap.c +2
-2ifname =qemu_opt_get (opts,"ifname" ); + dev =qemu_opt_get (opts,"dev" ); script =qemu_opt_get (opts,"script" ); downscript =qemu_opt_get (opts,"downscript" ); snprintf(s->nc.info_str, sizeof(s->nc.info_str), -"ifname=%s,script=%s,downscript=%s" , - ifname, script, downscript); + "ifname=%s,dev=%s,script=%s,downscript=%s",
This will look strange if dev is not supplied, will it not? Also, I wonder whether there might be any scripts parsing info string from monitor, that will get broken by the extra parameter. How about we only print dev if it is not the default?
Quoted 25 lines
net/tap.c +1
-0+ ifname, dev, script, downscript);if (strcmp (downscript,"no" ) !=0 ) {snprintf (s->down_script,sizeof (s->down_script),"%s" , downscript);net/tap.h +2
-1@@ -34,7 +34,8 @@int net_init_tap (QemuOpts *opts,Monitor *mon,const char *name,VLANState *vlan); -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required); +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required);ssize_t tap_read_packet (int tapfd,uint8_t *buf,int maxlen);qemu-options.hx +0
-0@@ -810,12 +810,14 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, "-net tap[,vlan=n][,name=str],ifname=name\n" " connect the host TAP network interface to VLAN 'n'\n"
qemu-options.hx DEF("net", HAS_ARG, QEMU_OPTION_net, · line 820
Quoted 10 lines
qemu-options.hx +3
-1#else - "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" + "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,dev=str][,script=file]\n" + " [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" + " use 'dev=str' to open a specific tap character device\n"
please document default /dev/net/tun
Quoted 4 lines
qemu-options.hx +0
-0" use 'sndbuf=nbytes' to limit the size of the send buffer; the\n" " default of 'sndbuf=1048576' can be disabled using 'sndbuf=0'\n" " use vnet_hdr=off to avoid enabling the IFF_VNET_HDR tap flag; use\n"
Quoted 7 lines · Michael S. Tsirkin
Quoted 6 lines · Arnd Bergmann
net/tap-bsd.c +0
-0@@ -40,7 +40,8 @@#include <util.h> #endif
Quoted 8 lines
net/tap-bsd.c line 47
Quoted 6 lines
net/tap-bsd.c +2
-1-int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;Does this compile?
I don't have a BSD or Solaris machine here, or even just a cross-compiler, so I could not test. However, I only add two arguments and I did the identical change in the header file and the linux version of this file, so I am reasonably confident.
Quoted 4 lines
net/tap-bsd.c
Quoted 2 lines
net/tap-bsd.c +1
-1-int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open(char *ifname, int ifname_size, char *dev, int dev_size,dev is never modified, so it should be const char *.
ok.
Quoted 6 lines
Quoted 6 lines
net/tap-bsd.c +2
-0+ int *vnet_hdr, int vnet_hdr_required) {struct ifreq ifr;int fd, ret; +const char *path;
Quoted 6 lines
net/tap-bsd.c
Quoted 2 lines
net/tap-bsd.c +1
-1-TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (dev[0 ] =='\0' )== 0 checks are ugly. if (*dev) is shorter, and it's a standard C idiom to detect non-empty string. Or better pass NULL if no device, then you can just path = dev ? dev : "
/dev/net/tun".
Agreed in principle, but I was following the style that is already used in the same function, and I think consistency is more important in this case.
Quoted 5 lines
net/tap-bsd.c
Quoted 3 lines
net/tap-bsd.c +3
-0+ path ="/dev/net/tun" ; + else + path = dev;Please do not indent by single space.
For some reason, this file uses four character indentation, which I followed for consistency. In the patch this gets mangled when some lines use only spaces for indentation and others use only tabs.
I could change to using only spaces for indentation if that's preferred.
Quoted 15 lines
Quoted 15 lines
net/tap.c +1
-0@@ -343,12 +343,17 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +char dev[128 ] = {0 ,};const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); }
Quoted 9 lines
net/tap.c static int net_tap_init(QemuOpts *opts, int *vnet_hdr) · line 356
Quoted 4 lines
net/tap.c +4
-0+if (qemu_opt_get (opts,"dev" )) { +pstrcpy (dev,sizeof (dev),qemu_opt_get (opts,"dev" )); + } +While in this case this is unlikely to be a problem in practice, we still should not add arbitrary limitations on file name lengths. Just teach
tap_opento get NULL instead of and empty string, or better supply default/dev/net/tunto the option, and you will not need the strcpy.
Right, I will do that, or alternatively make dev an input/output argument, see below.
Quoted 10 lines
net/tap.c int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan · line 445
Quoted 4 lines
net/tap.c +1
-2snprintf(s->nc.info_str, sizeof(s->nc.info_str), -"ifname=%s,script=%s,downscript=%s" , - ifname, script, downscript); + "ifname=%s,dev=%s,script=%s,downscript=%s",This will look strange if dev is not supplied, will it not? Also, I wonder whether there might be any scripts parsing info string from monitor, that will get broken by the extra parameter. How about we only print dev if it is not the default?
Right. I originally planned to return "/dev/net/tun" from tap_open in that case, but I forgot to put that in. It would also not work well for Solaris and BSD unless I add untested code there.
I guess it would be consistent to do that, but unless someone insists on it, I'll just follow your advice here and remove it from being printed.
Quoted 10 lines
net/tap.c static int net_tap_init(QemuOpts *opts, int *vnet_hdr)
Quoted 8 lines
net/tap.c +3
-0+"-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,dev=str][,script=file]\n" +" [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" +" use 'dev=str' to open a specific tap character device\n" please document default
/dev/net/tun
ok.
Thanks for the review!
Arnd
Re: [Qemu-devel] Re: [PATCH, try 2] qemu/tap: add -net tap, dev= option
Quoted 17 lines · On Wednesday 09 December 2009 13:33:36 Arnd Bergmann wrote:
Quoted 7 lines · Michael S. Tsirkin
Quoted 6 lines · Arnd Bergmann
net/tap-bsd.c +0
-0@@ -40,7 +40,8 @@#include <util.h> #endif Quoted 8 lines
Quoted 6 lines
net/tap-bsd.c +0
-1-int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int
vnet_hdr_required) +int tap_open(char *ifname, intifname_size, char
*dev, intdev_size, + int*vnet_hdr, intvnet_hdr_required){ int fd; char *dev;Does this compile?
Quoted 2 lines
I don't have a BSD or Solaris machine here, or even just a cross-compiler, so I could not test.
This sounds like a bad joke on a virtualization list.
You can say you don't have an AMD or Intel machine to test hw feature XY but saying you don't have a machine running a certain OS is prude as you can always use qemu itself to get that up and running.
Christoph
Signature · 6 lines
---to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632
Quoted 17 lines · Arnd Bergmann
Quoted 7 lines · Michael S. Tsirkin
Quoted 6 lines · Arnd Bergmann
net/tap-bsd.c +0
-0@@ -40,7 +40,8 @@#include <util.h> #endif Quoted 8 lines
net/tap-bsd.c line 47
Quoted 6 lines
net/tap-bsd.c +2
-1-int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,char *dev,int dev_size, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;Does this compile?
Quoted 2 lines
I don't have a BSD or Solaris machine here, or even just a cross-compiler, so I could not test.
It should be possible to install in a VM if you really want to, but that's not my point.
Quoted 3 lines
However, I only add two arguments and I did the identical
change in the header file and the linux version of this file, so I am reasonably confident.
'char *dev' variable has the same name as the new parameter, which is not legal in C99 and normally triggers compiler warning or error.
Quoted 20 lines
Quoted 4 lines
net/tap-bsd.c
Quoted 2 lines
net/tap-bsd.c +1
-1-int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open(char *ifname, int ifname_size, char *dev, int dev_size,dev is never modified, so it should be const char *.
ok.
Quoted 6 lines
Quoted 6 lines
net/tap-bsd.c +2
-0+ int *vnet_hdr, int vnet_hdr_required) {struct ifreq ifr;int fd, ret; +const char *path;Quoted 6 lines
net/tap-bsd.c
Quoted 2 lines
net/tap-bsd.c +1
-1-TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (dev[0 ] =='\0' )== 0 checks are ugly. if (*dev) is shorter, and it's a standard C idiom to detect non-empty string. Or better pass NULL if no device, then you can just path = dev ? dev : "
/dev/net/tun".
Quoted 3 lines
Agreed in principle, but I was following the style that is already used in the same function, and I think consistency is more important in this case.
qemu code in general is inconsistent. Let's make new code look sane, over time most of it will get converted.
Quoted 6 lines
Quoted 5 lines
net/tap-bsd.c
Quoted 3 lines
net/tap-bsd.c +3
-0+ path ="/dev/net/tun" ; + else + path = dev;Please do not indent by single space.
Quoted 6 lines
For some reason, this file uses four character indentation, which I followed for consistency. In the patch this gets mangled when some lines use only spaces for indentation and others use only tabs.
I could change to using only spaces for indentation if that's preferred.
Coding style says you should use spaces for indentation.
Quoted 25 lines
Quoted 15 lines
Quoted 15 lines
net/tap.c +1
-0@@ -343,12 +343,17 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +char dev[128 ] = {0 ,};const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); }Quoted 9 lines
net/tap.c static int net_tap_init(QemuOpts *opts, int *vnet_hdr) · line 356
Quoted 4 lines
net/tap.c +4
-0+if (qemu_opt_get (opts,"dev" )) { +pstrcpy (dev,sizeof (dev),qemu_opt_get (opts,"dev" )); + } +While in this case this is unlikely to be a problem in practice, we still should not add arbitrary limitations on file name lengths. Just teach
tap_opento get NULL instead of and empty string, or better supply default/dev/net/tunto the option, and you will not need the strcpy.
Quoted 2 lines
Right, I will do that, or alternatively make dev an input/output argument, see below.
input/output will require allocating storage for it, so it's more work (assuming length of 128 characters is evil). Not sure it's a good idea.
Quoted 11 lines
Quoted 10 lines
net/tap.c int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlan · line 445
Quoted 4 lines
net/tap.c +1
-2snprintf(s->nc.info_str, sizeof(s->nc.info_str), -"ifname=%s,script=%s,downscript=%s" , - ifname, script, downscript); + "ifname=%s,dev=%s,script=%s,downscript=%s",This will look strange if dev is not supplied, will it not? Also, I wonder whether there might be any scripts parsing info string from monitor, that will get broken by the extra parameter. How about we only print dev if it is not the default?
Quoted 3 lines
Right. I originally planned to return "
/dev/net/tun" fromtap_openin that case, but I forgot to put that in. It would also not work well for Solaris and BSD unless I add untested code there.
I think it's better to add untested feature than intentionally skip it. It's easier for people familiar with the platform to fix a broken feature than to guess what feature needs to be filled in.
If you don't you, should replace ifndef WINDOWS by ifdef LINUX or something like that.
Quoted 19 lines
I guess it would be consistent to do that, but unless someone insists on it, I'll just follow your advice here and remove it from being printed.
Quoted 10 lines
net/tap.c static int net_tap_init(QemuOpts *opts, int *vnet_hdr)
Quoted 8 lines
net/tap.c +3
-0+"-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,dev=str][,script=file]\n" +" [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" +" use 'dev=str' to open a specific tap character device\n" please document default
/dev/net/tunok.
Thanks for the review!
Arnd
PATCH 1/1 qemu/tap: add -net tap, dev= option
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
This version makes it possible to use macvtap without introducing any macvtap specific code in qemu, only a natural extension to the existing interface.
---
Hopefully addressed all comments from Michael. I did compile-test the non-linux files I touched (the solaris file failed to build for another reason), and this now prevents passing dev= on non-linux machines.
net.c | 5 +++++ net/tap-aix.c | 3 ++- net/tap-bsd.c | 9 ++++++++- net/tap-linux.c | 12 ++++++++---- net/tap-solaris.c | 7 ++++++- net/tap.c | 17 ++++++++++++++--- net/tap.h | 3 ++- qemu-options.hx | 10 +++++++++- 8 files changed, 54 insertions(+), 12 deletions(-)
net.c +5 -0
@@ -955,6 +955,11 @@ static struct { }, #ifndef _WIN32 { + .name = "dev", + .type = QEMU_OPT_STRING, + .help = "character device pathname", + }, + { .name = "fd", .type = QEMU_OPT_STRING, .help = "file descriptor of an already opened tap",
net/tap-aix.c +2 -1
@@ -25,7 +25,8 @@#include "net/tap.h" #include <stdio.h> -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *dev, +int *vnet_hdr,int vnet_hdr_required) {fprintf (stderr,"no tap on AIX\n" );return -1 ;
net/tap-bsd.c +8 -1
@@ -40,7 +40,8 @@#include <util.h> #endif -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;
@@ -80,6 +81,12 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_required }#endif +if (devarg) { +qemu_error ("dev= not supported\n" ); +close (fd); +return -1 ; + } +fstat (fd, &s); dev =devname (s.st_rdev,S_IFCHR );pstrcpy (ifname, ifname_size, dev);
net/tap-linux.c +8 -4
@@ -32,14 +32,18 @@#include "sysemu.h" #include "qemu-common.h" -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *dev, +int *vnet_hdr,int vnet_hdr_required) {struct ifreq ifr;int fd, ret; -TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (!*dev) + dev ="/dev/net/tun" ; + +TFR (fd =open (dev,O_RDWR ));if (fd <0 ) { -fprintf (stderr,"warning: could not open /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not open %s: no virtual network emulation\n" , dev);return -1 ; }memset (&ifr,0 ,sizeof (ifr));
@@ -70,7 +74,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_requiredpstrcpy (ifr.ifr_name,IFNAMSIZ ,"tap%d" ); ret =ioctl (fd,TUNSETIFF , (void *) &ifr);if (ret !=0 ) { -fprintf (stderr,"warning: could not configure /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not configure %s: no virtual network emulation\n" , dev);close (fd);return -1 ; }
net/tap-solaris.c +6 -1
@@ -171,10 +171,15 @@ static int tap_alloc(char *dev, size_t dev_size)return tap_fd; } -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required) {char dev[10 ]="" ;int fd; +if (devarg) { +fprintf (stderr,"dev= not supported\n" ); +return -1 ; + }if ( (fd =tap_alloc (dev,sizeof (dev))) <0 ){fprintf (stderr,"Cannot allocate TAP device\n" );return -1 ;
net/tap.c +14 -3
@@ -343,12 +343,15 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +const char *dev;const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); } + dev =qemu_opt_get (opts,"dev" ); + *vnet_hdr =qemu_opt_get_bool (opts,"vnet_hdr" ,1 );if (qemu_opt_get (opts,"vnet_hdr" )) { vnet_hdr_required = *vnet_hdr;
@@ -356,7 +359,8 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) vnet_hdr_required =0 ; } -TFR (fd =tap_open (ifname,sizeof (ifname), vnet_hdr, vnet_hdr_required)); +TFR (fd =tap_open (ifname,sizeof (ifname), dev, vnet_hdr, + vnet_hdr_required));if (fd <0 ) {return -1 ; }
@@ -382,10 +386,12 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {if (qemu_opt_get (opts,"ifname" ) || +qemu_opt_get (opts,"dev" ) ||qemu_opt_get (opts,"script" ) ||qemu_opt_get (opts,"downscript" ) ||qemu_opt_get (opts,"vnet_hdr" )) { -qemu_error ("ifname=, script=, downscript= and vnet_hdr= is invalid with fd=\n" ); +qemu_error ("ifname=, dev=, script=, downscript= and vnet_hdr= is " +"invalid with fd=\n" );return -1 ; }
@@ -425,15 +431,20 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {snprintf (s->nc.info_str,sizeof (s->nc.info_str),"fd=%d" , fd); }else { -const char *ifname, *script, *downscript; +const char *ifname, *dev, *script, *downscript; ifname =qemu_opt_get (opts,"ifname" ); + dev =qemu_opt_get (opts,"dev" ); script =qemu_opt_get (opts,"script" ); downscript =qemu_opt_get (opts,"downscript" );snprintf (s->nc.info_str,sizeof (s->nc.info_str),"ifname=%s,script=%s,downscript=%s" , ifname, script, downscript); +if (dev) { +strncat (s->nc.info_str,",dev=" ,sizeof (s->nc.info_str)); +strncat (s->nc.info_str, dev,sizeof (s->nc.info_str)); + }if (strcmp (downscript,"no" ) !=0 ) {snprintf (s->down_script,sizeof (s->down_script),"%s" , downscript);
net/tap.h +2 -1
@@ -34,7 +34,8 @@int net_init_tap (QemuOpts *opts,Monitor *mon,const char *name,VLANState *vlan); -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required); +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required);ssize_t tap_read_packet (int tapfd,uint8_t *buf,int maxlen);
qemu-options.hx +9 -1
@@ -810,12 +810,20 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, "-net tap[,vlan=n][,name=str],ifname=name\n" " connect the host TAP network interface to VLAN 'n'\n" #else - "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" + "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name]" +#ifdef __linux__ + "[,dev=str]" +#endif + "[,script=file]\n" + " [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" +#ifdef __linux__ + " use 'dev=str' to open a specific tap device (default=/dev/net/tun)\n" +#endif " use 'sndbuf=nbytes' to limit the size of the send buffer; the\n" " default of 'sndbuf=1048576' can be disabled using 'sndbuf=0'\n" " use vnet_hdr=off to avoid enabling the IFF_VNET_HDR tap flag; use\n"
[Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option
Quoted 9 lines · Arnd Bergmann
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
This version makes it possible to use macvtap without introducing any macvtap specific code in qemu, only a natural extension to the existing interface.
Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>Acked-by Mark McLoughlin <[email protected]>Cc "Michael S. Tsirkin" <[email protected]>---
Hopefully addressed all comments from Michael. I did compile-test the non-linux files I touched (the solaris file failed to build for another reason), and this now prevents passing dev= on non-linux machines.
Found a couple more minor nits in the new versions, otherwise looks good.
Quoted 76 lines
net.c | 5 +++++ net/tap-aix.c | 3 ++- net/tap-bsd.c | 9 ++++++++- net/tap-linux.c | 12 ++++++++---- net/tap-solaris.c | 7 ++++++- net/tap.c | 17 ++++++++++++++--- net/tap.h | 3 ++- qemu-options.hx | 10 +++++++++- 8 files changed, 54 insertions(+), 12 deletions(-)net.c +5
-0@@ -955,6 +955,11 @@ static struct { }, #ifndef _WIN32 { + .name = "dev", + .type = QEMU_OPT_STRING, + .help = "character device pathname", + }, + { .name = "fd", .type = QEMU_OPT_STRING, .help = "file descriptor of an already opened tap",net/tap-aix.c +2
-1@@ -25,7 +25,8 @@#include "net/tap.h" #include <stdio.h> -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *dev, +int *vnet_hdr,int vnet_hdr_required) {fprintf (stderr,"no tap on AIX\n" );return -1 ;net/tap-bsd.c +8
-1@@ -40,7 +40,8 @@#include <util.h> #endif -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required) {int fd;char *dev;@@ -80,6 +81,12 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_required }#endif +if (devarg) { +qemu_error ("dev= not supported\n" ); +close (fd); +return -1 ; + } +fstat (fd, &s); dev =devname (s.st_rdev,S_IFCHR );pstrcpy (ifname, ifname_size, dev);net/tap-linux.c +0
-1@@ -32,14 +32,18 @@#include "sysemu.h" #include "qemu-common.h" -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required)
net/tap-linux.c line 43
Quoted 10 lines
net/tap-linux.c +5
-1+int tap_open (char *ifname,int ifname_size,const char *dev, +int *vnet_hdr,int vnet_hdr_required) {struct ifreq ifr;int fd, ret; -TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (!*dev) + dev ="/dev/net/tun" ; +
Did you test without dev parameter? I think dev will be NULL so this will deference a nullpointer ...
probably if (!dev) is what you mean?
Quoted 122 lines
net/tap-linux.c +3
-2+TFR (fd =open (dev,O_RDWR ));if (fd <0 ) { -fprintf (stderr,"warning: could not open /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not open %s: no virtual network emulation\n" , dev);return -1 ; }memset (&ifr,0 ,sizeof (ifr));@@ -70,7 +74,7 @@ int tap_open(char *ifname, int ifname_size, int *vnet_hdr, int vnet_hdr_requiredpstrcpy (ifr.ifr_name,IFNAMSIZ ,"tap%d" ); ret =ioctl (fd,TUNSETIFF , (void *) &ifr);if (ret !=0 ) { -fprintf (stderr,"warning: could not configure /dev/net/tun: no virtual network emulation\n" ); +fprintf (stderr,"warning: could not configure %s: no virtual network emulation\n" , dev);close (fd);return -1 ; }net/tap-solaris.c +6
-1@@ -171,10 +171,15 @@ static int tap_alloc(char *dev, size_t dev_size)return tap_fd; } -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required) +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required) {char dev[10 ]="" ;int fd; +if (devarg) { +fprintf (stderr,"dev= not supported\n" ); +return -1 ; + }if ( (fd =tap_alloc (dev,sizeof (dev))) <0 ){fprintf (stderr,"Cannot allocate TAP device\n" );return -1 ;net/tap.c +14
-3@@ -343,12 +343,15 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) {int fd, vnet_hdr_required;char ifname[128 ] = {0 ,}; +const char *dev;const char *setup_script;if (qemu_opt_get (opts,"ifname" )) {pstrcpy (ifname,sizeof (ifname),qemu_opt_get (opts,"ifname" )); } + dev =qemu_opt_get (opts,"dev" ); + *vnet_hdr =qemu_opt_get_bool (opts,"vnet_hdr" ,1 );if (qemu_opt_get (opts,"vnet_hdr" )) { vnet_hdr_required = *vnet_hdr;@@ -356,7 +359,8 @@ static int net_tap_init(QemuOpts *opts, int *vnet_hdr) vnet_hdr_required =0 ; } -TFR (fd =tap_open (ifname,sizeof (ifname), vnet_hdr, vnet_hdr_required)); +TFR (fd =tap_open (ifname,sizeof (ifname), dev, vnet_hdr, + vnet_hdr_required));if (fd <0 ) {return -1 ; }@@ -382,10 +386,12 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {if (qemu_opt_get (opts,"ifname" ) || +qemu_opt_get (opts,"dev" ) ||qemu_opt_get (opts,"script" ) ||qemu_opt_get (opts,"downscript" ) ||qemu_opt_get (opts,"vnet_hdr" )) { -qemu_error ("ifname=, script=, downscript= and vnet_hdr= is invalid with fd=\n" ); +qemu_error ("ifname=, dev=, script=, downscript= and vnet_hdr= is " +"invalid with fd=\n" );return -1 ; }@@ -425,15 +431,20 @@ int net_init_tap(QemuOpts *opts, Monitor *mon, const char *name, VLANState *vlanif (qemu_opt_get (opts,"fd" )) {snprintf (s->nc.info_str,sizeof (s->nc.info_str),"fd=%d" , fd); }else { -const char *ifname, *script, *downscript; +const char *ifname, *dev, *script, *downscript; ifname =qemu_opt_get (opts,"ifname" ); + dev =qemu_opt_get (opts,"dev" ); script =qemu_opt_get (opts,"script" ); downscript =qemu_opt_get (opts,"downscript" );snprintf (s->nc.info_str,sizeof (s->nc.info_str),"ifname=%s,script=%s,downscript=%s" , ifname, script, downscript); +if (dev) { +strncat (s->nc.info_str,",dev=" ,sizeof (s->nc.info_str)); +strncat (s->nc.info_str, dev,sizeof (s->nc.info_str)); + }if (strcmp (downscript,"no" ) !=0 ) {snprintf (s->down_script,sizeof (s->down_script),"%s" , downscript);net/tap.h +2
-1@@ -34,7 +34,8 @@int net_init_tap (QemuOpts *opts,Monitor *mon,const char *name,VLANState *vlan); -int tap_open (char *ifname,int ifname_size,int *vnet_hdr,int vnet_hdr_required); +int tap_open (char *ifname,int ifname_size,const char *devarg, +int *vnet_hdr,int vnet_hdr_required);ssize_t tap_read_packet (int tapfd,uint8_t *buf,int maxlen);qemu-options.hx +0
-0
qemu-options.hx DEF("net", HAS_ARG, QEMU_OPTION_net, · line 817
Quoted 9 lines
qemu-options.hx +5
-1@@ -810,12 +810,20 @@ DEF("net", HAS_ARG, QEMU_OPTION_net, "-net tap[,vlan=n][,name=str],ifname=name\n" " connect the host TAP network interface to VLAN 'n'\n" #else - "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file][,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" + "-net tap[,vlan=n][,name=str][,fd=h][,ifname=name]" +#ifdef __linux__ + "[,dev=str]" +#endif + "[,script=file]\n"
will be neater if you put [,dev=str] after [,script=file]
Also - it does need a string, but only insofar as all options are strings. Maybe dev=devfile or dev=file would be clearer.
Quoted 12 lines
qemu-options.hx +4
-0+ " [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off]\n" " connect the host TAP network interface to VLAN 'n' and use the\n" " network scripts 'file' (default=%s)\n" " and 'dfile' (default=%s);\n" " use '[down]script=no' to disable script execution;\n" " use 'fd=h' to connect to an already opened TAP interface\n" +#ifdef __linux__ + " use 'dev=str' to open a specific tap device (default=/dev/net/tun)\n" +#endif " use 'sndbuf=nbytes' to limit the size of the send buffer; the\n" " default of 'sndbuf=1048576' can be disabled using 'sndbuf=0'\n" " use vnet_hdr=off to avoid enabling the IFF_VNET_HDR tap flag; use\n"
Re: [Qemu-devel] Re: [PATCH, try 2, version 2] qemu/tap: add -net tap, dev= option
Quoted 10 lines · Michael S. Tsirkin
net/tap-linux.c line 43
Quoted 5 lines · Arnd Bergmann
net/tap-linux.c +3
-1-TFR (fd =open ("/dev/net/tun" ,O_RDWR )); +if (!*dev) + dev ="/dev/net/tun" ; +Did you test without dev parameter? I think dev will be NULL so this will deference a nullpointer ...
probably if (!dev) is what you mean?
D'oh. will fix.
Quoted 3 lines
will be neater if you put [,dev=str] after [,script=file]
Also - it does need a string, but only insofar as all options are strings. Maybe dev=devfile or dev=file would be clearer.
Yep. Thanks,
Arnd
Quoted 7 lines · Arnd Bergmann
In order to support macvtap, we need a way to select the actual tap endpoint. While it would be nice to pass it by network interface name, passing the character device is more flexible, and we can easily do both in the long run.
Signed-off-by Arnd Bergmann <[email protected]>
This isn't really a generic thing and I dislike pretending it is. This is specifically for macvtap.
If we were going to do this, I'd rather introduce a -net macvtap that actually allocated the interfaces (similar to how tap works). The problem with this interface is that it's a two stage process. You have to create an interface, then hand the name to qemu. It would be just as easy to hand qemu an fd with a helper.
What's nice about -net tap is that with a little bit of setup (/etc/qemu-ifup), it Just Works. -net tap,dev= does not share this property.
I think this is a good place where an exec helper would be a natural fit.
Regards,
Anthony Liguori
Quoted 2 lines · Anthony Liguori
This isn't really a generic thing and I dislike pretending it is. This is specifically for macvtap.
Well, depending how how things work out with VMD-q and SR-IOV, I might move the tap interface stuff into a library module and add more user-level shims for it that deal with the creation of character devices.
Macvtap essentially implements a tun/tap compatible character device, while leaving out some of the stuff that doesn't make sense there (e.g. creation of virtual network interfaces). The idea of my patch was to deal with anything that is a tap protocol implementation.
One thing that is special for macvtap is that the guest MAC address has to match the MAC address of the macvtap downstream device, because macvlan filters out all traffic destined for other unicast addresses.
Quoted 5 lines
If we were going to do this, I'd rather introduce a -net macvtap that actually allocated the interfaces (similar to how tap works). The problem with this interface is that it's a two stage process. You have to create an interface, then hand the name to qemu. It would be just as easy to hand qemu an fd with a helper.
You can't really allocate the device from qemu in a nice way. I had mostly implemented macvtap support for your -net bridge helper when I realized this.
Since it uses netlink (with CAP_NET_ADMIN) to create or destroy the netdev, it first needs to wait for udev to create the device node (which is not so bad by itself), and then use netlink again after shutting down to destroy the network device.
Quoted 3 lines
What's nice about -net tap is that with a little bit of setup (
/etc/qemu-ifup), it Just Works. -net tap,dev= does not share this property.
The qemu-ifup stuff IMHO is just a workaround for the problem of having to defer network setup until after you open the device.
Macvtap doesn't have this problem. In the same way we deal with other host resources (raw disk access, USB passthrough, /dev/kvm), you first set up specifically what the user is allowed to do, either manually or through libvirt and then just use it.
Quoted 1 line
I think this is a good place where an exec helper would be a natural fit.
IMHO, the exec helper is a good way to abstract away the difference between tap, macvtap and possibly others based on the host configuration, but it doesn't really make sense for a separate -net macvtap backend like you suggested. You've shown that the helper can be used to enforce user permissions for tun/tap, which lacks this, but for macvtap we can just use regular user permissions.
Arnd