libexport.a: fix a long-standing typo in name_cmp()
Subsystems (2)
PATCH 1/1 libexport.a: fix a long-standing typo in name_cmp()
Not sure what "(!*a || !a == ',')" means... but just a few lines later is "(!*a || *a == ',')". I think "a is '\0' or ','" is what was intended.
Signed-off-by Chuck Lever <[email protected]>
---
Neil --
Looks like a typo. Comments?
support/export/client.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
support/export/client.c +1 -1
@@ -266,7 +266,7 @@ name_cmp(char *a, char *b)/* compare strings a and b, but only upto ',' in a */ while (*a && *b && *a !=',' && *a == *b) a++, b++; -if (!*b && (!*a || !a ==',' ) ) +if (!*b && (!*a || *a ==',' ))return 0 ;if (!*b)return 1 ;if (!*a || *a ==',' )return -1 ;
A message that is not in the archive (sent off-list or not yet received): 20091211212608.29241.27167.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/[email protected]
Quoted 19 lines · Chuck Lever
Not sure what "(!*a || !a == ',')" means... but just a few lines later is "(!*a || *a == ',')". I think "a is '\0' or ','" is what was intended.
Signed-off-by Chuck Lever <[email protected]>---
Neil --
Looks like a typo. Comments?
support/export/client.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)support/export/client.c +0
-0
support/export/client.c name_cmp(char *a, char *b) · line 272
Quoted 8 lines
support/export/client.c +1
-1@@ -266,7 +266,7 @@ name_cmp(char *a, char *b)/* compare strings a and b, but only upto ',' in a */ while (*a && *b && *a !=',' && *a == *b) a++, b++; -if (!*b && (!*a || !a ==',' ) ) +if (!*b && (!*a || *a ==',' ))return 0 ;if (!*b)return 1 ;if (!*a || *a ==',' )return -1 ;
Committed...
steved.