Skip to contentSkip to conversation

gspca m5602: eliminate sparse warnings

PATCH In review Németh Márton 2 participants 3 messages Dec 11, 2009 – Dec 12, 2009 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gspca m5602: eliminate sparse warnings

From: Márton Németh <[email protected]>

Eliminate the following sparse warnings (see "make C=1"):
* v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
* v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y

---
../../m5602_s5k4aa_dubious.patch

linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c +2 -2
diff -r f5662ce08663 linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
@@ -527,7 +527,7 @@
 	err = m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	if (err < 0)
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	return err;
 }
@@ -572,7 +572,7 @@
 	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	if (err < 0)
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	return err;
 }
#1 lore raw
Quoted 23 lines · On Fri, 11 Dec 2009 22:33:36 +0100 Németh Márton <[email protected]> wrote:

From: Márton Németh <[email protected]>

Eliminate the following sparse warnings (see "make C=1"):
* v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
* v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y

---
../../m5602_s5k4aa_dubious.patch
diff -r f5662ce08663 linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
11 09:53:41 2009 +0100 +++
b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err = m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0) return err;

linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c +1 -1
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	return err;
 }

linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c line 578

Quoted 8 lines
linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c +1 -1
@@ -572,7 +572,7 @@
 	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	if (err < 0)
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	return err;
 }

Thanks, but I fixed it in an other way.

Regards.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#2 lore raw
Quoted 28 lines · Jean-Francois Moine
Quoted 25 lines · On Fri, 11 Dec 2009 22:33:36 +0100 Németh Márton <[email protected]> wrote:

From: Márton Németh <[email protected]>

Eliminate the following sparse warnings (see "make C=1"):
* v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
* v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y

---
../../m5602_s5k4aa_dubious.patch
diff -r f5662ce08663 linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
11 09:53:41 2009 +0100 +++
b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err = m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0) return err;

linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c +1 -1
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
 	return err;
 }
@@ -572,7 +572,7 @@
 	err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	if (err < 0)
Quoted 8 lines

linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c line 578

Quoted 6 lines
linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c +1 -1
 		return err;
-	data = (data & 0xfe) | !val;
+	data = (data & 0xfe) | (val ? 0 : 1);
 	err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
 	return err;
 }

Thanks, but I fixed it in an other way.

No problem as long as the warning message is removed.

Regards,

Márton Németh