Skip to contentSkip to conversation

fb/intelfb: Do not depend on EMBEDDED

PATCH In review Jean Delvare 2 participants 2 messages Dec 12, 2009 – Dec 13, 2009 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fb/intelfb: Do not depend on EMBEDDED

I am worried that the intelfb driver depends on EMBEDDED. I consider this an abuse of the EMBEDDED configuration option, which as I understand it was originally meant to expose fine-tuning options, rather than to arbitrarily disable drivers when not selected.

So I suggest that we drop this dependency now.

Cc Jesse Barnes <[email protected]>
Cc Dave Airlie <[email protected]>

---
Jesse, in the original commit, you wrote that intelfb was "really a special purpose embedded driver". It looks like a perfectly standard framebuffer driver to me, which means that it may have users beyond embedded. For example I always prefer framebuffer over X for my servers. Or am I missing something and intelfb is really special?

 drivers/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/Kconfig +1 -1
@@ -1121,7 +1121,7 @@ config FB_CARILLO_RANCH
 
 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G/915G/945G/945GM/965G/965GM support (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL && EMBEDDED
+	depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
Signature · 2 lines
Jean Delvare
Suse L3
#1 lore raw
Quoted 5 lines

I am worried that the intelfb driver depends on EMBEDDED. I consider this an abuse of the EMBEDDED configuration option, which as I understand it was originally meant to expose fine-tuning options, rather than to arbitrarily disable drivers when not selected.

Since we merged a kms driver for Intel hw that supports all intel chipsets and more importantly all the outputs on Intel chipsets, intelfb should be considered legacy at the least and broken on > 50% of intel hw.

We left it in in that most ppl who wanted it were using it in embedded configs, whereas for most users it just doesn't work, like I don't thinkit supports LVDS which means loading it on a laptop will trash it.

Dave

Quoted 29 lines

So I suggest that we drop this dependency now.

Cc Jesse Barnes <[email protected]>
Cc Dave Airlie <[email protected]>

---
Jesse, in the original commit, you wrote that intelfb was "really a special purpose embedded driver". It looks like a perfectly standard framebuffer driver to me, which means that it may have users beyond embedded. For example I always prefer framebuffer over X for my servers. Or am I missing something and intelfb is really special?

 drivers/video/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/Kconfig +1 -1
@@ -1121,7 +1121,7 @@ config FB_CARILLO_RANCH
 
 config FB_INTEL
 	tristate "Intel 830M/845G/852GM/855GM/865G/915G/945G/945GM/965G/965GM support (EXPERIMENTAL)"
-	depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL && EMBEDDED
+	depends on EXPERIMENTAL && FB && PCI && X86 && AGP_INTEL
 	select FB_MODE_HELPERS
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA