OMAP3: Fix omap3_defconfig build
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 4 lines · Anand
Select sound codecs to allow this defconfig to build again
Also, sync up this defconfig with the generated .configs.
Quoted 8 lines
Signed-off-by Anand Gadiyar <[email protected]>Cc Olof Johansson <[email protected]>---
In addition to this, I needed this patch:
<http://patchwork.kernel.org/patch/65152/>With these two patches, I can build and boot on multiple omap3 boards.
And additionally, with these sound options enabled, I get the following warning on a 3430 SDP:
[ 36.303894] ------------[ cut here ]------------ [ 36.308807] WARNING: at drivers/gpio/gpiolib.c:1288 __gpio_get_value+0x30/0x5c() [ 36.316467] Modules linked in: [ 36.319610] [<c003b7e8>] (unwind_backtrace+0x0/0xdc) from [<c0065c64>] (warn_slowpath_common+0x48/0x60) [ 36.329345] [<c0065c64>] (warn_slowpath_common+0x48/0x60) from [<c0204964>] (__gpio_get_value+0x30/0x5c) [ 36.339141] [<c0204964>] (__gpio_get_value+0x30/0x5c) from [<c033d968>] (snd_soc_jack_gpio_detect+0x34/0x7c) [ 36.349334] [<c033d968>] (snd_soc_jack_gpio_detect+0x34/0x7c) from [<c007b2c0>] (worker_thread+0x21c/0x304) [ 36.359375] [<c007b2c0>] (worker_thread+0x21c/0x304) from [<c007ea8c>] (kthread+0x80/0x88) [ 36.368011] [<c007ea8c>] (kthread+0x80/0x88) from [<c0036964>] (kernel_thread_exit+0x0/0x8) [ 36.376647] ---[ end trace 9745011b5c1147df ]---
I haven't had a chance to look at this yet. I'll give it a shot tomorrow, unless someone beats me to it.
- Anand
Hi,
{removing invalid lkml-like addressee}
Quoted 1 line · Anand Gadiyar
Select sound codecs to allow this defconfig to build again
You need to fix the config option dependencies/selects, updating the defconfig just papers over the real problem.
Quoted 1 line
Also, sync up this defconfig with the generated .configs.
Good idea, but I suggest holding off until the merge window has closed since there are still new options going in. Doing a respin after -rc2 or so makes more sense. So please redo in a few weeks?
Traditionally Linus hasn't minded pulling in defconfig updates a little later in the release cycles.
Thanks,
-Olof
Quoted 10 lines · Olof Johansson
Hi,
{removing invalid lkml-like addressee}
Quoted 1 line · Anand Gadiyar
Select sound codecs to allow this defconfig to build again
You need to fix the config option dependencies/selects, updating the defconfig just papers over the real problem.
Quoted 8 lines
Quoted 1 line
Also, sync up this defconfig with the generated .configs.
Good idea, but I suggest holding off until the merge window has closed since there are still new options going in. Doing a respin after -rc2 or so makes more sense. So please redo in a few weeks?
Traditionally Linus hasn't minded pulling in defconfig updates a little later in the release cycles.
This sounds like a good plan. Let's plan on doing a round of defconfig updates later on during the merge cycle.
Regards,
Tony