Skip to contentSkip to conversation

Remove whitespace style errors

PATCH In review Sven Eckelmann 2 participants 2 messages Dec 10, 2009 – Dec 14, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 Remove whitespace style errors

checkpatch.pl found different smaller errors regarding trailing whitespaces or trailing extra newlines before EOF. These should be removed to follow linux-2.6 CodingStyle.

---
 batman-adv-kernelland/CHANGELOG    |    2 +-
 batman-adv-kernelland/originator.c |    2 --
 batman-adv-kernelland/originator.h |    1 -
 batman-adv-kernelland/proc.c       |    2 --
 batman-adv-kernelland/routing.c    |    1 -
 batman-adv-kernelland/routing.h    |    6 +++---
 batman-adv-kernelland/vis.c        |    1 -
 7 files changed, 4 insertions(+), 11 deletions(-)
batman-adv-kernelland/CHANGELOG +1 -1
index 18d82f5..8a18163 100644
@@ -19,7 +19,7 @@ batman-adv 0.1:
 * support latest kernels (2.6.20 - 2.6.28)
 * LOTS of cleanup: locking, stack usage, memory leaks
 * Change Ethertype from 0x0842 to 0x4305
-  unregistered at IEEE, if you want to sponsor an official Ethertype ($2500) 
+  unregistered at IEEE, if you want to sponsor an official Ethertype ($2500)
   please contact us
 
  -- Sun, 28 Dec 2008 00:44:31 +0100
batman-adv-kernelland/originator.c +0 -2
index 9962af7..80106f7 100644
@@ -239,5 +239,3 @@ void purge_orig(struct work_struct *work)
 
 	start_purge_timer();
 }
-
-
batman-adv-kernelland/originator.h +0 -1
index 6ef7a05..c1a9c2d 100644
@@ -28,4 +28,3 @@ struct orig_node *get_orig_node(uint8_t *addr);
 struct neigh_node *
 create_neighbor(struct orig_node *orig_node, struct orig_node *orig_neigh_node,
 		uint8_t *neigh, struct batman_if *if_incoming);
-
batman-adv-kernelland/proc.c +0 -2
index ed4c734..f476d9c 100644
@@ -827,5 +827,3 @@ int setup_procfs(void)
 
 	return 0;
 }
-
-
batman-adv-kernelland/routing.c +0 -1
index f4be6be..2873468 100644
@@ -1063,4 +1063,3 @@ void batman_data_ready(struct sock *sk, int len)
 	atomic_set(&data_ready_cond, 1);
 	wake_up_interruptible(&thread_wait);
 }
-
batman-adv-kernelland/routing.h +3 -3
index 985728f..890a4f5 100644
@@ -27,9 +27,9 @@ extern atomic_t exit_cond;
 void slide_own_bcast_window(struct batman_if *batman_if);
 void batman_data_ready(struct sock *sk, int len);
 int packet_recv_thread(void *data);
-void receive_bat_packet(struct ethhdr *ethhdr, 
-				struct batman_packet *batman_packet, 
-				unsigned char *hna_buff, int hna_buff_len, 
+void receive_bat_packet(struct ethhdr *ethhdr,
+				struct batman_packet *batman_packet,
+				unsigned char *hna_buff, int hna_buff_len,
 				struct batman_if *if_incoming);
 void update_routes(struct orig_node *orig_node,
 				struct neigh_node *neigh_node,
batman-adv-kernelland/vis.c +0 -1
index cdb8aab..c26d48c 100644
@@ -559,4 +559,3 @@ static void start_vis_timer(void)
 	queue_delayed_work(bat_event_workqueue, &vis_timer_wq,
 			   (atomic_read(&vis_interval)/1000) * HZ);
 }
-
Signature · 1 line
1.6.5.4
#2 lore raw

Hello Sven,

thank you for your patch, i applied it in svn revision r1494.

Quoted 100 lines · Sven Eckelmann

checkpatch.pl found different smaller errors regarding trailing whitespaces or trailing extra newlines before EOF. These should be removed to follow linux-2.6 CodingStyle.

---
 batman-adv-kernelland/CHANGELOG    |    2 +-
 batman-adv-kernelland/originator.c |    2 --
 batman-adv-kernelland/originator.h |    1 -
 batman-adv-kernelland/proc.c       |    2 --
 batman-adv-kernelland/routing.c    |    1 -
 batman-adv-kernelland/routing.h    |    6 +++---
 batman-adv-kernelland/vis.c        |    1 -
 7 files changed, 4 insertions(+), 11 deletions(-)
batman-adv-kernelland/CHANGELOG +1 -1
index 18d82f5..8a18163 100644
@@ -19,7 +19,7 @@ batman-adv 0.1:
 * support latest kernels (2.6.20 - 2.6.28)
 * LOTS of cleanup: locking, stack usage, memory leaks
 * Change Ethertype from 0x0842 to 0x4305
-  unregistered at IEEE, if you want to sponsor an official Ethertype ($2500) 
+  unregistered at IEEE, if you want to sponsor an official Ethertype ($2500)
   please contact us
 
  -- Sun, 28 Dec 2008 00:44:31 +0100
batman-adv-kernelland/originator.c +0 -2
index 9962af7..80106f7 100644
@@ -239,5 +239,3 @@ void purge_orig(struct work_struct *work)
 
 	start_purge_timer();
 }
-
-
batman-adv-kernelland/originator.h +0 -1
index 6ef7a05..c1a9c2d 100644
@@ -28,4 +28,3 @@ struct orig_node *get_orig_node(uint8_t *addr);
 struct neigh_node *
 create_neighbor(struct orig_node *orig_node, struct orig_node *orig_neigh_node,
 		uint8_t *neigh, struct batman_if *if_incoming);
-
batman-adv-kernelland/proc.c +0 -2
index ed4c734..f476d9c 100644
@@ -827,5 +827,3 @@ int setup_procfs(void)
 
 	return 0;
 }
-
-
batman-adv-kernelland/routing.c +0 -1
index f4be6be..2873468 100644
@@ -1063,4 +1063,3 @@ void batman_data_ready(struct sock *sk, int len)
 	atomic_set(&data_ready_cond, 1);
 	wake_up_interruptible(&thread_wait);
 }
-
batman-adv-kernelland/routing.h +3 -3
index 985728f..890a4f5 100644
@@ -27,9 +27,9 @@ extern atomic_t exit_cond;
 void slide_own_bcast_window(struct batman_if *batman_if);
 void batman_data_ready(struct sock *sk, int len);
 int packet_recv_thread(void *data);
-void receive_bat_packet(struct ethhdr *ethhdr, 
-				struct batman_packet *batman_packet, 
-				unsigned char *hna_buff, int hna_buff_len, 
+void receive_bat_packet(struct ethhdr *ethhdr,
+				struct batman_packet *batman_packet,
+				unsigned char *hna_buff, int hna_buff_len,
 				struct batman_if *if_incoming);
 void update_routes(struct orig_node *orig_node,
 				struct neigh_node *neigh_node,
batman-adv-kernelland/vis.c +0 -1
index cdb8aab..c26d48c 100644
@@ -559,4 +559,3 @@ static void start_vis_timer(void)
 	queue_delayed_work(bat_event_workqueue, &vis_timer_wq,
 			   (atomic_read(&vis_interval)/1000) * HZ);
 }
-
Signature · 6 lines
1.6.5.4

_______________________________________________
B.A.T.M.A.N mailing list
[email protected]
https://lists.open-mesh.net/mm/listinfo/b.a.t.m.a.n