Skip to contentSkip to conversation

PATCH- gspca: added chipset revision sensor

PATCH Luis Maia 3 participants 7 messages Dec 15, 2009 – Dec 16, 2009 Media (V4L/DVB)

lore
Share & tools
lore

Luis Maia

author
#0 lore raw

Hello,

Added extra chipset revision (sensor) to fix camera zc0301 with ID: 0ac8:301b . Since i own one of this cameras fixed and tested it.

Best Regards,
Luis Maia

-------------

drivers/media/video/gspca/zc3xx.c 2009-12-15 02:42:13.000000000 +0000 renamed from drivers/media/video/gspca/zc3xx.c 2009-12-14 17:47:25.000000000 +0000 +1 -0
diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
@@ -6868,6 +6868,7 @@
    {0x8001, 0x13},
    {0x8000, 0x14},        /* CS2102K */
    {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},

};

static int vga_3wr_probe(struct gspca_dev *gspca_dev) @@ -7634,7 +7635,7 @@

    {USB_DEVICE(0x0698, 0x2003)},
    {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
    {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
    {USB_DEVICE(0x0ac8, 0x303b)},
    {USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250},
    {USB_DEVICE(0x0ac8, 0x307b)},
drivers/media/video/gspca/zc3xx.c +2 -1
diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
@@ -6868,6 +6868,7 @@
 	{0x8001, 0x13},
 	{0x8000, 0x14},		/* CS2102K */
 	{0x8400, 0x15},		/* TAS5130K */
+	{0xe400, 0x15},
 };
 
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)
@@ -7634,7 +7635,7 @@
 	{USB_DEVICE(0x0698, 0x2003)},
 	{USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
 	{USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-	{USB_DEVICE(0x0ac8, 0x301b)},
+	{USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
 	{USB_DEVICE(0x0ac8, 0x303b)},
 	{USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250},
 	{USB_DEVICE(0x0ac8, 0x307b)},
#1 lore raw
Quoted 21 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with ID:
0ac8:301b .
Since i own one of this cameras fixed and tested it.

-------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 2009-12-14
17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
drivers/media/video/gspca/zc3xx.c +1 -0
@@ -6868,6 +6868,7 @@
     {0x8001, 0x13},
     {0x8000, 0x14},        /* CS2102K */
     {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };
 
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

drivers/media/video/gspca/zc3xx.c line 7641

Quoted 8 lines
drivers/media/video/gspca/zc3xx.c +1 -1
@@ -7634,7 +7635,7 @@
     {USB_DEVICE(0x0698, 0x2003)},
     {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
     {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
     {USB_DEVICE(0x0ac8, 0x303b)},
     {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
 SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis,

I don't understand your patch:
1) you added 0xe400 in the chipset table giving the sensor tas5130c K
2) in the device table you say that the 0ac8:301b sensor is a pb0330 (but this information is not used: the sensor type in .driver_info may be only pas106 for sif probe or mc501cb/tas5130_vf0250 for no probe.

What is exactly the sensor of your webcam?

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#2 lore raw

Jean,
let me know , if you need to the test this patch, since i added the tas1530k long time ago, and still have the webcam :) Best Regards

Quoted 52 lines · Jean-Francois Moine
Quoted 27 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with  ID:
0ac8:301b .
Since i own one of this cameras fixed and tested it.

-------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c --- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c    2009-12-14 17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
(quoted diff) +0 -0
@@ -6868,6 +6868,7 @@
      {0x8001, 0x13},

     {0x8000, 0x14},        /* CS2102K */
     {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };

 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

drivers/media/video/gspca/zc3xx.c +1 -1
@@ -7634,7 +7635,7 @@
      {USB_DEVICE(0x0698, 0x2003)},
      {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
      {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
      {USB_DEVICE(0x0ac8, 0x303b)},
Quoted 2 lines

     {USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis,

I don't understand your patch:
1) you added 0xe400 in the chipset table giving the sensor tas5130c K
2) in the device table you say that the 0ac8:301b sensor is a pb0330 (but this information is not used: the sensor type in .driver_info may be only pas106 for sif probe or mc501cb/tas5130_vf0250 for no probe.

What is exactly the sensor of your webcam?

--
Ken ar c'hentañ |             ** Breizh ha Linux atav! **
Jef             |               http://moinejf.free.fr/
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 29 lines · On Tue, 15 Dec 2009 10:25:29 -0300 leandro Costantino <[email protected]>…

Jean,
let me know , if you need to the test this patch, since i added the tas1530k long time ago, and still have the webcam :) Best Regards

Quoted 22 lines · Jean-Francois Moine
Quoted 19 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with
 ID: 0ac8:301b .
Since i own one of this cameras fixed and tested it.

-------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c --- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c    2009-12-14 17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
(quoted diff) +0 -0
@@ -6868,6 +6868,7 @@
      {0x8001, 0x13},

     {0x8000, 0x14},        /* CS2102K */
     {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

drivers/media/video/gspca/zc3xx.c +1 -1
@@ -7634,7 +7635,7 @@
      {USB_DEVICE(0x0698, 0x2003)},
      {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
      {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
      {USB_DEVICE(0x0ac8, 0x303b)},

     {USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis and Leandro,

Thanks for the patch. Luis said his sensor is the tas5130K, so the 2nd part of the patch is useless. But, maybe, Leandro, have you heard about other chipset revision IDs?

Best regards.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
author
#4 lore raw

I found an email that discussed the similar problem that my camera had, showing up just a black screen, it's dated but i think maybe it wasn't fully solved because there's no answer.

http://osdir.com/ml/drivers.spca50x.devel/2006-11/msg00036.html

Note the : ">/ > /Vimicro/zc3xx.h: [zcxx_probeSensor:307] sensor 3w Vga ??? 0xC400"

/Do you know if this was solved?!
Because i suspect that maybe there are more 0x?400 revision of the chipset. Btw, if this is a pattern could we consider to mask the bits in retword (retword &= 0x0FFF)? Because looking at the current table it seems to make more sense.

Best regards,
Luis Maia.

Quoted 56 lines · Jean-Francois Moine
Quoted 31 lines · On Tue, 15 Dec 2009 10:25:29 -0300 leandro Costantino <[email protected]>…

Jean,
let me know , if you need to the test this patch, since i added the tas1530k long time ago, and still have the webcam :) Best Regards

Quoted 23 lines · Jean-Francois Moine
Quoted 19 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with
ID: 0ac8:301b .
Since i own one of this cameras fixed and tested it.

-------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 2009-12-14
17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
drivers/media/video/gspca/zc3xx.c +1 -0
@@ -6868,6 +6868,7 @@
     {0x8001, 0x13},
     {0x8000, 0x14},        /* CS2102K */
     {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };
 
Quoted 11 lines
Quoted 11 lines

drivers/media/video/gspca/zc3xx.c line 7641

Quoted 11 lines
drivers/media/video/gspca/zc3xx.c +1 -1
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)
@@ -7634,7 +7635,7 @@
     {USB_DEVICE(0x0698, 0x2003)},
     {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
     {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
     {USB_DEVICE(0x0ac8, 0x303b)},
     {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
 SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis and Leandro,

Thanks for the patch. Luis said his sensor is the tas5130K, so the 2nd part of the patch is useless. But, maybe, Leandro, have you heard about other chipset revision IDs?

Best regards.

#5 lore raw

Actually, i have not heard of other chipset's revision about task1530k since 2008 (http://article.gmane.org/gmane.linux.drivers.spca50x.devel/2826
)
But it's possible that , there will be many others cam using that.

Luis, in fact there seem's to be a pattern against revision & chipset id -> sensor, but actually, i cannot assure that there'nt an exception. Jean, should decide on that :)

pd: Jean, I am waiting for the user that was doing the patch for the t613 against a new sensor... :)

Best Regards

Quoted 79 lines · Luis Maia

I found an email that discussed the similar problem that my camera had, showing up just a black screen, it's dated but  i think maybe it wasn't fully solved because there's no answer.

http://osdir.com/ml/drivers.spca50x.devel/2006-11/msg00036.html

Note the : ">/ > /Vimicro/zc3xx.h: [zcxx_probeSensor:307] sensor 3w Vga ??? 0xC400"

/Do you know if this was solved?!
Because i suspect that maybe there are more 0x?400 revision of the chipset. Btw, if this is a pattern could we consider to mask the bits in retword (retword &= 0x0FFF)?
Because looking at the current table it seems to make more sense.

Best regards,
Luis Maia.

Quoted 59 lines · Jean-Francois Moine
Quoted 33 lines · On Tue, 15 Dec 2009 10:25:29 -0300 leandro Costantino <[email protected]>…

Jean,
let me know , if you need to the test this patch, since i added the tas1530k long time ago, and still have the webcam :) Best Regards

Quoted 24 lines · Jean-Francois Moine
Quoted 19 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with
 ID: 0ac8:301b .
Since i own one of this cameras fixed and tested it.
       -------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c --- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c    2009-12-14 17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
(quoted diff) +0 -0
@@ -6868,6 +6868,7 @@
     {0x8001, 0x13},

    {0x8000, 0x14},        /* CS2102K */
    {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };

Quoted 11 lines
Quoted 11 lines
Quoted 11 lines

 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

drivers/media/video/gspca/zc3xx.c +1 -1
@@ -7634,7 +7635,7 @@
     {USB_DEVICE(0x0698, 0x2003)},
     {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
     {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
     {USB_DEVICE(0x0ac8, 0x303b)},

    {USB_DEVICE(0x0ac8, 0x305b), .driver_info = SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis and Leandro,

Thanks for the patch. Luis said his sensor is the tas5130K, so the 2nd part of the patch is useless. But, maybe, Leandro, have you heard about other chipset revision IDs?

Best regards.

author
#6 lore raw
In reply to Jean-Francois Moine
Quoted 37 lines · Jean-Francois Moine
Quoted 22 lines · On Tue, 15 Dec 2009 03:45:00 +0000 Luis Maia <[email protected]> wrote:

Added extra chipset revision (sensor) to fix camera zc0301 with ID: 0ac8:301b . Since i own one of this cameras fixed and tested it.

-------------

diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
--- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 2009-12-14
17:47:25.000000000 +0000
+++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c

2009-12-15 02:42:13.000000000 +0000
drivers/media/video/gspca/zc3xx.c +1 -0
@@ -6868,6 +6868,7 @@
     {0x8001, 0x13},
     {0x8000, 0x14},        /* CS2102K */
     {0x8400, 0x15},        /* TAS5130K */
+    {0xe400, 0x15},
 };
 
 static int vga_3wr_probe(struct gspca_dev *gspca_dev)

drivers/media/video/gspca/zc3xx.c line 7641

Quoted 8 lines
drivers/media/video/gspca/zc3xx.c +1 -1
@@ -7634,7 +7635,7 @@
     {USB_DEVICE(0x0698, 0x2003)},
     {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
     {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
-    {USB_DEVICE(0x0ac8, 0x301b)},
+    {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
     {USB_DEVICE(0x0ac8, 0x303b)},
     {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
 SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},

Hello Luis,

Quoted 10 lines

I don't understand your patch:
1) you added 0xe400 in the chipset table giving the sensor tas5130c K
2) in the device table you say that the 0ac8:301b sensor is a pb0330 (but this information is not used: the sensor type in .driver_info may be only pas106 for sif probe or mc501cb/tas5130_vf0250 for no probe.

What is exactly the sensor of your webcam?

Sensor for my webcam is tas5130K, sorry my bad .i forgot to remove the line from .driver_info and didn't noticed. Thus correct information is on the device table.
I bought a pack of webcams from the same suplier with same model for friends, i'm waiting for feedback from the patch.