Skip to contentSkip to conversation

qemu-kvm: fix infinite recursion in pci

PATCH Applied Michael S. Tsirkin 2 participants 2 messages Dec 15, 2009 – Dec 17, 2009 KVM

lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

Make config reads for assigned devices work like they used to: both pci_default_read_config and pci_default_cap_read_config call to pci_read_config, which does the actual work.

This fixes infinite recursion introduced by
recent merge from stable-0.12.

Signed-off-by Michael S. Tsirkin <[email protected]>
Reported-by Hannes Reinecke <[email protected]>
Tested-by Hannes Reinecke <[email protected]>

---

hw/pci.c +12 -5
index 110a5fc..a74d3d4 100644
@@ -1016,19 +1016,26 @@ static void pci_update_irq_disabled(PCIDevice *d, int was_irq_disabled)
     }
 }
 
+static uint32_t pci_read_config(PCIDevice *d,
+                                uint32_t address, int len)
+{
+    uint32_t val = 0;
+
+    len = MIN(len, pci_config_size(d) - address);
+    memcpy(&val, d->config + address, len);
+    return le32_to_cpu(val);
+}
+
 uint32_t pci_default_read_config(PCIDevice *d,
                                  uint32_t address, int len)
 {
-    uint32_t val = 0;
     assert(len == 1 || len == 2 || len == 4);
 
     if (pci_access_cap_config(d, address, len)) {
         return d->cap.config_read(d, address, len);
     }
 
-    len = MIN(len, pci_config_size(d) - address);
-    memcpy(&val, d->config + address, len);
-    return le32_to_cpu(val);
+    return pci_read_config(d, address, len);
 }
 
 static void pci_write_config(PCIDevice *pci_dev,

@@ -1052,7 +1059,7 @@ int pci_access_cap_config(PCIDevice *pci_dev, uint32_t address, int len)
 uint32_t pci_default_cap_read_config(PCIDevice *pci_dev,
                                      uint32_t address, int len)
 {
-    return pci_default_read_config(pci_dev, address, len);
+    return pci_read_config(pci_dev, address, len);
 }
 
 void pci_default_cap_write_config(PCIDevice *pci_dev,
Applied
#1 lore raw
Quoted 9 lines · Michael S. Tsirkin

Make config reads for assigned devices work like they used to: both pci_default_read_config and pci_default_cap_read_config call to pci_read_config, which does the actual work.

This fixes infinite recursion introduced by
recent merge from stable-0.12.

Applied to master and 0.12, thanks.

Signature · 1 line
error compiling committee.c: too many arguments to function