x86, amd: Get multi-node CPU info from NodeId MSR instead of PCI config space
That's nice. It should be in the code, not in the commit message.
Quoted 4 lines · Borislav Petkov
Quoted 3 lines · Ingo Molnar
* Andreas Herrmann <[email protected]> wrote:
Quoted 18 lines
Quoted 4 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ rdmsrl(0xc001100c, value);Dont we want some nice, meaningfully named symbolic constant here, instead of
0xc001100c?The MSR name is actually in the commit msg, maybe something like
MSR_F10H_NODE_ID.Signature · 8 lines
Regards/Gruss, Boris. Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
--
Sent from my mobile phone. Please excuse any lack of formatting.
Quoted 1 line · H. Peter Anvin
That's nice. It should be in the code, not in the commit message.
I'm pretty sure it'll land there tomorrow :).
Signature · 8 lines
Regards/Gruss, Boris. Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632