powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
Subsystems (2)
PATCH 1/1 powerpc/85xx: Fix oops during MSI driver probe on MPC85xxMDS boards
MPC85xx chips report the wrong value in feature reporting register, and that causes the following oops:
Unable to handle kernel paging request for data at address 0x00000c00 Faulting instruction address: 0xc0019294 Oops: Kernel access of bad area, sig: 11 [#1] MPC8569 MDS Modules linked in: [...] NIP [c0019294] mpic_set_irq_type+0x2f0/0x368 LR [c0019124] mpic_set_irq_type+0x180/0x368 Call Trace: [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable) [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4 [ef851db0] [c007b550] set_irq_type+0x40/0x7c [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114 [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40 [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328 [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84 [...]
This is because mpic_alloc() assigns wrong values to mpic->isu_{size,shift,mask}, and things eventually break when _mpic_irq_read() is trying to use them.
This patch fixes the issue by enabling MPIC_BROKEN_FRR_NIRQS quirk.
--- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
arch/powerpc/platforms/85xx/mpc85xx_mds.c +2 -1
@@ -338,7 +338,8 @@ static void __init mpc85xx_mds_pic_init(void) } mpic =mpic_alloc (np, r.start, -MPIC_PRIMARY |MPIC_WANTS_RESET |MPIC_BIG_ENDIAN , +MPIC_PRIMARY |MPIC_WANTS_RESET |MPIC_BIG_ENDIAN | +MPIC_BROKEN_FRR_NIRQS ,0 ,256 ," OpenPIC " );BUG_ON (mpic ==NULL );of_node_put (np);
Signature · 1 line
1.6.3.3
Quoted 21 lines · Anton Vorontsov
MPC85xx chips report the wrong value in feature reporting register, and that causes the following oops:
Unable to handle kernel paging request for data at address 0x00000c00 Faulting instruction address: 0xc0019294 Oops: Kernel access of bad area, sig: 11 [#1] MPC8569 MDS Modules linked in: [...] NIP [c0019294] mpic_set_irq_type+0x2f0/0x368 LR [c0019124] mpic_set_irq_type+0x180/0x368 Call Trace: [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable) [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4 [ef851db0] [c007b550] set_irq_type+0x40/0x7c [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114 [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40 [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328 [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84 [...]
Quoted 8 lines
This is because
mpic_alloc()assigns wrong values to mpic->isu_{size,shift,mask}, and things eventually break when_mpic_irq_read()is trying to use them.This patch fixes the issue by enabling
MPIC_BROKEN_FRR_NIRQSquirk.Signed-off-by Anton Vorontsov <[email protected]>---
Kumar,
Did you miss this patch or it's just in a queue for review?
Thanks!
Quoted 19 lines
arch/powerpc/platforms/85xx/mpc85xx_mds.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)arch/powerpc/platforms/85xx/mpc85xx_mds.c +2
-1@@ -338,7 +338,8 @@ static void __init mpc85xx_mds_pic_init(void) } mpic =mpic_alloc (np, r.start, -MPIC_PRIMARY |MPIC_WANTS_RESET |MPIC_BIG_ENDIAN , +MPIC_PRIMARY |MPIC_WANTS_RESET |MPIC_BIG_ENDIAN | +MPIC_BROKEN_FRR_NIRQS ,0 ,256 ," OpenPIC " );BUG_ON (mpic ==NULL );of_node_put (np);Signature · 1 line
1.6.3.3
Quoted 28 lines · Anton Vorontsov
Quoted 27 lines · Anton Vorontsov
MPC85xx chips report the wrong value in feature reporting register, and that causes the following oops:
Unable to handle kernel paging request for data at address 0x00000c00 Faulting instruction address: 0xc0019294 Oops: Kernel access of bad area, sig: 11 [#1] MPC8569 MDS Modules linked in: [...] NIP [c0019294] mpic_set_irq_type+0x2f0/0x368 LR [c0019124] mpic_set_irq_type+0x180/0x368 Call Trace: [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable) [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4 [ef851db0] [c007b550] set_irq_type+0x40/0x7c [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114 [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40 [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328 [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84[...]
This is because
mpic_alloc()assigns wrong values to mpic->isu_{size,shift,mask}, and things eventually break when_mpic_irq_read()is trying to use them.This patch fixes the issue by enabling
MPIC_BROKEN_FRR_NIRQSquirk.
Quoted 8 lines
Quoted 2 lines
Signed-off-by Anton Vorontsov <[email protected]>---
Kumar,
Did you miss this patch or it's just in a queue for review?
Thanks!
I just missed it will pick it up in a merge request to benh/linus.
- k
Kumar Gala
AppliedQuoted 25 lines · Anton Vorontsov
MPC85xx chips report the wrong value in feature reporting register, and that causes the following oops:
Unable to handle kernel paging request for data at address 0x00000c00 Faulting instruction address: 0xc0019294 Oops: Kernel access of bad area, sig: 11 [#1] MPC8569 MDS Modules linked in: [...] NIP [c0019294] mpic_set_irq_type+0x2f0/0x368 LR [c0019124] mpic_set_irq_type+0x180/0x368 Call Trace: [ef851d60] [c0019124] mpic_set_irq_type+0x180/0x368 (unreliable) [ef851d90] [c007958c] __irq_set_trigger+0x44/0xd4 [ef851db0] [c007b550] set_irq_type+0x40/0x7c [ef851dc0] [c0004a60] irq_create_of_mapping+0xb4/0x114 [ef851df0] [c0004af0] irq_of_parse_and_map+0x30/0x40 [ef851e20] [c0405678] fsl_of_msi_probe+0x1a0/0x328 [ef851e60] [c02e6438] of_platform_device_probe+0x5c/0x84[...]
This is because
mpic_alloc()assigns wrong values to mpic->isu_{size,shift,mask}, and things eventually break when_mpic_irq_read()is trying to use them.
Quoted 6 lines
This patch fixes the issue by enabling
MPIC_BROKEN_FRR_NIRQSquirk.Signed-off-by Anton Vorontsov <[email protected]>---
arch/powerpc/platforms/85xx/mpc85xx_mds.c| 3 ++-1 files changed, 2 insertions(+), 1 deletions(-)
applied to merge for 2.6.33
- k