Skip to contentSkip to conversation

Dock OOPSing with recent acpi-test

DISCUSSION Len Brown 3 participants 4 messages Dec 16, 2009 2 messages not in the archive ACPI

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Len Brown

author reviewer
#1 lore raw
Quoted 2 lines · Dmitry Torokhov

The day before yesterday pull from acpi-test + Linux's tip produces the following oops in the dock driver (see screenshot).

Dmitry, do you still see this?
If you build with drivers/acpi/dock.c from 2.6.32 does it go away?

thanks,
-Len

#2 lore raw

* Len Brown <[email protected]>:

Quoted 7 lines · Dmitry Torokhov
Quoted 3 lines

The day before yesterday pull from acpi-test + Linux's tip produces the following oops in the dock driver (see screenshot).

Dmitry, do you still see this?
If you build with drivers/acpi/dock.c from 2.6.32 does it go away?

I figured out what the issue was:

http://www.spinics.net/lists/linux-acpi/msg25223.html

+static int
+add_dock_dependent_device(acpi_handle handle, struct dock_station *ds)

...

+ if (tmp == ds->handle)
+ add_dock_dependent_device(ds, handle);

...

+ ret = add_dock_dependent_device(dock_station, handle);
+ if (ret)
goto err_rmgroup;

I wrote the function signature one way, but called it a different way. How odd, I never got a compiler type warning (that I can recall).

Queueing up a patch for Len now.

Sorry about that.
/ac

author reviewer
#3 lore raw
Quoted 2 lines

Queueing up a patch for Len now.

fixed merged into new version of this patch

commit f69cfdd24ac40ab7bbd00d6ad85e003da755e3a0

Author: Alex Chiang <[email protected]>
Date:   Mon Oct 19 15:14:29 2009 -0600

ACPI: dock: combine add|alloc_dock_dependent_device (v2)

which is in the current acpi tree's dock, release, and test branches.

thanks,
-Len Brown, Intel Open Source Technology Center

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

[ Resending because I somehow managed to drop Len and acpi
list off the recipent list, but I believe Alex already found the root of the problem...]

Quoted 9 lines · Alex Chiang

* Len Brown <[email protected]>:

Quoted 7 lines · Dmitry Torokhov
Quoted 3 lines

The day before yesterday pull from acpi-test + Linux's tip produces the following oops in the dock driver (see screenshot).

Dmitry, do you still see this?
If you build with drivers/acpi/dock.c from 2.6.32 does it go away?

Quoted 9 lines

btw, Dmitry, I'm very sorry that I didn't respond earlier. I didn't even know about this oops until lenb poked me on irc just tonight.

It never landed in my inbox, and upon checking the mail archives, it never landed there either. :(

Are you still seeing the issue with latest 2.6.32?

I dropped acpi-test from my working tree for now but I have never seen it in mainline (unless you pushed something new in last coupe of days). 2.6.32 is definitely clean.

Signature · 1 line
Dmitry