Skip to contentSkip to conversation

SYSCTL: Fix sysctl breakage on systems with older glibc

PATCH In review Andi Kleen 3 participants 5 messages Dec 16, 2009 – Dec 17, 2009 Proc sysctl

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 SYSCTL: Fix sysctl breakage on systems with older glibc

SYSCTL: Fix breakage on systems with older glibc

As predicted during code review, the sysctl(2) changes made systems with old glibc nearly unusable. About every command gives a:

warning: process `ls' used the deprecated sysctl s ystem call with 1.4

warning in the log.

I see this on a SUSE 10.0 system with glibc 2.3.5. Don't warn for this common case.

kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +7 -0
diff -u linux-2.6.32-git12/kernel/sysctl_binary.c-o linux-2.6.32-git12/kernel/sysctl_binary.c
@@ -1399,6 +1399,13 @@
 {
 	int i;
 
+	/* 
+	 * CTL_KERN/KERN_VERSION is used by older glibc and cannot 
+	 * ever go away.
+	 */
+	if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+		return;
+
 	if (printk_ratelimit()) {
 		printk(KERN_INFO
 			"warning: process `%s' used the deprecated sysctl "
#1 lore raw
Quoted 8 lines · Andi Kleen

SYSCTL: Fix breakage on systems with older glibc

the sysctl(2) changes made systems
with old glibc nearly unusable. About every command gives a:

warning: process `ls' used the deprecated sysctl s ystem call with 1.4

warning in the log.

I cranked the level of warning up at least in part to see what the reaction would be. If it makes logging in and manually using the machine unbearable on systems with versions of glibc from days of yore, the level of logging is too high.

Quoted 2 lines

I see this on a SUSE 10.0 system with glibc 2.3.5. Don't warn for this common case.

Perhaps it is just my sample of the world but glibc < 2.5 isn't common, especially on machines that I am putting new kernels on. Equally machines with 3+ year old installs are rare.

kernel/sysctl_binary.c line 1405

Quoted 13 lines

diff -u linux-2.6.32-git12/kernel/sysctl_binary.c-o linux-2.6.32-git12/kernel/sysctl_binary.c

kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +4 -0
@@ -1399,6 +1399,13 @@
 {
 	int i;
 
+	/* 
+	 * CTL_KERN/KERN_VERSION is used by older glibc and cannot 
+	 * ever go away.
+	 */

The comment is wrong. Older versions of glibc are perfectly happy getting -ENOSYS form sys_sysctl.

kernel/sysctl_binary.c line 1407

Quoted 2 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +2 -0
+	if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+		return;

If you make it printk_once for this case I think that strikes the right balance. You won't be spammed to death by messages telling you about a silly old glibc, but you will be told.

kernel/sysctl_binary.c line 1411

Quoted 3 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +0 -0
 	if (printk_ratelimit()) {
 		printk(KERN_INFO
 			"warning: process `%s' used the deprecated sysctl "

Eric

author
#2 lore raw
Quoted 3 lines · Eric W. Biederman

reaction would be. If it makes logging in and manually using the machine unbearable on systems with versions of glibc from days of yore, the level of logging is too high.

The reason I was slightly annoyed is because I flagged this during code review and it wasn't addressed before merging.

Quoted 7 lines
Quoted 3 lines

I see this on a SUSE 10.0 system with glibc 2.3.5. Don't warn for this common case.

Perhaps it is just my sample of the world but glibc < 2.5 isn't common, especially on machines that I am putting new kernels on. Equally machines with 3+ year old installs are rare.

Linux simply cannot abandon older user land. We still (near) fully support a.out executables, even on 64bit.

Quoted 10 lines
Quoted 10 lines

diff -u linux-2.6.32-git12/kernel/sysctl_binary.c-o linux-2.6.32-git12/kernel/sysctl_binary.c

kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +0 -0
@@ -1399,6 +1399,13 @@
 {
 	int i;
 
Quoted 6 lines

kernel/sysctl_binary.c line 1405

Quoted 4 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +4 -0
+	/* 
+	 * CTL_KERN/KERN_VERSION is used by older glibc and cannot 
+	 * ever go away.
+	 */

The comment is wrong. Older versions of glibc are perfectly happy getting -ENOSYS form sys_sysctl.

and it fills and fills and fills the kernel log. In practice that's not usable.

Quoted 7 lines

kernel/sysctl_binary.c line 1407

Quoted 3 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +2 -0
+	if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+		return;

If you make it printk_once for this case I think that strikes the right balance. You won't be spammed to death by messages telling you about a silly old glibc, but you will be told.

It's not a "silly old glibc", it's a "perfectly functional old glibc"

-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#3 lore raw
Quoted 7 lines · Andi Kleen
Quoted 3 lines · Eric W. Biederman

reaction would be. If it makes logging in and manually using the machine unbearable on systems with versions of glibc from days of yore, the level of logging is too high.

The reason I was slightly annoyed is because I flagged this during code review and it wasn't addressed before merging.

No, you did not flag that in the review.

You said the performance would get worse with my implementation, which is something else entirely. I did not change anything when I discovered that versions of glibc old enough to still have that code were rare enough I could not find one installed anywhere.

Quoted 9 lines
Quoted 6 lines
Quoted 2 lines

I see this on a SUSE 10.0 system with glibc 2.3.5. Don't warn for this common case.

Perhaps it is just my sample of the world but glibc < 2.5 isn't common, especially on machines that I am putting new kernels on. Equally machines with 3+ year old installs are rare.

Linux simply cannot abandon older user land. We still (near) fully support a.out executables, even on 64bit.

You think what I have done is abandonment of userland?

My position is and has been since I added the entry to Docuementation/feature-removal.txt that actual real applications that care about binary sysctls are so rare as to be practically non-existent, and that the maintenance practices of the binary sysctl interface show that we abandoned those applications long ago.

One of the signs of this abandonment of the binary sysctl interface is that no one has ever done a proper 32/64 interface for it, and we do have 4 sysctls where this actually matters.

I rewrote all of the binary sysctls in terms of their ascii counterparts so that there would be a reasonable chance that they would continue to work for as long as we need them.

So I think I have gone above and beyond in my effort to keep from abandoning the one program out there that actually cares.

As for glibc. The usage in glibc before glibc 2.5 does not count as a user space application that cares. You can return any string or -ENOSYS and glibc works fine. In addition to the fact that glibc will read from proc if sysctl(2) fails it.

Quoted 16 lines
Quoted 9 lines
Quoted 9 lines

diff -u linux-2.6.32-git12/kernel/sysctl_binary.c-o linux-2.6.32-git12/kernel/sysctl_binary.c

kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +0 -0
@@ -1399,6 +1399,13 @@
 {
 	int i;
 
Quoted 6 lines

kernel/sysctl_binary.c line 1405

Quoted 4 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +4 -0
+	/* 
+	 * CTL_KERN/KERN_VERSION is used by older glibc and cannot 
+	 * ever go away.
+	 */

The comment is wrong. Older versions of glibc are perfectly happy getting -ENOSYS form sys_sysctl.

Quoted 2 lines

and it fills and fills and fills the kernel log. In practice that's not usable.

Which is why I think a printk_once is the right solution.

Quoted 8 lines
Quoted 6 lines

kernel/sysctl_binary.c line 1407

Quoted 2 lines
kernel/sysctl_binary.c renamed from kernel/sysctl_binary.c-o +2 -0
+	if (name[0] == CTL_KERN && name[1] == KERN_VERSION)
+		return;

If you make it printk_once for this case I think that strikes the right balance. You won't be spammed to death by messages telling you about a silly old glibc, but you will be told.

It's not a "silly old glibc", it's a "perfectly functional old glibc"

It is a perfectly functional silly old glibc. It does silly things so I will call it silly. I don't intend to deliberately break it but I don't intend to encourage it's silly behavior or it's use either.

The real issue is I don't know that only glibc ever calls CTL_KERN KERN_VERSION. We have not been warning about it for years. So if there is some userspace application out there besides glibc I want to warn them.

I want to warn because for all practical purposes we abandoned sysctl(2) a long time ago. For now I have tested and verified my wrapper works. I expect my wrapper to work for the foreseeable future. However since nothing uses sysctl(2) that cares ultimately the code will bit rot and fail. I would like whatever random userspace applications are out there to have a chance to migrate to something we actually maintain before that happens.

To give that warning teeth that people will believe I have to continue to say I am going to remove sysctl. I do honestly intend in another year when the deadline rolls around to turn sysctl(2) off by default. I would be truly surprised if anyone noticed.

Eric

#4 lore raw
Quoted 4 lines · Eric W. Biederman

As for glibc. The usage in glibc before glibc 2.5 does not count as a user space application that cares. You can return any string or -ENOSYS and glibc works fine.

Annoying and pointless messages that flood your terminals etc is not "fine".

Backwards compatibility is more than "technically it still works". It's something almost sacred.

Linus