Skip to contentSkip to conversation

btusb:Prevent illtimed autosuspend

PATCH In review Oliver Neukum 4 participants 5 messages Dec 16, 2009 – Dec 17, 2009 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 btusb:Prevent illtimed autosuspend

commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a

Author: Oliver Neukum <[email protected]>
Date:   Mon Dec 14 22:09:49 2009 +0100

btusb:Prevent illtimed autosuspend

The device must be marked busy as it recieves data.

drivers/bluetooth/btusb.c +1 -0
index 4d29059..a699f09 100644
@@ -307,6 +307,7 @@ static void btusb_bulk_complete(struct urb *urb)
 		return;
 
 	usb_anchor_urb(urb, &data->bulk_anchor);
+	usb_mark_last_busy(data->udev);
 
 	err = usb_submit_urb(urb, GFP_ATOMIC);
 	if (err < 0) {
maintainer
#2 lore raw

Hi Oliver and Matthew,

Quoted 11 lines
Quoted 9 lines

commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a

Author: Oliver Neukum <[email protected]>
Date:   Mon Dec 14 22:09:49 2009 +0100

btusb:Prevent illtimed autosuspend

The device must be marked busy as it recieves data.

thanks for figuring this out. I will queue this patch up along with the other changes and send them to Dave this week.

Regards

Marcel

#3 lore raw
Quoted 8 lines · Marcel Holtmann

Hi Oliver and Matthew,

Quoted 6 lines
Quoted 6 lines

commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a

Author: Oliver Neukum <[email protected]>
Date:   Mon Dec 14 22:09:49 2009 +0100

btusb:Prevent illtimed autosuspend

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

The device must be marked busy as it recieves data.

thanks for figuring this out. I will queue this patch up along with the other changes and send them to Dave this week.

This also might be a -stable patch, right? Care to mark it as such?

thanks,

greg k-h

#4 lore raw

Am Donnerstag, 17. Dezember 2009 00:54:50 schrieb Greg KH:

Quoted 11 lines · Marcel Holtmann
Quoted 10 lines

Hi Oliver and Matthew,

Quoted 8 lines
Quoted 8 lines

commit 0b72b0a05c1d950e4f35520926cc36bc01fb998a

Author: Oliver Neukum <[email protected]>
Date:   Mon Dec 14 22:09:49 2009 +0100

btusb:Prevent illtimed autosuspend

The device must be marked busy as it recieves data.

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines
Quoted 1 line

thanks for figuring this out. I will queue this patch up along with the other changes and send them to Dave this week.

This also might be a -stable patch, right? Care to mark it as such?

Oh, you are right. Sorry, yes, this should go into 2.6.32 stable, but nothing earlier. I forgot when btusb autosuspend went in.

Sorry
Oliver