Skip to contentSkip to conversation

libertas driver carrier of signaling

DISCUSSION Samuel Ortiz 2 participants 2 messages Dec 16, 2009 – Dec 17, 2009

lore
Share & tools
lore
#0 lore raw

Hi guys,

I was looking at the libertas driver and found that piece of code, at scan.c:

/* We want to scan all channels */

	chan_count = lbs_scan_create_channel_list(priv, chan_list);

	netif_stop_queue(priv->dev);
	netif_carrier_off(priv->dev);

So, why do we need to turn carrier off when scanning? I could barely see why we'd want to stop the netdev tx queue, but is turning carrier off really needed ?

Thanks in advance for your answers.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#1 lore raw
Quoted 5 lines · Samuel Ortiz

Hi guys,

I was looking at the libertas driver and found that piece of code, at scan.c:

/* We want to scan all channels */

Quoted 8 lines
	chan_count = lbs_scan_create_channel_list(priv, chan_list);

	netif_stop_queue(priv->dev);
	netif_carrier_off(priv->dev);

So, why do we need to turn carrier off when scanning? I could barely see why we'd want to stop the netdev tx queue, but is turning carrier off really needed ?

Probably not. Carrier is largely useless with wireless drivers anyway, though if they for some reason really, really want to use carrier, carrier should only be on when the device is authed & associated to an AP.

Dan