compat-wireless: modules declared as PHONY target in Makefile
RFC 1/1 compat-wireless: modules declared as PHONY target in Makefile
When a particular file alone is modified in compat package, it is not compiled with make. To compile the modified file compat package needs to be cleaned up and all files need to be compiled. This is because all files are compiled in modules target, and file by name modules is not generated. So this target will be considered up-to-date once compiled.
modules target is declared as PHONY target to avoid this problem.
I feel config.mk need not be included when KERNELRELEASE is not NULL as it degrades the performance and doesn't make any difference. Please comment.
--- Makefile | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)
Makefile +1 -3
@@ -15,8 +15,6 @@ DESTDIR?= ifneq ($(KERNELRELEASE),) -include $(M)/$(COMPAT_CONFIG) - NOSTDINC_FLAGS := -I$(M)/include/ -include $(M)/include/linux/compat-2.6.h $(CFLAGS) obj-y := compat/
@@ -295,7 +293,7 @@ wlunload: wlload: wlunload @./scripts/wlload.sh -.PHONY: all clean install uninstall unload load btunload btload wlunload wlload +.PHONY: all clean install uninstall unload load btunload btload wlunload wlload modules endif
Signature · 1 line
1.6.0.4
Quoted 11 lines · Bala Shanmugam
When a particular file alone is modified in compat package, it is not compiled with make. To compile the modified file compat package needs to be cleaned up and all files need to be compiled. This is because all files are compiled in modules target, and file by name modules is not generated. So this target will be considered up-to-date once compiled.
modules target is declared as PHONY target to avoid this problem.
I feel config.mk need not be included when KERNELRELEASE is not NULL as it degrades the performance and doesn't make any difference. Please comment.
Signed-off-by Bala Shanmugam <[email protected]>
I was wondering what caused that to happen, thanks applied.
Luis