Skip to contentSkip to conversation

allow nf_tproxy_core module to unload

PATCH In review Evan McNabb 3 participants 3 messages Dec 18, 2009 – Dec 21, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 allow nf_tproxy_core module to unload

From: Evan McNabb <[email protected]>

Include exit function so nf_tproxy_core module can be removed.

net/netfilter/nf_tproxy_core.c +5 -0
index 5490fc3..ec6737c 100644
@@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
 	return 0;
 }
 
+static void __exit nf_tproxy_exit(void)
+{
+}
+
 module_init(nf_tproxy_init);
+module_exit(nf_tproxy_exit);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Krisztian Kovacs");
maintainer
#1 lore raw

From: Evan McNabb <[email protected]>
Date: Fri, 18 Dec 2009 11:24:40 -0500

Quoted 5 lines

From: Evan McNabb <[email protected]>

Include exit function so nf_tproxy_core module can be removed.

netfilter-devel is the best place to CC: netfilter patches, added...

Quoted 22 lines
net/netfilter/nf_tproxy_core.c +5 -1
index 5490fc3..ec6737c 100644
@@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
 	return 0;
 }
 
+static void __exit nf_tproxy_exit(void)
+{
+}
+
 module_init(nf_tproxy_init);
+module_exit(nf_tproxy_exit);
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Krisztian Kovacs");
--

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

Hi,

Quoted 28 lines · David Miller

From: Evan McNabb <[email protected]>
Date: Fri, 18 Dec 2009 11:24:40 -0500

Quoted 5 lines

From: Evan McNabb <[email protected]>

Include exit function so nf_tproxy_core module can be removed.

netfilter-devel is the best place to CC: netfilter patches, added...

Quoted 16 lines
net/netfilter/nf_tproxy_core.c +5 -0
index 5490fc3..ec6737c 100644
@@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
 	return 0;
 }
 
+static void __exit nf_tproxy_exit(void)
+{
+}
+
 module_init(nf_tproxy_init);
+module_exit(nf_tproxy_exit);
 
Quoted 2 lines

net/netfilter/nf_tproxy_core.c static int __init nf_tproxy_init(void) · line 100

Quoted 2 lines
net/netfilter/nf_tproxy_core.c +0 -0
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Krisztian Kovacs");

I'm afraid it's not that simple...

tproxy sets skb->destructor to nf_tproxy_destructor for certain (redirected) skbs. You must make sure that no skbs have their destructor set to that function before removing the module.

Cheers,
Krisztian