Skip to contentSkip to conversation

kvm: get rid of unused label warning

PATCH Applied Heiko Carstens 2 participants 2 messages Dec 18, 2009 – Dec 20, 2009 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: get rid of unused label warning

From: Heiko Carstens <[email protected]>

arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_vm':
arch/s390/kvm/../../../virt/kvm/kvm_main.c:409: warning: label 'out_err' defined but not used

---

Adds even more ifdefery...

 virt/kvm/kvm_main.c |    3 +++
 1 file changed, 3 insertions(+)
virt/kvm/kvm_main.c +3 -0
@@ -406,8 +406,11 @@ static struct kvm *kvm_create_vm(void)
 out:
 	return kvm;
 
+#if defined(KVM_COALESCED_MMIO_PAGE_OFFSET) || \
+    (defined(CONFIG_MMU_NOTIFIER) && defined(KVM_ARCH_WANT_MMU_NOTIFIER))
 out_err:
 	hardware_disable_all();
+#endif
 out_err_nodisable:
 	kfree(kvm);
 	return ERR_PTR(r);
Applied
#1 lore raw
Quoted 5 lines · Heiko Carstens

From: Heiko Carstens<[email protected]>

arch/s390/kvm/../../../virt/kvm/kvm_main.c: In function 'kvm_create_vm':
arch/s390/kvm/../../../virt/kvm/kvm_main.c:409: warning: label 'out_err' defined but not used

Thanks, applied and queued for 2.6.33. I'll refactor it a bit for .34 to reduce the ifdefs.

Signature · 1 line
error compiling committee.c: too many arguments to function