Skip to contentSkip to conversation

ARM: Fix build break on ARM v6 and v7

PATCH New Anand Gadiyar 2 participants 2 messages Dec 18, 2009 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Fix build break on ARM v6 and v7

Commit 2c9b9c849 added an argument to __cpuc_flush_dcache_page and renamed it.

Update a caller of the old function to fix this build error:

CC arch/arm/mm/copypage-v6.o
arch/arm/mm/copypage-v6.c: In function 'v6_copy_user_highpage_nonaliasing':
arch/arm/mm/copypage-v6.c:51: error: implicit declaration of function '__cpuc_flush_dcache_page' make[1]: *** [arch/arm/mm/copypage-v6.o] Error 1
make: *** [arch/arm/mm] Error 2

---
Russell,

I fixed this almost independently at roughly the same time as your mail on the list. Do I still get credit for the patch?

Either way, it's okay with me. I'm just asking.

- Anand

arch/arm/mm/copypage-v6.c +1 -1
index 841f355..0fa1319 100644
@@ -48,7 +48,7 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to,
 	 */
 	if (page_address(to) != NULL)
 #endif
-		__cpuc_flush_dcache_page(kto);
+		__cpuc_flush_dcache_area(kto, PAGE_SIZE);
 	kunmap_atomic(kto, KM_USER1);
 	kunmap_atomic(kfrom, KM_USER0);
 }
#1 lore raw

PATCH 1/1 ARM: Fix build break on ARM v6 and v7

Quoted 12 lines · Anand Gadiyar

Commit 2c9b9c849 added an argument to __cpuc_flush_dcache_page and renamed it.

Update a caller of the old function to fix this build error:

CC arch/arm/mm/copypage-v6.o
arch/arm/mm/copypage-v6.c: In function 'v6_copy_user_highpage_nonaliasing':
arch/arm/mm/copypage-v6.c:51: error: implicit declaration of function '__cpuc_flush_dcache_page' make[1]: *** [arch/arm/mm/copypage-v6.o] Error 1
make: *** [arch/arm/mm] Error 2

Quoted 7 lines

---
Russell,

I fixed this almost independently at roughly the same time as your mail on the list. Do I still get credit for the patch?

Patch is good. If you want to convert the NYET-sob to a proper signed-off-by, and throw it at the patch system...