Skip to contentSkip to conversation

nfsd: fix "insecure" export option

PATCH New J. Bruce Fields 1 participant 1 message Dec 20, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nfsd: fix "insecure" export option

From: J. Bruce Fields <[email protected]>

A typo in 12045a6ee9908b "nfsd: let "insecure" flag vary by pseudoflavor" reversed the sense of the "insecure" flag.

---
 fs/nfsd/nfsfh.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

This is a regression introduced by the 2.6.33 nfsd merge. You can also pull it from:

	git://linux-nfs.org/~bfields/linux.git for-2.6.33
fs/nfsd/nfsfh.c +1 -1
index 1c12177..55c8e63 100644
@@ -89,7 +89,7 @@ static __be32 nfsd_setuser_and_check_port(struct svc_rqst *rqstp,
 	int flags = nfsexp_flags(rqstp, exp);
 
 	/* Check if the request originated from a secure port. */
-	if (!rqstp->rq_secure && (flags & NFSEXP_INSECURE_PORT)) {
+	if (!rqstp->rq_secure && !(flags & NFSEXP_INSECURE_PORT)) {
 		RPC_IFDEBUG(char buf[RPC_MAX_ADDRBUFLEN]);
 		dprintk(KERN_WARNING
 		       "nfsd: request from insecure port %s!\n",
Signature · 1 line
1.6.3.3