Skip to contentSkip to conversation

BKL use in ptrace

DISCUSSION Andi Kleen 3 participants 3 messages Dec 20, 2009 – Dec 22, 2009

lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

Hi,

ptrace has this comment/BKL use:

        /*
         * This lock_kernel fixes a subtle race with suid exec
         */
        lock_kernel();

But unless I'm blind I don't see execve actually getting the BKL anywhere. So is this comment outdated or misleading (is the race with exit?) or is there a bug?

Thanks,
-Andi

Signature · 1 line
[email protected] -- Speaking for myself only.
#1 lore raw

(add Roland)

Quoted 11 lines · Andi Kleen

ptrace has this comment/BKL use:

        /*
         * This lock_kernel fixes a subtle race with suid exec
         */
        lock_kernel();

But unless I'm blind I don't see execve actually getting the BKL anywhere. So is this comment outdated or misleading (is the race with exit?) or is there a bug?

I never understood this lock_kernel().

In any case it looks outdated. We were going to kill it "soon", along with other ptrace changes.

Oleg.

#2 lore raw
Quoted 4 lines

I never understood this lock_kernel().

In any case it looks outdated. We were going to kill it "soon", along with other ptrace changes.

I never understood it either. It's very ancient and long predates many, many ptrace cleanups. If the comment was ever accurate, then any issue like that is now covered by cred_guard_mutex. I don't know of any reason for (or really, effect of) using BKL in ptrace.

Thanks,
Roland