Skip to contentSkip to conversation

g_NCR5380: fix broken MMIO compilation

PATCH In review Ondrej Zary 2 participants 3 messages Dec 20, 2009

Subsystems (2)
SCSI Ncr 5380 SCSI drivers
lore
Share & tools
lore

Ondrej Zary

author
#0 lore raw

PATCH 2/3 g_NCR5380: fix broken MMIO compilation

The ifdefs are broken so the MMIO code is never compiled and so it's broken too. Fix them all.
Untested as I don't have the hardware.

Signed-off-by Ondrej Zary <[email protected]>
drivers/scsi/g_NCR5380.h +3 -3
@@ -63,7 +63,7 @@ static const char* generic_NCR5380_info(
 #define __STRVAL(x) #x
 #define STRVAL(x) __STRVAL(x)
 
-#ifndef CONFIG_SCSI_G_NCR5380_MEM
+#ifndef SCSI_G_NCR5380_MEM
 
 #define NCR5380_map_config port
 #define NCR5380_map_type int

@@ -91,7 +91,7 @@ static const char* generic_NCR5380_info(
     NCR5380_map_name = (NCR5380_map_type)((instance)->NCR5380_instance_name)
 
 #else 
-/* therefore CONFIG_SCSI_G_NCR5380_MEM */
+/* therefore SCSI_G_NCR5380_MEM */
 
 #define NCR5380_map_config memory
 #define NCR5380_map_type unsigned long

@@ -114,7 +114,7 @@ static const char* generic_NCR5380_info(
     register void __iomem *iomem
 
 #define NCR5380_setup(instance) \
-    iomem = (((struct NCR5380_hostdata *)(instance)->hostdata).iomem)
+    iomem = (((struct NCR5380_hostdata *)(instance)->hostdata)->iomem)
 
 #endif
drivers/scsi/g_NCR5380.c +23 -20

155 lines not on this page · raw message

Signature · 1 line
Ondrej Zary
#1 lore raw
Quoted 3 lines · Ondrej Zary

The ifdefs are broken so the MMIO code is never compiled and so it's broken too. Fix them all.
Untested as I don't have the hardware.

I still have a DTC-xxxx card in use (under Windows95) and a SUMO SCSI AT (usable with g_NCR5380 with a minor hack to toggle a flip flop that gates interrupts to the ISA bus). :)

I think both cards are wired to use I/O space and not memory space, so they are of no help for testing MMIO. :(

But, ah memories....

Regards,
Andy

author
#2 lore raw
Quoted 11 lines · On Sunday 20 December 2009 21:15:44 Andy Walls wrote:
Quoted 3 lines · Ondrej Zary

The ifdefs are broken so the MMIO code is never compiled and so it's broken too. Fix them all.
Untested as I don't have the hardware.

I still have a DTC-xxxx card in use (under Windows95) and a SUMO SCSI AT (usable with g_NCR5380 with a minor hack to toggle a flip flop that gates interrupts to the ISA bus). :)

I think both cards are wired to use I/O space and not memory space, so they are of no help for testing MMIO. :(

I have some cards but probably none of them is memory mapped:
DTCT-436P (PnP) - this seems to work (but don't have proper SCSI cable to test it really)
HP C2505 (53C400A) - does not work (wrote about this card to LKML in 2004) Canon FG2-5202 (53C400) - does not work

Quoted 9 lines

But, ah memories....

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 1 line
Ondrej Zary