Skip to contentSkip to conversation

ia64: Include <linux/personality.h> header in <asm/fcntl.h>

PATCH In review Ben Hutchings 2 participants 2 messages Dec 19, 2009 – Dec 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ia64: Include <linux/personality.h> header in <asm/fcntl.h>

The definition of force_o_largefile() references personality, but this header does not include <linux/personality.h>. This happens to work for sys_open(), but may not for any other users. In particular, aufs2 now uses this macro and so fails to build on ia64.

---
 arch/ia64/include/asm/fcntl.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/ia64/include/asm/fcntl.h +2 -0
index 1dd275d..3cac8f9 100644
@@ -5,6 +5,8 @@
  *	David Mosberger-Tang <[email protected]>, Hewlett-Packard Co.
  */
 
+#include <linux/personality.h>
+
 #define force_o_largefile()	\
 		(personality(current->personality) != PER_LINUX32)
 
Signature · 1 line
1.6.5.7
#1 lore raw

Re: [PATCH] ia64: Include <linux/personality.h> header in

Quoted 4 lines · Ben Hutchings

The definition of force_o_largefile() references personality, but this header does not include <linux/personality.h>. This happens to work for sys_open(), but may not for any other users. In particular, aufs2 now uses this macro and so fails to build on ia64.

So include the header there directly. Or rather don't use it at all, filesystems have no business at all messing with this.