Skip to contentSkip to conversation

Why is ARCH m68k hardwired into drivers/net/wan/Makefile?

DISCUSSION Rob Landley 4 participants 6 messages Dec 21, 2009 – Dec 22, 2009 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

Anyone have an opinion on this?

Quoted 9 lines

From drivers/net/wan/Makefile:

ifeq ($(ARCH),m68k)
AS68K = $(AS)
LD68K = $(LD)
else
AS68K = as68k
LD68K = ld68k
endif

Signature · 1 line
Latency is more important than throughput. It's that simple. - Linus Torvalds
#1 lore raw
Quoted 4 lines · Rob Landley

Anyone have an opinion on this?

From drivers/net/wan/Makefile:

You cut one important line here:

| ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)

Quoted 7 lines
Quoted 7 lines

ifeq ($(ARCH),m68k)
 AS68K = $(AS)
 LD68K = $(LD)
else
 AS68K = as68k
 LD68K = ld68k
endif

The corresponding Kconfig entry reads:

config WANXL_BUILD_FIRMWARE
bool "rebuild wanXL firmware"
depends on WANXL && !PREVENT_FIRMWARE_BUILD
help
Allows you to rebuild firmware run by the QUICC processor. It requires as68k, ld68k and hexdump programs.

You should never need this option, say N.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

#2 lore raw
Quoted 25 lines · On Monday 21 December 2009 03:57:49 Geert Uytterhoeven wrote:
Quoted 3 lines · Rob Landley

Anyone have an opinion on this?

From drivers/net/wan/Makefile:

You cut one important line here:
| ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
|

Quoted 7 lines
Quoted 7 lines

ifeq ($(ARCH),m68k)
AS68K = $(AS)
LD68K = $(LD)
else
AS68K = as68k
LD68K = ld68k
endif

The corresponding Kconfig entry reads:

config WANXL_BUILD_FIRMWARE
bool "rebuild wanXL firmware"
depends on WANXL && !PREVENT_FIRMWARE_BUILD
help
Allows you to rebuild firmware run by the QUICC processor. It requires as68k, ld68k and hexdump programs.

Quoted 3 lines

You should never need this option, say N.

Gr{oetje,eeting}s,

Ah, the card has an onboard m68k processor, separate from the host CPU.

Rob

Signature · 1 line
Latency is more important than throughput. It's that simple. - Linus Torvalds

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw
Quoted 15 lines · Rob Landley
Quoted 12 lines · On Monday 21 December 2009 01:06:38 Brian Gerst wrote:
Quoted 10 lines · Rob Landley

Anyone have an opinion on this?

From drivers/net/wan/Makefile:

Quoted 7 lines

ifeq ($(ARCH),m68k)
 AS68K = $(AS)
 LD68K = $(LD)
else
 AS68K = as68k
 LD68K = ld68k
endif

Quoted 1 line

Looks like it's to build firmware to run on the card.

Quoted 8 lines

Sure, I'm just wondering why such obvious arch-specific code is outside the arch/m68k directory.

In theory, when you're building for m68k, you supply appropriate AS and LD values already (or the rest of the kernel won't build).  If you're not building for m68k and this driver only supports m68k, then the config should prevent you from selecting it.  So why is on earth is architecture-specific tool selection being done in drivers/net/wan?

The m68k processor that this firmware is being built for is embedded on the device, not the main system cpu. You can have one of these cards on any system, not just m68k.

PS. always CC the list with replies.

--
Brian Gerst

#6 lore raw
Quoted 25 lines · On Monday 21 December 2009 08:48:31 Brian Gerst wrote:
Quoted 15 lines · Rob Landley
Quoted 12 lines · On Monday 21 December 2009 01:06:38 Brian Gerst wrote:
Quoted 10 lines · Rob Landley

Anyone have an opinion on this?

From drivers/net/wan/Makefile:

Quoted 7 lines

ifeq ($(ARCH),m68k)
AS68K = $(AS)
LD68K = $(LD)
else
AS68K = as68k
LD68K = ld68k
endif

Quoted 1 line

Looks like it's to build firmware to run on the card.

Quoted 8 lines

Sure, I'm just wondering why such obvious arch-specific code is outside the arch/m68k directory.

In theory, when you're building for m68k, you supply appropriate AS and LD values already (or the rest of the kernel won't build). If you're not building for m68k and this driver only supports m68k, then the config should prevent you from selecting it. So why is on earth is architecture-specific tool selection being done in drivers/net/wan?

Quoted 5 lines

The m68k processor that this firmware is being built for is embedded on the device, not the main system cpu. You can have one of these cards on any system, not just m68k.

PS. always CC the list with replies.

Happy to, but your message to me didn't cc the list, and I thought cc-ing private mail back to the list was impolite.

Explicitly saying somewhere "this card has an onbaord m68k processor even if the host doesn't" might be nice. I eventually figured it out, but neither the makefile nor the firmware source actually said the card had an onboard processor, and my first glance at the kconfig help text just went "it's code for a QUICC processor, that's one of those freescale SoCs isnt it? I vaguely recall booting Linux on one of those back in 2006..."

(Possibly I've been doing a bit too much embedded development lately. :)

Rob

Signature · 1 line
Latency is more important than throughput. It's that simple. - Linus Torvalds
#7 lore raw
Quoted 6 lines · Rob Landley

Explicitly saying somewhere "this card has an onbaord m68k processor even if the host doesn't" might be nice. I eventually figured it out, but neither the makefile nor the firmware source actually said the card had an onboard processor, and my first glance at the kconfig help text just went "it's code for a QUICC processor, that's one of those freescale SoCs isnt it? I vaguely recall booting Linux on one of those back in 2006..."

QUICC = QUad Integrated Communications Controller (Morotola 68360) chip and is based on m68020 IIRC. There is no "normal" m68k CPU on this board.

PowerQUICC is a different thing.

Signature · 1 line
Krzysztof Halasa