Skip to contentSkip to conversation

net/sctp/socket.c: squish warning

PATCH Applied [email protected] 2 participants 2 messages Dec 22, 2009 – Jan 4, 2010

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/sctp/socket.c: squish warning

From: Andrew Morton <[email protected]>

net/sctp/socket.c: In function 'sctp_setsockopt_autoclose':
net/sctp/socket.c:2090: warning: comparison is always false due to limited range of data type

Cc Andrei Pelinescu-Onciul <[email protected]>
Cc Vlad Yasevich <[email protected]>
Cc "David S. Miller" <[email protected]>

---

 net/sctp/socket.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
net/sctp/socket.c renamed from net/sctp/socket.c~net-sctp-socketc-squish-warning +1 -2
diff -puN net/sctp/socket.c~net-sctp-socketc-squish-warning net/sctp/socket.c
@@ -2087,8 +2087,7 @@ static int sctp_setsockopt_autoclose(str
 	if (copy_from_user(&sp->autoclose, optval, optlen))
 		return -EFAULT;
 	/* make sure it won't exceed MAX_SCHEDULE_TIMEOUT */
-	if (sp->autoclose > (MAX_SCHEDULE_TIMEOUT / HZ) )
-		sp->autoclose = (__u32)(MAX_SCHEDULE_TIMEOUT / HZ) ;
+	sp->autoclose = min_t(long, sp->autoclose, MAX_SCHEDULE_TIMEOUT / HZ);
 
 	return 0;
 }

_

maintainer Applied
#1 lore raw

From: [email protected]
Date: Mon, 21 Dec 2009 16:25:06 -0800

Quoted 9 lines

From: Andrew Morton <[email protected]>

net/sctp/socket.c: In function 'sctp_setsockopt_autoclose':
net/sctp/socket.c:2090: warning: comparison is always false due to limited range of data type

Cc Andrei Pelinescu-Onciul <[email protected]>
Cc Vlad Yasevich <[email protected]>
Cc "David S. Miller" <[email protected]>

Applied.