Skip to contentSkip to conversation

Upgrade glibc from 2.6.1 to 2.10.1, the 2.6.1 glibc cause ltrace compilation failed

PATCH In review Guo Hongruan 2 participants 4 messages Dec 25, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Upgrade glibc from 2.6.1 to 2.10.1, the 2.6.1 glibc cause ltrace compilation failed

the include/sys/ptrace.h of glibc 2.6.1 does not include the PTRACE_EVENT* macroes, which is needed by ltrace. the one of glibc 2.10.1 does include them and on it the compilation of ltrace succeed

---
 conf/distro/include/sane-toolchain.inc |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
conf/distro/include/sane-toolchain.inc +2 -2
index 7bf1963..39bc9aa 100644
@@ -9,8 +9,8 @@ PREFERRED_GCC_VERSION                ?= "4.4.2"
 PREFERRED_BINUTILS                   ?= "2.20"
 
 # Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
-PREFERRED_VERSION_glibc             ?= "2.6.1"
-PREFERRED_VERSION_glibc-initial     ?= "2.6.1"
+PREFERRED_VERSION_glibc             ?= "2.10.1"
+PREFERRED_VERSION_glibc-initial     ?= "2.10.1"
 PREFERRED_VERSION_eglibc             ?= "2.10"
 PREFERRED_VERSION_eglibc-initial     ?= "2.10"
 PREFERRED_VERSION_uclibc            ?= "0.9.30.1"
Signature · 1 line
1.5.4.3
#1 lore raw
Quoted 3 lines · On Friday 25 December 2009 04:42:53 Guo Hongruan wrote:

the include/sys/ptrace.h of glibc 2.6.1 does not include the PTRACE_EVENT*
macroes, which is needed by ltrace. the one of glibc 2.10.1 does include them and on it the compilation of ltrace succeed ---

That is quite a bad reason to upgrade the default. The problem is you would have to convince us that glibc 2.10.1 is working just fine for arm, armeb, mips, mipsel, powerpc, avr, sparc, i486, i586... Or at least your commit message should include the information that you have tested builds with it.

Then again. It is pretty common that older versions of a library do not have newere definitions of syscalls and syscall parameters (e.g. most notable this happened with the addition of inotify and early adaption of it). The fix is the one you proposed. Check if the system has the definition, if not define it locally.

regards
holger

#2 lore raw
Quoted 10 lines · 在 Fri, 25 Dec 2009 12:46:52 +0800,Holger Hans Peter Freyther…
Quoted 4 lines · On Friday 25 December 2009 04:42:53 Guo Hongruan wrote:

the include/sys/ptrace.h of glibc 2.6.1 does not include the PTRACE_EVENT*
macroes, which is needed by ltrace. the one of glibc 2.10.1 does
include
them and on it the compilation of ltrace succeed ---

That is quite a bad reason to upgrade the default. The problem is you would have to convince us that glibc 2.10.1 is working just fine for arm, armeb, mips, mipsel, powerpc, avr, sparc, i486, i586... Or at least your commit message should include the information that you have tested builds with it.

The include/sys/ptrace.h of glibc 2.6.1 lacks of the above macroes, this is a bug of it, which was fixed by the later glibc There is a newer version of glibc recipes, so I have no reason to not test with it.

Yes, I have not validated on some much architecture. It is only verified on qemux86 and minimal.conf.

Quoted 18 lines

Then again. It is pretty common that older versions of a library do not have newere definitions of syscalls and syscall parameters (e.g. most notable this happened with the addition of inotify and early adaption of it). The fix is the one you proposed. Check if the system has the definition, if not define it locally.

regards
holger

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 4 lines
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com
#3 lore raw
Quoted 5 lines · On Friday 25 December 2009 07:16:00 Guo Hongruan wrote:

在 Fri, 25 Dec 2009 12:46:52 +0800,Holger Hans Peter Freyther

The include/sys/ptrace.h of glibc 2.6.1 lacks of the above macroes, this is a bug of it, which was fixed by the later glibc There is a newer version of glibc recipes, so I have no reason to not test with it.

Sure you have no reason to not test it but that is different from changing the default for everyone else. The other thing from released software something is always missing...